From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0256A329E4F for ; Tue, 10 Feb 2026 13:38:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.194 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770730699; cv=none; b=nC8e6siQ2O1+6dpnY7xjhZQHDZHjqklGjNryu9WS8WTtCLvIpcV1PCs1wBT4gp3PeDvvam3Ns9XBVFghI20vf55KNsstTFdXg50d/2Kq6uUrxSxcX4pJSe7doN/+Qqk8bsfiCy5LJpRefg+6COxlTMkyPcmRW8syKJ50lbxSiLU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770730699; c=relaxed/simple; bh=eSiyajRfADetRtl07XOsNLJn5q9P8Wq2Xej9cMuod44=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WJydmAmA2T/gpmwmcNA/33cXZahSlT4f3UKze6IFVEc2teQTjhe8I4uwhAUWT75JVYpxDrOnkhN5M+sMw3BDga0DzSA2hVeFdHXRVoF393W8qyE8ub3kx50TYnDcsnWHYiFKy/xdQ+CTAX0efWP17k+ZOfi3c8BmMyxs9woAVIM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gGk9rpeD; arc=none smtp.client-ip=209.85.215.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gGk9rpeD" Received: by mail-pg1-f194.google.com with SMTP id 41be03b00d2f7-c6dd0ec465aso1742683a12.1 for ; Tue, 10 Feb 2026 05:38:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770730697; x=1771335497; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=CplpPqZDHlPGdF2ef9i2q426qAgQJ2NUjvLt++VdFbc=; b=gGk9rpeDcvrR/gxsoJg21rTkJqIgATtZHoWb/zV646nJr7EKQ7UxZyTWOWaEOpIr7u F9gKjtktryh8AmTD5nKqnIWBel5MlVcE1x1p+WIOeJQWgHoHBh8H8p5mE9tK9YN3VNiS rBXwTm+Pd4nHE2lYe4ROw/LkFjFH1/Opx2drRDHEGLbxi9dPH5fk/MhQ6Gc2m5TfK4qe CNwZb7n/rkkpkq8YG/OX2MVCVfYuSCajqZRxmYohVObLs8twEZSxXrgzCXuANzkQc25n 3qxhLwL+pPKFAJCH3dmAH2k/RwlW5Bq1JQYUy7Ty7yRt4S64fjxwOREW9IT8l7Z5ZD9h MghA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770730697; x=1771335497; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CplpPqZDHlPGdF2ef9i2q426qAgQJ2NUjvLt++VdFbc=; b=BuREP8vw06SaEvf2E4AnEMnowqok129lAkXdmvFvpb/eLB86W7z5kVX33VECI8BjDb 88XOPar2izw29mdxNUDGqWedVikvtrhdMD0oSA4nwVKFWz34r9iZFQLKGvga435uim97 kR0dg4OxLT30r1rcNhZaHKyDX5IrXMxzblUstjUMHVhFEcJfdWhQrH3ytOwaNnT1BmRv C+D9ATfTm0lYbc2GGG3CuUitHxykJIsopAAhdoq6lQ4L49Lhp8iygVdF6ZaILkx1Pwah uuWUkJGH1MHSqzxPg14JfSfDp9YlBhVNS3UXs4uLr5dbTUh4Q8AlhSBLu8VjPdN42DEn xHJw== X-Forwarded-Encrypted: i=1; AJvYcCVPYDOdXXmDVFG8bfXIGtoRitsjOBrAMeRXNRinxmu6LThksctkFhfOhs3QK0Y6mwrhhKJj+T2u0wuD0PU=@vger.kernel.org X-Gm-Message-State: AOJu0YxU6RbCND4xZviL63mOcyELBiW6+qwxyEjmF4uJb4dkOsPkxQ9b ndAr21ZMZfmGjuFWtV4BthZFaewVc/+MW0crmGVUmfb8tLmibXMIGSbRt0/c4x0DLBY= X-Gm-Gg: AZuq6aLHIY/oZmcw4vNF9kMBks0LJR4GqM9l/58tywNOA4TJS8z0zZsME4Qc1ZcJlkq lfaSBPj7OKVMsmQ523DDXWV4ZkkFqRD+KDoCJ9aloZyeC9mSjxoDvJ6GnQpkZt4i5g8GPAaDZV5 Cl7WMJt7wQONyuTym1nIOQfQSHi0CTBd9Caskgv7kasXiWWa71KRE88e4AdvsBTPiGyc9dct6AK r4VNpjEONLUK8SrDilvkpJ24cOQhx7jIiFCGrIcCcnpKPPqq3SySei1jKycdLfe62Aom2sTM5f6 /ZS+zjsWSMvRW6BVJ+Ypr7c3SB0iS706XedyZbS5JV3zHZGzoeoLEZrF0WlFo0bwW1G3WpYj69R yy/kIib8wRl335ptzmaQ2qYEonkTKh/QRa6j0/s1FZSCs9TIs0yV3fS8vB23HM1NwiwFs507oQe EtEiouKvL2ms79hGbeFUGrf7YXAyDUjy/5V6Lay2k5sE8= X-Received: by 2002:a17:902:e5c2:b0:2aa:d6a1:e183 with SMTP id d9443c01a7336-2ab1005a8aamr22783735ad.1.1770730697195; Tue, 10 Feb 2026 05:38:17 -0800 (PST) Received: from [192.168.116.129] ([49.205.43.62]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2aad3c91fd1sm138660585ad.16.2026.02.10.05.38.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Feb 2026 05:38:16 -0800 (PST) Message-ID: <0d336a3f-f317-4a70-942a-d87a3faa3a89@gmail.com> Date: Tue, 10 Feb 2026 19:08:09 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 0/4] rust: alloc: add Vec shrinking methods To: Danilo Krummrich , Lorenzo Stoakes , Vlastimil Babka , "Liam R. Howlett" , Uladzislau Rezki , Miguel Ojeda , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Greg Kroah-Hartman , =?UTF-8?Q?Arve_Hj=C3=B8nnev=C3=A5g?= , Todd Kjos , Christian Brauner , Carlos Llamas Cc: rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260207-binder-shrink-vec-v3-v3-0-8ff388563427@cock.li> Content-Language: en-US From: Shivam Kalra In-Reply-To: <20260207-binder-shrink-vec-v3-v3-0-8ff388563427@cock.li> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit This is a follow-up to my v3 series: https://lore.kernel.org/rust-for-linux/20260207-binder-shrink-vec-v3-v3-0-8ff388563427@cock.li/ Hi all, Thanks for the feedback on v3. Before I respin, I want to confirm the direction for v4 to avoid unnecessary iterations. Proposed changes for v4: 1. Drop the Shrinkable trait entirely. Make shrink_to() a normal method on Vec that calls A::realloc(). (Danilo) 2. Add a temporary ShrinkQuirk trait to handle the vmalloc workaround (page-boundary check + manual alloc+copy+free) until vrealloc gains in-place shrinking support. (Danilo) 3. In the binder patch, use a less aggressive shrink strategy to avoid shrink-then-regrow oscillation: (Alice) if len < cap / 4 { shrink_to(cap / 2); } 4. Fix commit prefix to rust_binder: instead of rust: binder:. (Alice) Also noting that starting from v4, I will be sending patches from a new email address: shivamkalra98@gmail.com Does this look right? Any other concerns before I send v4? Thanks, Shivam Note: I previously sent patches as shivamklr@cock.li. That account has run out of quota, so I'm continuing from shivamkalra98@gmail.com going forward. All future patches (v4+) will come from this address.