From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BED7C35242 for ; Mon, 17 Feb 2020 06:31:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CDE56206F4 for ; Mon, 17 Feb 2020 06:31:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=c-s.fr header.i=@c-s.fr header.b="qsp3FcoV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726314AbgBQGbR (ORCPT ); Mon, 17 Feb 2020 01:31:17 -0500 Received: from pegase1.c-s.fr ([93.17.236.30]:38918 "EHLO pegase1.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725873AbgBQGbR (ORCPT ); Mon, 17 Feb 2020 01:31:17 -0500 Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 48LYz30xBJz9tyKv; Mon, 17 Feb 2020 07:31:11 +0100 (CET) Authentication-Results: localhost; dkim=pass reason="1024-bit key; insecure key" header.d=c-s.fr header.i=@c-s.fr header.b=qsp3FcoV; dkim-adsp=pass; dkim-atps=neutral X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id 58-kPQzPnR-F; Mon, 17 Feb 2020 07:31:11 +0100 (CET) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 48LYz26lZ8z9tyKt; Mon, 17 Feb 2020 07:31:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=c-s.fr; s=mail; t=1581921070; bh=Hgi3ypUkfbLg/h7YzQMYOwDmEkgVzSHWMc1RBorVoxQ=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=qsp3FcoV9oyuESfmt2dP/QDODLjOkxnSnMya2Ltlksqsl38oOo3pXu/Icec2CGFM8 6kGj2L2+cjl8SSIx+2e2m/rdIISbQvwIV3vhJCSKgWna3TTyBjrFB6qQeqwU/GhaNm G0wRKzWBMuT1geiJDn5Wjcs/zkK+OQQ2gbD1sbNQ= Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 602818B79C; Mon, 17 Feb 2020 07:31:15 +0100 (CET) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id PNlTi_jw4LA4; Mon, 17 Feb 2020 07:31:15 +0100 (CET) Received: from [172.25.230.102] (unknown [172.25.230.102]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 417D38B755; Mon, 17 Feb 2020 07:31:15 +0100 (CET) Subject: Re: [PATCH 1/1] powerpc/cputable: Remove unnecessary copy of cpu_spec->oprofile_type To: Leonardo Bras , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Greg Kroah-Hartman , Thomas Gleixner , desnesn@linux.ibm.com Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org References: <20200215053637.280880-1-leonardo@linux.ibm.com> From: Christophe Leroy Message-ID: <0d33a8b2-a7e5-c3e0-b28a-fd39f1231d97@c-s.fr> Date: Mon, 17 Feb 2020 07:31:14 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200215053637.280880-1-leonardo@linux.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 15/02/2020 à 06:36, Leonardo Bras a écrit : > Before checking for cpu_type == NULL, this same copy happens, so doing > it here will just write the same value to the t->oprofile_type > again. > > Remove the repeated copy, as it is unnecessary. > > Signed-off-by: Leonardo Bras > --- > arch/powerpc/kernel/cputable.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/powerpc/kernel/cputable.c b/arch/powerpc/kernel/cputable.c > index e745abc5457a..5a87ec96582f 100644 > --- a/arch/powerpc/kernel/cputable.c > +++ b/arch/powerpc/kernel/cputable.c > @@ -2197,7 +2197,6 @@ static struct cpu_spec * __init setup_cpu_spec(unsigned long offset, > */ > if (old.oprofile_cpu_type != NULL) { > t->oprofile_cpu_type = old.oprofile_cpu_type; > - t->oprofile_type = old.oprofile_type; > } The action being reduced to a single line, the { } should be removed. Christophe