From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.manjaro.org (mail.manjaro.org [116.203.91.91]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A7401E7C18 for ; Fri, 8 Nov 2024 14:36:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=116.203.91.91 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731076614; cv=none; b=vApjf2VStk1pYD9PHE/cAHv7cEoLmBn4StYzmqWf046PgrCdgYMtolfO47DYAEeDqmHK9OCnEs+0vv6u6X4hCPQ9QkQtV0XkWy1vCRzlRHg61zeavjm8Ar1WUjCMkwktfmsA+no8I+2c7RMKWHyw2lVE5W2VlJOparnc7DVPUj8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731076614; c=relaxed/simple; bh=JA0Yk40hCY9fR269H+CXry0GvrmOzZe+NVpYrSrNF1E=; h=MIME-Version:Date:From:To:Cc:Subject:In-Reply-To:References: Message-ID:Content-Type; b=AoT4l+oUXIMMBkuO5k3j/FTAH6IYGIzQfLvOlHslXfRFP5cQ8l5Q9syVnQQfHTSCeJgcnGeNHGvCUjjV62GFkaQK+ha5DZGYmH7TYR7RRAkDF3QUNxGPjvMKXouw1knEKDAy0gZd+YzE5RuV5wtWLbwT47AUipgnj9f8X0KXc0g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=manjaro.org; spf=pass smtp.mailfrom=manjaro.org; dkim=pass (2048-bit key) header.d=manjaro.org header.i=@manjaro.org header.b=NrSNHOvH; arc=none smtp.client-ip=116.203.91.91 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=manjaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=manjaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=manjaro.org header.i=@manjaro.org header.b="NrSNHOvH" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1731076609; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hyP1F57LEd+5mTUT+FTnx82w2gEdUv9YO30BPIaE8VU=; b=NrSNHOvH86y7hlWG6DuH+NoSXK7BlZNTXBQzYJWpo9NCd7ZHolaaFE4jUsHCWM+abUqeGZ 1u8lpgYqDyWfy9JyH2xIZ5BGOUgTbwjk7AC99yKH/dbXBUh9rqotapfXPZYdXb4NxRw/0x 6MoRpuqh29JwbADNCRqrDLU1KymGeqsN19gUhxWrKzO0QpeVmSOO+O9ogbqaa8SvRgqFLU H4J2Daclot9SaBZhSCNfgLvE3YvgwgDUN+1JCv5SJ38DrZ1XmexpXrQaAs/lx+Pa7RV/oj rnvqiQef7N4H0iqzYvURxiyQYpmrnsTGhytRzNgjGRPvGr/AVOwsbCjra2dgnQ== Date: Fri, 08 Nov 2024 15:36:49 +0100 From: Dragan Simic To: =?UTF-8?Q?Heiko_St=C3=BCbner?= Cc: linux-rockchip@lists.infradead.org, dri-devel@lists.freedesktop.org, hjc@rock-chips.com, andy.yan@rock-chips.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] drm/rockchip: dsi: Perform trivial code cleanups In-Reply-To: References: <10558711.nUPlyArG6x@diego> <047164cc6e88dcbc7701cb0e28d564db@manjaro.org> <22484879.EfDdHjke4D@diego> Message-ID: <0d3723ecfe7889aa8e4b68b961cdffc5@manjaro.org> X-Sender: dsimic@manjaro.org Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org On 2024-11-08 15:30, Dragan Simic wrote: > On 2024-11-08 15:22, Heiko Stübner wrote: >> Am Freitag, 8. November 2024, 15:13:33 CET schrieb Dragan Simic: >>> On 2024-11-08 15:09, Heiko Stübner wrote: >>> > Am Freitag, 8. November 2024, 15:05:02 CET schrieb Dragan Simic: >>> >> On 2024-11-08 14:56, Heiko Stübner wrote: >>> >> > Am Freitag, 8. November 2024, 14:53:57 CET schrieb Dragan Simic: >>> >> >> Perform a few trivial code cleanups, to make one logged message a bit >>> >> >> more >>> >> >> consistent with the other logged messages by capitalizing its first >>> >> >> word, and >>> >> >> to avoid line wrapping by using the 100-column width better. >>> >> >> >>> >> >> No intended functional changes are introduced by these code cleanups. >>> >> >> >>> >> >> Signed-off-by: Dragan Simic >>> >> >> --- >>> >> >> drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c | 12 ++++-------- >>> >> >> 1 file changed, 4 insertions(+), 8 deletions(-) >>> >> >> >>> >> >> diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c >>> >> >> b/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c >>> >> >> index 58a44af0e9ad..f451e70efbdd 100644 >>> >> >> --- a/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c >>> >> >> +++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c >>> >> >> @@ -1379,7 +1379,7 @@ static int dw_mipi_dsi_rockchip_probe(struct >>> >> >> platform_device *pdev) >>> >> >> } >>> >> >> >>> >> >> if (!dsi->cdata) { >>> >> >> - DRM_DEV_ERROR(dev, "no dsi-config for %s node\n", np->name); >>> >> >> + DRM_DEV_ERROR(dev, "No dsi-config for %s node\n", np->name); >>> >> > >>> >> > this is all probe-related, why not convert to dev_err_probe? >>> >> > >>> >> > As the doc states [0], DRM_DEV_ERROR is deprecated in favor of dev_err. >>> >> > So dev_err_probe would be the correct way to go? >>> >> >>> >> Thanks for your quick response! Seeing that DRM_DEV_ERROR() is now >>> >> deprecated (which I originally missed, in all honesty) makes me very >>> >> happy. :) I've never been a huge fan of the format of the messages >>> >> that DRM_DEV_ERROR() produces. >>> >> >>> >> However, perhaps it would be better to keep these patches as-is, as >>> >> some kind of an intermediate, limited-scope cleanup + bugfix combo, >>> >> and leave the complete DRM_DEV_ERROR() --> dev_err()/dev_err_probe() >>> >> conversion to separate patches. I think it would be better to avoid >>> >> a partial conversion, and I'll be more than happy to put the complete >>> >> conversion on my TODO list. :) >>> > >>> > But your patch-2 really just open-codes, what dev_err_probe is meant >>> > to fix. So with going this way, you're sort of making things worse >>> > first, >>> > until that second step happens. >>> > >>> > Similarly, reflowing lines for things that get removed in a week do not >>> > serve a purpose - those line-breaks have been that way for years >>> > already. >>> >>> Hmm, it makes sense when described that way. I'll see to perform the >>> complete conversion in the next few days. >> >> just a note, as written on IRC earlier, I am sitting on a >> dev_err_probe >> conversion for dw-dsi-rockchip. >> >> I was waiting to see if more cleanups turned up, so didn't sent that >> yet. >> >> Don't want to steal your spotlight though, so not sure if I should >> send >> that or wait for your conversion ;-) > > I see no reasons why should we duplicate some effort. :) If you're > already nearing the file-level conversion to its completion, please > feel free to send it, and we can drop this series. :) Sorry, I wasn't clear enough. When I wrote "we can drop this series", I actually referred to what this series might have turned into, i.e. into my file-level conversion. :)