From: Sridharan S N <quic_sridsn@quicinc.com>
To: Konrad Dybcio <konrad.dybcio@linaro.org>, <agross@kernel.org>,
<andersson@kernel.org>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
<linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2 1/2] arm64: dts: qcom: ipq5332: enable GPIO based LEDs and Buttons
Date: Fri, 9 Jun 2023 16:04:36 +0530 [thread overview]
Message-ID: <0d374348-4127-2c98-dc43-a1a474a2cafd@quicinc.com> (raw)
In-Reply-To: <669d2745-c7fc-dff5-a6e6-c2c55b4428ee@linaro.org>
On 6/6/2023 6:27 PM, Konrad Dybcio wrote:
>
> On 5.06.2023 07:29, Sridharan S N wrote:
>> Add support for wlan-2g LED on GPIO 36 and wps buttons on GPIO 35.
>>
>> Signed-off-by: Sridharan S N <quic_sridsn@quicinc.com>
>> ---
>> Changes in V2:
>> - Used the hypen in node name instead of underscore
>> - Dropped the status property
>>
>> arch/arm64/boot/dts/qcom/ipq5332-mi01.2.dts | 42 +++++++++++++++++++++
>> arch/arm64/boot/dts/qcom/ipq5332-rdp442.dts | 42 +++++++++++++++++++++
>> arch/arm64/boot/dts/qcom/ipq5332-rdp468.dts | 42 +++++++++++++++++++++
>> 3 files changed, 126 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/ipq5332-mi01.2.dts b/arch/arm64/boot/dts/qcom/ipq5332-mi01.2.dts
>> index 3af1d5556950..5bd4ff3ad86b 100644
>> --- a/arch/arm64/boot/dts/qcom/ipq5332-mi01.2.dts
>> +++ b/arch/arm64/boot/dts/qcom/ipq5332-mi01.2.dts
>> @@ -7,6 +7,8 @@
>>
>> /dts-v1/;
>>
>> +#include <dt-bindings/gpio/gpio.h>
>> +#include <dt-bindings/input/input.h>
>> #include "ipq5332.dtsi"
>>
>> / {
>> @@ -20,6 +22,32 @@
>> chosen {
>> stdout-path = "serial0";
>> };
>> +
>> + gpio-keys {
>> + compatible = "gpio-keys";
>> + pinctrl-0 = <&gpio_keys_default>;
>> + pinctrl-names = "default";
>> +
>> + button-wps {
>> + label = "wps";
>> + linux,code = <KEY_WPS_BUTTON>;
>> + gpios = <&tlmm 35 GPIO_ACTIVE_LOW>;
>> + linux,input-type = <1>;
>> + debounce-interval = <60>;
>> + };
>> + };
> All of these changes seem very repetetive.. Are these devboards based
> on a common design? Maybe ipq5332-rdp-common.dtsi would be beneficial
> here?
Will move all the common nodes to common dtsi in the next patch
> Thanks,
Sridharan
> +
> + leds {
> + compatible = "gpio-leds";
> + pinctrl-0 = <&gpio_leds_default>;
> + pinctrl-names = "default";
> +
> + led-0 {
> + gpios = <&tlmm 36 GPIO_ACTIVE_HIGH>;
> + linux,default-trigger = "phy0tx";
> + default-state = "off";
> + };
> + };
> };
>
> &blsp1_uart0 {
> @@ -57,6 +85,20 @@
> /* PINCTRL */
>
> &tlmm {
> + gpio_keys_default: gpio-keys-default-state {
> + pins = "gpio35";
> + function = "gpio";
> + drive-strength = <8>;
> + bias-pull-up;
> + };
> +
> + gpio_leds_default: gpio-leds-default-state {
> + pins = "gpio36";
> + function = "gpio";
> + drive-strength = <8>;
> + bias-pull-down;
> + };
> +
> i2c_1_pins: i2c-1-state {
> pins = "gpio29", "gpio30";
> function = "blsp1_i2c0";
> diff --git a/arch/arm64/boot/dts/qcom/ipq5332-rdp442.dts b/arch/arm64/boot/dts/qcom/ipq5332-rdp442.dts
> index bcf3b31c20e3..36cbebb75c48 100644
> --- a/arch/arm64/boot/dts/qcom/ipq5332-rdp442.dts
> +++ b/arch/arm64/boot/dts/qcom/ipq5332-rdp442.dts
> @@ -7,6 +7,8 @@
>
> /dts-v1/;
>
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/input/input.h>
> #include "ipq5332.dtsi"
>
> / {
> @@ -20,6 +22,32 @@
> chosen {
> stdout-path = "serial0";
> };
> +
> + gpio-keys {
> + compatible = "gpio-keys";
> + pinctrl-0 = <&gpio_keys_default>;
> + pinctrl-names = "default";
> +
> + button-wps {
> + label = "wps";
> + linux,code = <KEY_WPS_BUTTON>;
> + gpios = <&tlmm 35 GPIO_ACTIVE_LOW>;
> + linux,input-type = <1>;
> + debounce-interval = <60>;
> + };
> + };
> +
> + leds {
> + compatible = "gpio-leds";
> + pinctrl-0 = <&gpio_leds_default>;
> + pinctrl-names = "default";
> +
> + led-0 {
> + gpios = <&tlmm 36 GPIO_ACTIVE_HIGH>;
> + linux,default-trigger = "phy0tx";
> + default-state = "off";
> + };
> + };
> };
>
> &blsp1_uart0 {
> @@ -71,6 +99,20 @@
> /* PINCTRL */
>
> &tlmm {
> + gpio_keys_default: gpio-keys-default-state {
> + pins = "gpio35";
> + function = "gpio";
> + drive-strength = <8>;
> + bias-pull-up;
> + };
> +
> + gpio_leds_default: gpio-leds-default-state {
> + pins = "gpio36";
> + function = "gpio";
> + drive-strength = <8>;
> + bias-pull-down;
> + };
> +
> i2c_1_pins: i2c-1-state {
> pins = "gpio29", "gpio30";
> function = "blsp1_i2c0";
> diff --git a/arch/arm64/boot/dts/qcom/ipq5332-rdp468.dts b/arch/arm64/boot/dts/qcom/ipq5332-rdp468.dts
> index 3b6a5cb8bf07..2d27f48f00c0 100644
> --- a/arch/arm64/boot/dts/qcom/ipq5332-rdp468.dts
> +++ b/arch/arm64/boot/dts/qcom/ipq5332-rdp468.dts
> @@ -7,6 +7,8 @@
>
> /dts-v1/;
>
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/input/input.h>
> #include "ipq5332.dtsi"
>
> / {
> @@ -20,6 +22,32 @@
> chosen {
> stdout-path = "serial0";
> };
> +
> + gpio-keys {
> + compatible = "gpio-keys";
> + pinctrl-0 = <&gpio_keys_default>;
> + pinctrl-names = "default";
> +
> + button-wps {
> + label = "wps";
> + linux,code = <KEY_WPS_BUTTON>;
> + gpios = <&tlmm 35 GPIO_ACTIVE_LOW>;
> + linux,input-type = <1>;
> + debounce-interval = <60>;
> + };
> + };
> +
> + leds {
> + compatible = "gpio-leds";
> + pinctrl-0 = <&gpio_leds_default>;
> + pinctrl-names = "default";
> +
> + led-0 {
> + gpios = <&tlmm 36 GPIO_ACTIVE_HIGH>;
> + linux,default-trigger = "phy0tx";
> + default-state = "off";
> + };
> + };
> };
>
> &blsp1_uart0 {
> @@ -64,6 +92,20 @@
> /* PINCTRL */
>
> &tlmm {
> + gpio_keys_default: gpio-keys-default-state {
> + pins = "gpio35";
> + function = "gpio";
> + drive-strength = <8>;
> + bias-pull-up;
> + };
> +
> + gpio_leds_default: gpio-leds-default-state {
> + pins = "gpio36";
> + function = "gpio";
> + drive-strength = <8>;
> + bias-pull-down;
> + };
> +
> sdc_default_state: sdc-default-state {
> clk-pins {
> pins = "gpio13";
next prev parent reply other threads:[~2023-06-09 10:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-05 5:29 [PATCH V2 0/2] Add support for GPIO based leds and buttons Sridharan S N
2023-06-05 5:29 ` [PATCH V2 1/2] arm64: dts: qcom: ipq5332: enable GPIO based LEDs and Buttons Sridharan S N
2023-06-06 12:57 ` Konrad Dybcio
2023-06-09 10:34 ` Sridharan S N [this message]
2023-06-05 5:29 ` [PATCH V2 2/2] arm64: dts: qcom: ipq9574: enable GPIO based LEDs Sridharan S N
2023-06-06 12:56 ` [PATCH V2 0/2] Add support for GPIO based leds and buttons Konrad Dybcio
2023-06-15 14:53 [PATCH V2 0/2] Add support for GPIO based leds and buttons on IPQ5332/9574 devices Sridharan S N
2023-06-15 14:53 ` [PATCH V2 1/2] arm64: dts: qcom: ipq5332: enable GPIO based LEDs and Buttons Sridharan S N
2023-06-15 14:58 ` Konrad Dybcio
2023-06-16 4:42 ` Sridharan S N
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d374348-4127-2c98-dc43-a1a474a2cafd@quicinc.com \
--to=quic_sridsn@quicinc.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®