From: Dmitry Safonov <dsafonov@virtuozzo.com>
To: Russell King - ARM Linux <linux@armlinux.org.uk>
Cc: <linux-kernel@vger.kernel.org>, <0x7f454c46@gmail.com>,
Kevin Brodsky <kevin.brodsky@arm.com>,
Christopher Covington <cov@codeaurora.org>,
"Andy Lutomirski" <luto@amacapital.net>,
Oleg Nesterov <oleg@redhat.com>,
"Will Deacon" <will.deacon@arm.com>,
<linux-arm-kernel@lists.infradead.org>, <linux-mm@kvack.org>,
Cyrill Gorcunov <gorcunov@openvz.org>,
Pavel Emelyanov <xemul@virtuozzo.com>
Subject: Re: [PATCH] arm/vdso: introduce vdso_mremap hook
Date: Mon, 7 Nov 2016 21:36:48 +0300 [thread overview]
Message-ID: <0d3a03e0-43ad-1e6f-a065-17e5bfdd92f4@virtuozzo.com> (raw)
In-Reply-To: <20161107182734.GL1041@n2100.armlinux.org.uk>
On 11/07/2016 09:27 PM, Russell King - ARM Linux wrote:
> On Tue, Nov 01, 2016 at 08:22:14PM +0300, Dmitry Safonov wrote:
>> diff --git a/arch/arm/kernel/vdso.c b/arch/arm/kernel/vdso.c
>> index 53cf86cf2d1a..d1001f87c2f6 100644
>> --- a/arch/arm/kernel/vdso.c
>> +++ b/arch/arm/kernel/vdso.c
>> @@ -54,8 +54,11 @@ static const struct vm_special_mapping vdso_data_mapping = {
>> .pages = &vdso_data_page,
>> };
>>
>> +static int vdso_mremap(const struct vm_special_mapping *sm,
>> + struct vm_area_struct *new_vma);
>
> I'd much rather avoid this forward declaration. Is there any reason the
> function body can't be here?
>
Well, I didn't want it to be in the middle of static file variables -
those looks nice at this moment just on top of the file.
No other than that.
--
Dmitry
prev parent reply other threads:[~2016-11-07 18:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-01 17:22 Dmitry Safonov
2016-11-07 17:00 ` Christopher Covington
2016-11-07 17:16 ` Dmitry Safonov
2016-11-07 18:08 ` Christopher Covington
2016-11-07 18:13 ` Dmitry Safonov
2016-11-07 18:27 ` Russell King - ARM Linux
2016-11-07 18:36 ` Dmitry Safonov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d3a03e0-43ad-1e6f-a065-17e5bfdd92f4@virtuozzo.com \
--to=dsafonov@virtuozzo.com \
--cc=0x7f454c46@gmail.com \
--cc=cov@codeaurora.org \
--cc=gorcunov@openvz.org \
--cc=kevin.brodsky@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@armlinux.org.uk \
--cc=luto@amacapital.net \
--cc=oleg@redhat.com \
--cc=will.deacon@arm.com \
--cc=xemul@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®