From: Andrew Lunn <andrew@lunn.ch>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: Oleksij Rempel <o.rempel@pengutronix.de>,
Byungho An <bh74.an@samsung.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2 1/1] net: sxgbe: rework EEE handling based on PHY negotiation
Date: Fri, 7 Feb 2025 14:19:31 +0100 [thread overview]
Message-ID: <0d3ba7a5-0e24-4cb5-be52-74a7096a11eb@lunn.ch> (raw)
In-Reply-To: <Z6X0WsUaRw-P-QVt@shell.armlinux.org.uk>
> ... and given this, I ask again: should there be a generic
> software-timer EEE implementation so we're not having to patch multiple
> drivers for the same bug(s).
Probably there should be. But given how little resources we have, i'm
not sure it will ever get done.
Is there anything special in the stmmac code? Workarounds for stmmac
peculiarities? Could it be pulled out? Given you have looked at it,
and fixed it up, it seems like the obvious candidate for code
donation.
Maybe we need to ask the next developer who submits a MAC driver with
a software-timer EEE implementation to build the library?
Andrew
prev parent reply other threads:[~2025-02-07 13:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-07 10:56 Oleksij Rempel
2025-02-07 11:54 ` Russell King (Oracle)
2025-02-07 13:19 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d3ba7a5-0e24-4cb5-be52-74a7096a11eb@lunn.ch \
--to=andrew@lunn.ch \
--cc=bh74.an@samsung.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®