mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Klaus Kudielka <klaus.kudielka@gmail.com>
To: Stanley Chang <stanley_chang@realtek.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Mathias Nyman <mathias.nyman@intel.com>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] usb: xhci: plat: remove error log for failure to get usb-phy
Date: Wed, 10 May 2023 19:39:41 +0200	[thread overview]
Message-ID: <0d3c3938dbd255e21f40884408076fd24222211a.camel@gmail.com> (raw)
In-Reply-To: <20230510075129.28047-1-stanley_chang@realtek.com>

On Wed, 2023-05-10 at 15:51 +0800, Stanley Chang wrote:
> Remove this log to avoid non-error conditions.
> If CONFIG_USB_PHY is disabled, the following error message appears:
> [    0.231609] xhci-hcd f10f0000.usb3: xhci_plat_probe get usb3phy fail (ret=-6)
> [    0.239716] xhci-hcd f10f8000.usb3: xhci_plat_probe get usb3phy fail (ret=-6)
> In this case, devm_usb_get_phy_by_phandle is declared static inline
> and returns -ENXIO.
> 
> It is easy to pinpoint the failure to get the usb-phy using the debug
> log in drivers/usb/phy/phy.c. Therefore, it can be removed.
> 
> Signed-off-by: Stanley Chang <stanley_chang@realtek.com>

Thanks, the false positives are now gone for those without CONFIG_USB_PHY.

Tested-by: Klaus Kudielka <klaus.kudielka@gmail.com>


  reply	other threads:[~2023-05-10 17:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-10  7:51 Stanley Chang
2023-05-10 17:39 ` Klaus Kudielka [this message]
2023-05-23 12:41 ` Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0d3c3938dbd255e21f40884408076fd24222211a.camel@gmail.com \
    --to=klaus.kudielka@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    --cc=stanley_chang@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®