From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A1D0C32771 for ; Fri, 19 Aug 2022 09:01:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348057AbiHSJB4 (ORCPT ); Fri, 19 Aug 2022 05:01:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55972 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346512AbiHSJBx (ORCPT ); Fri, 19 Aug 2022 05:01:53 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A50DF14FB for ; Fri, 19 Aug 2022 02:01:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1660899711; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CrT3slIrGR+Wi5eJUyxjf9Z5bWJXC3nzxIbxu7wbVnw=; b=FFHrppgyuXWaI3pRrnQVrMRNPRZcQOUZvAeK0oKWzP3d0hpkxnwA0+wjGrafLWOiVdmYFp dbGUaDt/L+RZ02Lspv+lvyQA5t+3ybdPjsPRIVTD4RWtvCcmOhQaLqgLQhYLx1Ss5PHGUp iRvelkactlC6N6GjEkMr1i2sqlTttxI= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-546-8xTRXvImOdqOWp7Hz6btiQ-1; Fri, 19 Aug 2022 05:01:47 -0400 X-MC-Unique: 8xTRXvImOdqOWp7Hz6btiQ-1 Received: by mail-ej1-f69.google.com with SMTP id qb27-20020a1709077e9b00b0073160a55fd7so1290051ejc.17 for ; Fri, 19 Aug 2022 02:01:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=CrT3slIrGR+Wi5eJUyxjf9Z5bWJXC3nzxIbxu7wbVnw=; b=YqgJjbAZubOnjwJ+ANKDf1cmYh7vgNlphLD2LMtP3Oqm7iYeRge3dfO52yve6HWFuh Fyvg47mw73FF4RznflUgR40LKYsecO389KAMstu0Osk2z+LbljnA5eeYe6u1BQDirwUQ c3QPPI4hOu+GzPSMLqUzdx+DQNxSdYlDiAKfiz3EAr27huqGMlUf60WC3+bDKWYA2ZZq NgljOAT75ocnLZ03IYWgWXJJgqhLHeLzX1PAtwd0e89rnxMOxYm2dshtrPxLLECWFB33 oy4PlO6J9iqHWpsi1fIJI819TTA9bw/g0fpLOWjKIj0Z1teee1elOLdVDY8iopKWoo8B KrJg== X-Gm-Message-State: ACgBeo3l0WE2epCWfqlTSQxX3UZ0u5rc+R3HT4q1LesN77nbsJgWw4vu DbpxkSOArW2eSEAt5YPbu4zP5aQIt7AO0Bba+dqltLsNejAD9e1ixPEIrwW0vPKazU3TzMN9pgR XPg+8XgQAvthjCEOGrztQZgVx X-Received: by 2002:a17:907:9710:b0:731:67b1:dc3b with SMTP id jg16-20020a170907971000b0073167b1dc3bmr4297293ejc.709.1660899706382; Fri, 19 Aug 2022 02:01:46 -0700 (PDT) X-Google-Smtp-Source: AA6agR6CKxALS09Z3BsqpKyFa/xJwSbl1/25PfL3hUiAA8X/A0+o+81dmJop4GIVtogOnofX76HMKg== X-Received: by 2002:a17:907:9710:b0:731:67b1:dc3b with SMTP id jg16-20020a170907971000b0073167b1dc3bmr4297279ejc.709.1660899706110; Fri, 19 Aug 2022 02:01:46 -0700 (PDT) Received: from ?IPV6:2001:1c00:c1e:bf00:d69d:5353:dba5:ee81? (2001-1c00-0c1e-bf00-d69d-5353-dba5-ee81.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:d69d:5353:dba5:ee81]) by smtp.gmail.com with ESMTPSA id ss28-20020a170907c01c00b00730a18a8b68sm2014654ejc.130.2022.08.19.02.01.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Aug 2022 02:01:45 -0700 (PDT) Message-ID: <0d44fb03-0481-2f0d-eeb5-63cbddeffc62@redhat.com> Date: Fri, 19 Aug 2022 11:01:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH 01/14] vboxsf: move from strlcpy with unused retval to strscpy Content-Language: en-US To: Wolfram Sang , linux-kernel@vger.kernel.org Cc: linux-fsdevel@vger.kernel.org References: <20220818210123.7637-1-wsa+renesas@sang-engineering.com> From: Hans de Goede In-Reply-To: <20220818210123.7637-1-wsa+renesas@sang-engineering.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 8/18/22 23:01, Wolfram Sang wrote: > Follow the advice of the below link and prefer 'strscpy' in this > subsystem. Conversion is 1:1 because the return value is not used. > Generated by a coccinelle script. > > Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/ > Signed-off-by: Wolfram Sang Note you send this one twice. Since I'm not sure which one will end up getting merged, I'm going to just reply to both... Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > fs/vboxsf/super.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/vboxsf/super.c b/fs/vboxsf/super.c > index d2f6df69f611..1fb8f4df60cb 100644 > --- a/fs/vboxsf/super.c > +++ b/fs/vboxsf/super.c > @@ -176,7 +176,7 @@ static int vboxsf_fill_super(struct super_block *sb, struct fs_context *fc) > } > folder_name->size = size; > folder_name->length = size - 1; > - strlcpy(folder_name->string.utf8, fc->source, size); > + strscpy(folder_name->string.utf8, fc->source, size); > err = vboxsf_map_folder(folder_name, &sbi->root); > kfree(folder_name); > if (err) {