From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8318CA0ECF for ; Tue, 12 Sep 2023 11:08:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234689AbjILLI0 (ORCPT ); Tue, 12 Sep 2023 07:08:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36304 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234463AbjILLHS (ORCPT ); Tue, 12 Sep 2023 07:07:18 -0400 Received: from out30-97.freemail.mail.aliyun.com (out30-97.freemail.mail.aliyun.com [115.124.30.97]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 187921708; Tue, 12 Sep 2023 04:07:12 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R511e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045168;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=8;SR=0;TI=SMTPD_---0VrwdjfR_1694516829; Received: from 30.97.48.71(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0VrwdjfR_1694516829) by smtp.aliyun-inc.com; Tue, 12 Sep 2023 19:07:10 +0800 Message-ID: <0d45564d-bceb-2fb5-67e4-50c6139de992@linux.alibaba.com> Date: Tue, 12 Sep 2023 19:07:16 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [RFT PATCH 3/3] gpio: eic-sprd: use devm_platform_ioremap_resource() To: Bartosz Golaszewski Cc: Linus Walleij , Andy Shevchenko , Orson Zhai , Chunyan Zhang , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski References: <20230912094519.22769-1-brgl@bgdev.pl> <20230912094519.22769-3-brgl@bgdev.pl> <80d7b0ad-026d-6ba9-7c1f-7f0c3b5af588@linux.alibaba.com> From: Baolin Wang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/12/2023 6:09 PM, Bartosz Golaszewski wrote: > On Tue, Sep 12, 2023 at 12:05 PM Baolin Wang > wrote: >> >> >> >> On 9/12/2023 5:45 PM, Bartosz Golaszewski wrote: >>> From: Bartosz Golaszewski >>> >>> Make two calls into one by using devm_platform_ioremap_resource(). >>> >>> Signed-off-by: Bartosz Golaszewski >> >> Please don't do this. See the previous commit: >> 4ed7d7dd4890bb8120a3e77c16191a695fdfcc5a ("Revert "gpio: eic-sprd: Use >> devm_platform_ioremap_resource()"") >> > > Ah, I see. Dropped. Could use a comment describing the problem though. Yes, I think so, in case someone does the same thing in the future. >>> --- >>> drivers/gpio/gpio-eic-sprd.c | 7 +------ >>> 1 file changed, 1 insertion(+), 6 deletions(-) >>> >>> diff --git a/drivers/gpio/gpio-eic-sprd.c b/drivers/gpio/gpio-eic-sprd.c >>> index be7f2fa5aa7b..1e548e4e4cb8 100644 >>> --- a/drivers/gpio/gpio-eic-sprd.c >>> +++ b/drivers/gpio/gpio-eic-sprd.c >>> @@ -594,7 +594,6 @@ static int sprd_eic_probe(struct platform_device *pdev) >>> struct device *dev = &pdev->dev; >>> struct gpio_irq_chip *irq; >>> struct sprd_eic *sprd_eic; >>> - struct resource *res; >>> int ret, i; >>> >>> pdata = of_device_get_match_data(dev); >>> @@ -621,11 +620,7 @@ static int sprd_eic_probe(struct platform_device *pdev) >>> * have one bank EIC, thus base[1] and base[2] can be >>> * optional. >>> */ >>> - res = platform_get_resource(pdev, IORESOURCE_MEM, i); >>> - if (!res) >>> - break; >>> - >>> - sprd_eic->base[i] = devm_ioremap_resource(dev, res); >>> + sprd_eic->base[i] = devm_platform_ioremap_resource(pdev, i); >>> if (IS_ERR(sprd_eic->base[i])) >>> return PTR_ERR(sprd_eic->base[i]); >>> }