From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Sergey Lisov <sleirsgoevy@gmail.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Jaehoon Chung <jh80.chung@samsung.com>
Cc: linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 3/3] mmc: dw_mmc: add an option to force 32-bit access to 64-bit FIFO
Date: Sun, 12 Mar 2023 18:16:52 +0100 [thread overview]
Message-ID: <0d46a128-bd65-90cf-6c35-00f5364b7ae0@linaro.org> (raw)
In-Reply-To: <1678640497.9030156-3-sleirsgoevy@gmail.com>
On 12/03/2023 17:59, Sergey Lisov wrote:
> Some Samsung Exynos boards using the arm64 architecture have DW MMC
> controllers configured for a 32-bit data bus but a 64-bit FIFO. On these
> systems the 64-bit FIFO registers must be accessed in two 32-bit halves.
> ---
> drivers/mmc/host/dw_mmc-exynos.c | 41 ++++++++++-
> drivers/mmc/host/dw_mmc.c | 122 ++++++++++++++++++++++++++++++-
> drivers/mmc/host/dw_mmc.h | 2 +
> 3 files changed, 162 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c
> index 9f20ac524..768774f22 100644
> --- a/drivers/mmc/host/dw_mmc-exynos.c
> +++ b/drivers/mmc/host/dw_mmc-exynos.c
> @@ -28,6 +28,8 @@ enum dw_mci_exynos_type {
> DW_MCI_TYPE_EXYNOS5420_SMU,
> DW_MCI_TYPE_EXYNOS7,
> DW_MCI_TYPE_EXYNOS7_SMU,
> + DW_MCI_TYPE_EXYNOS78XX,
> + DW_MCI_TYPE_EXYNOS78XX_SMU,
> DW_MCI_TYPE_ARTPEC8,
> };
>
> @@ -70,6 +72,12 @@ static struct dw_mci_exynos_compatible {
> }, {
> .compatible = "samsung,exynos7-dw-mshc-smu",
> .ctrl_type = DW_MCI_TYPE_EXYNOS7_SMU,
> + }, {
> + .compatible = "samsung,exynos78xx-dw-mshc",
> + .ctrl_type = DW_MCI_TYPE_EXYNOS78XX,
> + }, {
> + .compatible = "samsung,exynos78xx-dw-mshc-smu",
> + .ctrl_type = DW_MCI_TYPE_EXYNOS78XX_SMU,
> }, {
> .compatible = "axis,artpec8-dw-mshc",
> .ctrl_type = DW_MCI_TYPE_ARTPEC8,
> @@ -86,6 +94,8 @@ static inline u8 dw_mci_exynos_get_ciu_div(struct dw_mci *host)
> return EXYNOS4210_FIXED_CIU_CLK_DIV;
> else if (priv->ctrl_type == DW_MCI_TYPE_EXYNOS7 ||
> priv->ctrl_type == DW_MCI_TYPE_EXYNOS7_SMU ||
> + priv->ctrl_type == DW_MCI_TYPE_EXYNOS78XX ||
> + priv->ctrl_type == DW_MCI_TYPE_EXYNOS78XX_SMU ||
> priv->ctrl_type == DW_MCI_TYPE_ARTPEC8)
This is getting look like a spaghetti code. I think this needs
quirks/flags, except of types. Or this ifs all over should be made a bit
smarter as all of these are pretty close to compatible.
Best regards,
Krzysztof
prev parent reply other threads:[~2023-03-12 17:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-12 16:59 [PATCH v4 0/3] mmc: dw_mmc: fix DW MMC cores with 32-bit bus on 64-bit Linux systems Sergey Lisov
2023-03-12 16:59 ` [PATCH v4 1/3] dt-bindings: exynos-dw-mshc-common: add exynos78xx variants Sergey Lisov
2023-03-12 17:09 ` Krzysztof Kozlowski
2023-03-12 16:59 ` [PATCH v4 2/3] arm64: dts: exynos: fix wrong mmc compatible in exynos7885.dtsi Sergey Lisov
2023-03-12 17:10 ` Krzysztof Kozlowski
2023-03-12 16:59 ` [PATCH v4 3/3] mmc: dw_mmc: add an option to force 32-bit access to 64-bit FIFO Sergey Lisov
2023-03-12 17:16 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d46a128-bd65-90cf-6c35-00f5364b7ae0@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=jh80.chung@samsung.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sleirsgoevy@gmail.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®