From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Jens Axboe <axboe@kernel.dk>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
<linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Douglas Gilbert <dgilbert@interlog.com>
Subject: Re: [PATCH] scsi: sr: fix oob access in get_capabilities
Date: Mon, 20 Mar 2017 14:00:17 +0800 [thread overview]
Message-ID: <0d4c496b-c435-b622-58f8-25bd4490186a@huawei.com> (raw)
In-Reply-To: <yq160j7lbx1.fsf@oracle.com>
On 2017/3/18 7:29, Martin K. Petersen wrote:
> Kefeng Wang <wangkefeng.wang@huawei.com> writes:
>
> Kefeng,
>
>> root@localhost ~]# sg_modes -p 0x2a /dev/sr0
>> QEMU QEMU DVD-ROM 0.15 peripheral_type: cd/dvd [0x5]
>> Mode parameter header from MODE SENSE(10):
>> Invalid block descriptor length=512, ignore
>> Mode data length=36, medium type=0x70, specific param=0x00, longlba=0
>> Block descriptor length=0
>>>> MM capabilities and mechanical status (obsolete), page_control: current
>> 00 2a 12 00 00 71 60 29 00 02 c2 00 02 02 00 02 c2
>> 10 00 00 00 00
>> Unexpectedly received extra mode page responses, ignore
>
> That looks pretty broken.
>
> Could you try the following patch?
The issue still exists, the patch return zero in scsi_mode_sense(), but zero means
SAM_STAT_GOOD in scsi_status_is_good(), so n will be still bigger than 512;
Thanks,
next prev parent reply other threads:[~2017-03-20 6:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-03 10:17 Kefeng Wang
2017-03-06 7:26 ` Kefeng Wang
2017-03-16 0:07 ` Martin K. Petersen
2017-03-16 5:21 ` Kefeng Wang
2017-03-17 23:29 ` Martin K. Petersen
2017-03-20 6:00 ` Kefeng Wang [this message]
2017-03-20 14:29 ` Martin K. Petersen
2017-03-21 2:20 ` Kefeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d4c496b-c435-b622-58f8-25bd4490186a@huawei.com \
--to=wangkefeng.wang@huawei.com \
--cc=axboe@kernel.dk \
--cc=dgilbert@interlog.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®