From: Florian Fainelli <f.fainelli@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>, Vladimir Oltean <olteanv@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v2] net: dsa: tag_rtl4_a: Bump min packet size
Date: Mon, 30 Oct 2023 20:37:51 -0700 [thread overview]
Message-ID: <0d4cd98f-6f5f-4fc3-b55d-c1351054b667@gmail.com> (raw)
In-Reply-To: <494a8bb7-7ca1-40bd-b3a7-babeadfd88a0@lunn.ch>
On 10/30/2023 5:37 PM, Andrew Lunn wrote:
> On Tue, Oct 31, 2023 at 01:09:06AM +0200, Vladimir Oltean wrote:
>> On Mon, Oct 30, 2023 at 11:57:33PM +0100, Linus Walleij wrote:
>>> This of course make no sense, since the padding function should do nothing
>>> when the packet is bigger than 60 bytes.
>>
>> Indeed, this of course makes no sense. Ping doesn't work, or ARP doesn't
>> work? Could you add a static ARP entry for the 192.168.1.137 IP address?
>
> Probably the ARP, since they are short packets and probably need the
> padding.
Does this also mean that there is a general problem with unicast
packets, and that broadcast packets happen to work by accident? Could
you check whether a broadcast ping (ping -b) size sweep is immune to
what you are reporting?
--
Florian
next prev parent reply other threads:[~2023-10-31 3:37 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-30 9:26 Linus Walleij
2023-10-30 14:16 ` Vladimir Oltean
2023-10-30 14:37 ` Linus Walleij
2023-10-30 15:23 ` Vladimir Oltean
2023-10-30 15:30 ` Vladimir Oltean
2023-10-31 21:22 ` Linus Walleij
2023-11-02 10:48 ` Vladimir Oltean
2023-10-30 21:50 ` Linus Walleij
2023-10-30 22:20 ` Vladimir Oltean
2023-10-30 22:57 ` Linus Walleij
2023-10-30 23:09 ` Vladimir Oltean
2023-10-30 23:11 ` Linus Walleij
2023-10-31 0:37 ` Andrew Lunn
2023-10-31 3:37 ` Florian Fainelli [this message]
2023-10-31 14:06 ` Linus Walleij
2023-10-31 16:23 ` Florian Fainelli
2023-10-30 23:33 ` Vladimir Oltean
2023-10-31 14:16 ` Linus Walleij
2023-10-31 16:34 ` Vladimir Oltean
2023-10-31 19:02 ` Linus Walleij
2023-11-02 12:32 ` Vladimir Oltean
2023-10-31 19:18 ` Luiz Angelo Daros de Luca
2023-10-31 19:27 ` Linus Walleij
2023-11-01 12:35 ` Luiz Angelo Daros de Luca
2023-11-01 20:26 ` Linus Walleij
2023-11-02 10:04 ` Vladimir Oltean
2023-11-02 10:45 ` Vladimir Oltean
2023-11-03 17:05 ` Luiz Angelo Daros de Luca
2023-12-30 5:19 ` Luiz Angelo Daros de Luca
2023-12-30 12:28 ` Linus Walleij
2023-12-30 23:56 ` Luiz Angelo Daros de Luca
2023-11-02 10:31 ` Vladimir Oltean
2023-11-03 17:13 ` Luiz Angelo Daros de Luca
2023-10-31 22:44 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d4cd98f-6f5f-4fc3-b55d-c1351054b667@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®