From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Detlev Casanova <detlev.casanova@collabora.com>
Cc: linux-kernel@vger.kernel.org,
Ulf Hansson <ulf.hansson@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jisheng Zhang <jszhang@kernel.org>,
linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
kernel@collabora.com
Subject: Re: [PATCH 1/1] dt-bindings: mmc: Add support for rk3576 eMMC
Date: Wed, 4 Sep 2024 15:02:40 +0200 [thread overview]
Message-ID: <0d4d40cc-9885-4933-a6d6-933e4705a68c@linaro.org> (raw)
In-Reply-To: <6077666.lOV4Wx5bFT@trenzalore>
On 04/09/2024 14:56, Detlev Casanova wrote:
> On Wednesday, 4 September 2024 02:00:27 EDT Krzysztof Kozlowski wrote:
>> On Tue, Sep 03, 2024 at 10:51:36AM -0400, Detlev Casanova wrote:
>>> The device is compatible with rk3588, so add an entry for the 2
>>> compatibles together.
>>>
>>> The rk3576 device has a power-domain that needs to be on for the eMMC to
>>> be used. Add it as a requirement.
>>>
>>> Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com>
>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>> NAK
>>
>> Drop fake tag. It is impossible to receive a review-tag from me on THE
>> FIRST version. I almost never provide reviews out of mailing lists.
>>
>> And since there is no changelog here and no versioning, this obviously
>> is not v2 or v3.
>
> That's because the patch was from another patchset[0]. Only this patch needed
> a rebase on the mmc tree, so I sent it separately. You reviewed it here [1].
>
> [0]: https://lore.kernel.org/all/010201919989e3de-60b56341-85e0-4869-89d1-362407c4f2ec-000000@eu-west-1.amazonses.com/
> [1]: https://lore.kernel.org/all/m5ua5jnbv4u36glqt2qrps35asuqfycxedgjrfhodi5bvs2r2h@xvy4qxt4gx74/
Hm, ok, changelog should explained this and the versioning should
continue, including history of this patch.
>
>>> ---
>>>
>>> .../bindings/mmc/snps,dwcmshc-sdhci.yaml | 34 ++++++++++++++-----
>>> 1 file changed, 26 insertions(+), 8 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml
>>> b/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml index
>>> 80d50178d2e3..84a667f0c526 100644
>>> --- a/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml
>>> +++ b/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml
>>>
>>> @@ -12,14 +12,18 @@ maintainers:
>>> properties:
>>> compatible:
>>> - enum:
>>> - - rockchip,rk3568-dwcmshc
>>> - - rockchip,rk3588-dwcmshc
>>> - - snps,dwcmshc-sdhci
>>> - - sophgo,cv1800b-dwcmshc
>>> - - sophgo,sg2002-dwcmshc
>>> - - sophgo,sg2042-dwcmshc
>>> - - thead,th1520-dwcmshc
>>> + oneOf:
>>> + - items:
>>> + - const: rockchip,rk3576-dwcmshc
>>> + - const: rockchip,rk3588-dwcmshc
>>> + - enum:
>>> + - rockchip,rk3568-dwcmshc
>>> + - rockchip,rk3588-dwcmshc
>>> + - snps,dwcmshc-sdhci
>>> + - sophgo,cv1800b-dwcmshc
>>> + - sophgo,sg2002-dwcmshc
>>> + - sophgo,sg2042-dwcmshc
>>> + - thead,th1520-dwcmshc
>>>
>>> reg:
>>> maxItems: 1
>>>
>>> @@ -35,6 +39,9 @@ properties:
>>> minItems: 1
>>> maxItems: 5
>>>
>>> + power-domains:
>>> + maxItems: 1
>>> +
>>>
>>> resets:
>>> maxItems: 5
>>>
>>> @@ -97,6 +104,17 @@ allOf:
>>> - const: block
>>> - const: timer
>>>
>>> + - if:
>>> + properties:
>>> + compatible:
>>> + contains:
>>> + const: rockchip,rk3576-dwcmshc
>>> +
>>> + then:
>>> + properties:
>>> + power-domains:
>>> + minItems: 1
>>
>> Why minItems? This does not look right. I don't get what you are trying
>> to say here.
>
> I'm saying that for the rockchip,rk3576-dwcmshc compatible, 1 power-domain
> node has to be set.
The top-level property already says this. You need to disallow it for
other variants (:false).
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-09-04 13:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-03 14:51 [PATCH 0/1] " Detlev Casanova
2024-09-03 14:51 ` [PATCH 1/1] " Detlev Casanova
2024-09-04 6:00 ` Krzysztof Kozlowski
2024-09-04 12:56 ` Detlev Casanova
2024-09-04 13:02 ` Krzysztof Kozlowski [this message]
2024-09-04 14:20 ` Detlev Casanova
2024-09-04 14:25 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d4d40cc-9885-4933-a6d6-933e4705a68c@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=detlev.casanova@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=jszhang@kernel.org \
--cc=kernel@collabora.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=robh@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®