From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=205.220.180.131 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794825412; b=s6SpCkn8iyrlmZThP1giuUO11CbIx/KfObroMa7Zw4RJmF8glBsJqwl1TIUq3UC8b3VV UesveipyQP9mnmCjyBH9adT+08y6mqTlTEhzs5TX8+7T9KZPgvzxIR3fmgeGSxDu1n0VK K2ji59qA5aMCZPYBo3RbAhVQu01S+wD4y80X0PE5TNKj6T9HTVxOv87KFC3xkcnAH5H7h yZ+KdRWpMOIIZ7MJdYjWEF0mIDPNisBPkOFiwj6d5pJmiYm4OWyWIMwdB3at0nozBXHFR 8DNe3YZlDyztNZNo+CYSED8XHOjSkWLyCf6kv0MyJRlupUkACruozd26UfWiLn2Mybw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794825412; h=DMARC-Filter:Received:DKIM-Signature:Received:Received: DKIM-Signature:X-Google-DKIM-Signature:X-Forwarded-Encrypted: X-Gm-Message-State:X-Gm-Gg:X-Received:X-Received:Received:Message-ID: Date:MIME-Version:User-Agent:Subject:To:Cc:References: Content-Language:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:X-Proofpoint-GUID:X-Proofpoint-Spam-Info: X-Proofpoint-Spam-Details-Enc:X-Authority-Analysis: X-Proofpoint-ORIG-GUID:X-Proofpoint-Virus-Version: X-Proofpoint-Spam-Details; bh=MftvhOyh0JpsGoC/uKwPwUiWJJ5nnSYLJzRW3U35/uE=; b=BaXakb6UpCY7Zicub5BflPILIM4Occe+SHP5QrSbt1zIjKb6OtAuw2OiMgJ8O75FumdO e79JltaWdWVl3DU76iAa83c13SE+i2dYpRqJN920HaNn36ziCZdc2XW/GLfBwIWMQJXnr NSo5Ee4TAjiPmga3zEV54m9TcLVkQHSfvrIHPcnoPoKGe/Y+At4xaXY+xHXjlFv4O2+re xRZ8EarsFwxn5oAgs6j0kDvgHmdCoXTDQ092b7HiXUD1S4rwC+EdatLWFW+lu4Ss2t3GB Ok0y8zLBancz4A+/3sXDbMOeq2ElV6NUB8N5FgN3YKQVPVihMRqT0slcDMJgDUSKuLA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=P0Ii6B8d; dkim=pass header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=kv5UWK5g; arc=none smtp.remote-ip=205.220.180.131 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 23933606A885 for ; Mon, 16 Nov 2026 10:36:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 23933606A885 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=P0Ii6B8d; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=kv5UWK5g Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6AGAK1U8881431 for ; Mon, 16 Nov 2026 10:36:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= MftvhOyh0JpsGoC/uKwPwUiWJJ5nnSYLJzRW3U35/uE=; b=P0Ii6B8dvzW1BWVr vF7QyOXiccvKYXQvu4cSlMXbJZhzPqaZml7m4cbtpoemL6floNqwNdb1T778fh/W 1YnBzfTkItJlO5kCDcGjZ6QgRr5tzXKY0yJls/4rMcVpT2qT6kqfh6GcodW8o+np hFLu8yHjNwHCCtWoIe98zmlK29UsOryjtshI8VVlfPJFjXmvcRpM+RAnnVGlue94 4eabt2dbek/AmU7omBipCsHYlQaTfT3PO94hkxHjopSb92UhxqeJKTeiaqVK/F6Q FjH9m9ecQjWqqNOCHE/98xi3eKdLxjd4v8veY0B+v97+KkFzjTYD1eKEqsAmpqFi scT6Rg== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4j0003g1s1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 16 Nov 2026 10:36:51 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-3ae19907a31so3273588a91.0 for ; Mon, 16 Nov 2026 02:36:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1794825410; x=1795430210; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=MftvhOyh0JpsGoC/uKwPwUiWJJ5nnSYLJzRW3U35/uE=; b=kv5UWK5gXjfQeCZc1SoNrluIDPIs55Brc41K8tbEc3bsS74sc+VCuwC/6WrNv8w5MG F8pYRg2fKvo4gRcuTVZ8IKhLk7Uu+HARaITLV03Rdqiuj80016wl63DjeH/odlnL5oqs 2SIk26JgufwxG1noiVsQPEcliDQOvz8Du5FIkTaku3XKE/ATRbc51RSj4YtRf3ga+8Vp JqXvdpcEb/Fz666tCfAkEwOrc3mGbMprRzimElqnURElThv1qKUkcK2kEmAoKrIIGNhq nkQnw1ecZ8IFRJzkqSYMvZlkbpWsAVNtLR+yZTKGaD9O4UreavCY7zBDxIfgCN4RIQtu Vl3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794825410; x=1795430210; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=MftvhOyh0JpsGoC/uKwPwUiWJJ5nnSYLJzRW3U35/uE=; b=Dl3nZKi5p+kiGjzsLcDsgwZwlEeyPmTClB8HpovDWOJooQEkDZ9znQYrmCRalJJr8D Xgjc3OmTHmzE7lfqX+sdnJOgP6Uthk4VeibTZBVD1PIox9qdhy2i8NWgJhUzRewQrY0I WZtN908TD12KGEncERAxJidePGv512IjxtwzGMH6aXIYt6SF15XzsF+IpWj+6dCjMse2 TXP4GchxPMLaJp7O4bE60v1c2Nvwbt8tuxVy3aP7IVmWYBR5MIqNlX97MAwYw+yCVukw dD6I0jngMRqltbTHuVqMegm8HA3hzQbsWcFqMgF1iu6edppiylffpJo5x7IeGDoGih+L Kggg== X-Forwarded-Encrypted: i=1; AL+hErG8uMSsoY112U3LRM43nUn0e06uvD+6AK447yFIhmgJge0zQo6xf00Xj2qGkK1vn0lTh40AksAyTGKN57k=@vger.kernel.org X-Gm-Message-State: APuU4Z87CWHDQBzk/0DNfebEbjR69MUso+SLICgoUCH5XNpar2FXCrDr mVPgYwVGWGOgN5t0xzVsLni7/lGa9SAZYcKKsuuZ7VkVCmx2q/trpfiUW6AOF+k3OGb2hEy1NBn 8Rv5XFL4+GeQNY1fODimihu2XJumlDct2hQZervym/DWK8qHyGeKltjCIQ48Qbsd8yJw= X-Gm-Gg: AZFdTZeVAirVCrYIJkuaGzodqiV67B5JjSyxGbAnUJneRTL8fQR4U2eKyRdyXiFyYI4 mf/n2tK2s0oblLY2hEWYPQJbdLL00IF2XdCYeoUblt0XU5201CLjKB2HQIsnHn8A58GQfyDxZ/i N3/d0K/Ap6JfAH+vf82jTmixP9EEIR/OeQEoMkVR5g4VKxKAOkgRWIQV4EMjhUjE9WDy1/utFDe jweXMTTtlG+d0TPO0EQRzBJ2oD9QGFd5DEnVwh9Wo84GgS5JtKq3yjjKkvDipYjSyxyCrpwkU1x K258xlmM842RyiRW1snspTwThb90Ztifpg/cqtzsAuqKNq0Q7zqcQRfj8nH77hrdUy1BiN65y6S NHmiQv3KCELh4DmErpdpNsy8NcjXWgb+nC8K8tyfbyLSk/tv3o5otueM++CBU7RBTX8wnp5u4fj 9L1Uk= X-Received: by 2002:a17:90b:4ec5:b0:3b1:6689:a016 with SMTP id 98e67ed59e1d1-3b1b0b8f9cfmr5958553a91.16.1794825410063; Mon, 16 Nov 2026 02:36:50 -0800 (PST) X-Received: by 2002:a17:90b:4ec5:b0:3b1:6689:a016 with SMTP id 98e67ed59e1d1-3b1b0b8f9cfmr5958521a91.16.1794825409384; Mon, 16 Nov 2026 02:36:49 -0800 (PST) Received: from [10.218.50.86] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ee0f4adcdesm36374645ad.10.2026.11.16.02.36.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Nov 2026 02:36:48 -0800 (PST) Message-ID: <0d4fa5af-e406-4761-aa58-534c3c6a043a@oss.qualcomm.com> Date: Mon, 16 Nov 2026 16:06:42 +0530 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/6] dt-bindings: dma: qcom-gpi: Add QSPI protocol identifier To: Krzysztof Kozlowski Cc: Mark Brown , Vinod Koul , Frank Li , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Gross , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, devicetree@vger.kernel.org References: <20261106-qspi_upstream_series-v1-0-21f43042dd60@oss.qualcomm.com> <20261106-qspi_upstream_series-v1-2-21f43042dd60@oss.qualcomm.com> <20261109-wandering-miraculous-mamba-0cf21a@quoll> <2fc8f7ea-651e-466e-9346-c47e0a38c5bb@oss.qualcomm.com> <20261111-daring-salamander-from-tartarus-4c72bd@quoll> <5b6e4031-4c52-4b67-82c2-0033d13b15d6@kernel.org> Content-Language: en-US From: Jyothi Kumar Seerapu In-Reply-To: <5b6e4031-4c52-4b67-82c2-0033d13b15d6@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: ovQhc9lxC5q7JsayfmOPVAdmcY2x_WiQ X-Proofpoint-Spam-Info: AW1haW4tMjYxMTE2MDA0MiBTYWx0ZWRfX/gFn6nbyEUIT wS6Xwl2KApMs/Nn1cv7C6Fibmg+ms4EjbuBCLgxKktSm2mqxTMZLbBpfujQSaZpisX24XGPpv5V MUJXplEhP2oLq6PW4SE3H0xm/qnIxj8= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMTE2MDA0MiBTYWx0ZWRfX+iDEODddl6On 3k6pTUUlF64Py9edv3SpbiDt1Mq6XKuRNnhvmFyp09ToDRgFjkq8G4hQDO29k/btXLzJpwMgc5Q qNnwHJj66F+MG5srH9Bh/h0UuCIZBaaMcTgRE7vDWAuhpchwfmz6XvgVF78cprnP5ua1bIg1uYR wpqh177h7UBGxpcn8ocnnTE8ENKOaJJlBAh8fEbsrsz49Bu4xgkAs8xZ7h5OCorm8v5vlnbKqiQ XrV9l634jnFg1/AnGZORCEVKiZ/+FKKpEKxLgGJQqfJKXHH+hAzk6HUFrjDuZxZH5tE2IcIVfR9 awr046crLd0Y2sh/S62lcnnrdXSJAxZ4dh6hp7qIlouZnLHDUMJ3+ZDxxM+CQi7CF8AvDLODkA9 6nlbrBclNBSHl/6XEa4H/P0GQANnpDAERqzUoXPlT7ktz+Wn+rJ8TLBYPcEM6GKC2v3fpY9WmTe 8uD5Zqo9XMaV5Q/V7Cw== X-Authority-Analysis: v=2.4 cv=Z4N5j3RA c=1 sm=1 tr=0 ts=6afadcc3 cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=zJRp6_cAMcgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=y5txsNG1kXPmV2KDPIwA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-ORIG-GUID: ovQhc9lxC5q7JsayfmOPVAdmcY2x_WiQ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.138,FMLib:17.12.100.49 definitions=2026-11-16_03,2026-11-11_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 clxscore=1015 priorityscore=1501 impostorscore=0 malwarescore=0 bulkscore=0 adultscore=0 lowpriorityscore=0 phishscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2611040001 definitions=main-2611160042 On 11/12/2026 7:27 PM, Krzysztof Kozlowski wrote: > On 12/11/2026 14:47, Jyothi Kumar Seerapu wrote: >> >> >> On 11/11/2026 6:07 PM, Krzysztof Kozlowski wrote: >>> On Mon, Nov 09, 2026 at 08:03:29PM +0530, Jyothi Kumar Seerapu wrote: >>>> >>>> >>>> On 11/9/2026 7:12 PM, Krzysztof Kozlowski wrote: >>>>> On Fri, Nov 06, 2026 at 08:31:20PM +0530, Jyothi Kumar Seerapu wrote: >>>>>> Add QCOM_GPI_QSPI to identify QSPI (Quad SPI) channels in GPI DMA >>>>>> specifiers. Its value, 9, matches the GENI serial engine firmware >>>>>> protocol ID for QSPI. >>>>> >>>>> What is GENI serial engine firmware? How does the Linux rely on it that >>>>> we add bindings for it? >>>> >>>> Hi Krzysztof, >>>> GENI firmware runs on the serial engine’s programmable sequencers and >>>> implements protocols such as SPI and QSPI. Linux configures the engine and >>>> submits transfers to it. >>>> The existing GPI DMA specifier includes a client protocol ID. Linux programs >>>> this ID into the DMA channel and selects the corresponding descriptor >>>> format. QCOM_GPI_QSPI adds the QSPI protocol encoding 9 to that interface. >>>> I will clarify this in the commit description in V2. >>> >>> Does not really answer. I see no reason why GENI firmware needs ABI for >>> Linux. >>> >> This extends the existing GPI DMA binding, not a GENI firmware ABI. > > OK, so it is not ABI for the firmware. Period. Let's stop discussing this. > >> >> The third argument of the DMA specifier in the dmas property selects >> the peripheral protocol. The GPI driver programs this value into the > > Yes, so the third argument can be value of 6 because it has no meaning > for the firmware. > > Again, follow standard DT bindings ABI rules, you don't get an exception. The existing GPI DMA driver and binding uses its third cell to identify the client protocol. The driver takes that value from DT and programs it directly into the channel's SCRATCH_0 protocol field. Its mandatory to maintain protocol ID-9 for QSPI. Other protocol IDs which are not part of upstream are for AFC (6), SPMI (7), HID_QSPI (8). > > Best regards, > Krzysztof