mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jean-Jacques Hiblot <jjhiblot@ti.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: <jacek.anaszewski@gmail.com>, <robh+dt@kernel.org>,
	<mark.rutland@arm.com>, <lee.jones@linaro.org>,
	<daniel.thompson@linaro.org>, <jingoohan1@gmail.com>,
	<dmurphy@ti.com>, <linux-leds@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <dri-devel@lists.freedesktop.org>,
	<tomi.valkeinen@ti.com>
Subject: Re: [PATCH v3 3/4] dt-bindings: backlight: Add led-backlight binding
Date: Fri, 12 Jul 2019 15:57:20 +0200	[thread overview]
Message-ID: <0d513ab5-eeb0-c22c-7ec8-f773e445e5f1@ti.com> (raw)
In-Reply-To: <20190710191314.GC22995@amd>

Pavel,

On 10/07/2019 21:13, Pavel Machek wrote:
> On Wed 2019-07-10 14:39:31, Jean-Jacques Hiblot wrote:
>> Add DT binding for led-backlight.
>>
>> Signed-off-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
>> ---
>>   .../bindings/leds/backlight/led-backlight.txt | 28 +++++++++++++++++++
>>   1 file changed, 28 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/leds/backlight/led-backlight.txt
>>
>> diff --git a/Documentation/devicetree/bindings/leds/backlight/led-backlight.txt b/Documentation/devicetree/bindings/leds/backlight/led-backlight.txt
>> new file mode 100644
>> index 000000000000..0444eec8efe1
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/leds/backlight/led-backlight.txt
>> @@ -0,0 +1,28 @@
>> +led-backlight bindings
>> +
>> +This binding is used to describe a basic backlight device made of
>> LEDs.
> Ok.
>
>> +It can also be used to describe a backlight device controlled by the output of
>> +a LED driver.
> ? The LED driver should better be driving some LEDs...

Well. we are dependent of the board design. If a board designer decided 
to control a backlight with a LED-controller, then we have to deal with it.

In practice there are a lot of LED drivers that actually drive the LEDs 
using PWMs and can be used for this purpose.

JJ

>
>> +Required properties:
>> +  - compatible: "led-backlight"
>> +  - leds: a list of LEDs
>> +
>> +Optional properties:
>> +  - brightness-levels: Array of distinct brightness levels. The levels must be
>> +                       in the range accepted by the underlying LED devices.
>> +                       This is used to translate a backlight brightness level
>> +                       into a LED brightness level. if not provided, the
>> +                       identity mapping is used.
> "If it is not"
> 									Pavel

  reply	other threads:[~2019-07-12 13:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-10 12:39 [PATCH v3 0/4] Add a generic driver for LED-based backlight Jean-Jacques Hiblot
2019-07-10 12:39 ` [PATCH v3 1/4] leds: Add of_led_get() and led_put() Jean-Jacques Hiblot
2019-07-10 19:09   ` Pavel Machek
2019-07-12 13:52     ` Jean-Jacques Hiblot
2019-07-10 12:39 ` [PATCH v3 2/4] leds: Add managed API to get a LED from a device driver Jean-Jacques Hiblot
2019-07-10 19:11   ` Pavel Machek
2019-07-10 12:39 ` [PATCH v3 3/4] dt-bindings: backlight: Add led-backlight binding Jean-Jacques Hiblot
2019-07-10 19:13   ` Pavel Machek
2019-07-12 13:57     ` Jean-Jacques Hiblot [this message]
2019-07-10 12:39 ` [PATCH v3 4/4] backlight: add led-backlight driver Jean-Jacques Hiblot
2019-07-10 19:16   ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0d513ab5-eeb0-c22c-7ec8-f773e445e5f1@ti.com \
    --to=jjhiblot@ti.com \
    --cc=daniel.thompson@linaro.org \
    --cc=dmurphy@ti.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jacek.anaszewski@gmail.com \
    --cc=jingoohan1@gmail.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pavel@ucw.cz \
    --cc=robh+dt@kernel.org \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®