From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E665D2E1F02 for ; Mon, 27 Apr 2026 20:10:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777320641; cv=none; b=pUR8G57MHC2e/d0PZA9r359nMV4LfvVCy4KOQ12Rrt0ffuTmsS9TkjXMPltRHnfdCU7I7KmRCpTLYLzD9Ot2WeceiAMksa+IIl+cUBoqcJq0YBJVpkVJXL40RrqLsqctsqQBN7Pcr+boDDkgHaXFLiBf0mwKVowQu/qi8or3WvA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777320641; c=relaxed/simple; bh=6bJZRk7VRD+zl/zHN+fvBcu+sVeXHeGTH6iGszfGv44=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MzPJvQCEja4hxomZz2szEf+5nDJUtXg0snI1pNUNgs8PKXEY1a9GecfQ5W5x0ZMR5iEMFsUuM1QufKmG4P2QqlHt7seQ28FhBld2+FoTLVFWNokv76D5cLqRGcp20gMCbMiJTRsuS9fe0YXc0MY5jXUYlvJQtdfhqjxXFJiOppY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=P/4jdxx9; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="P/4jdxx9" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777320639; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WtWJa+k+/j6GoRAsuYaJzsipGZCN4xrLFGICBvPF+ns=; b=P/4jdxx9z/sB4nBU4JEX7S5lNn5Fmn0QHVMKE7mqFPuNJ7NhXkSXiw8k7mlNdbiBWoWXFg 3w1DlmluRChW/Hp4YM80mj1ycGIZD8t606QnKwBOYNNU795RzMVR/ELpyzmW5aGISwiuST g1yCL33SdJ08XwP+Vx96LlNbLshZBDA= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-547-dQapKj6vPsSvEsSYxNIWQQ-1; Mon, 27 Apr 2026 16:10:36 -0400 X-MC-Unique: dQapKj6vPsSvEsSYxNIWQQ-1 X-Mimecast-MFC-AGG-ID: dQapKj6vPsSvEsSYxNIWQQ_1777320636 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8eb04352924so1625447585a.1 for ; Mon, 27 Apr 2026 13:10:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777320636; x=1777925436; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WtWJa+k+/j6GoRAsuYaJzsipGZCN4xrLFGICBvPF+ns=; b=SyFgOTj1R3sjApU47gtBsefaIeTR1kqncVVCLp8DduG2mIP0WF0+NMw8xfTHHjjtGb 7g2PLld8iZRWbAspGjJQfk6TOj9tEWttlBAYLvwK4QDe435oYN9W55F3CTnzdAURtgmV Q3KTyQ+gWH0aLPYIGSB1Wsk+XN5PalRa90E7BFUydZx6D9vkDIwsH38zrA+/t7JOsVYs xrXAiAT25aC7gag/jvOhtpdoq6VLjpkPc1DFjqnlUamfbEAs4BpGBpSYEPOyWjsnvrPU DDbkWGwIAZfgHQpA9vWfxOB5MmvsoLrtwLV7fE6SmWGoOanulF4emRpMJikOMasOMIm9 PoPw== X-Forwarded-Encrypted: i=1; AFNElJ/yUyQXNBhocko9E8sEfGWNWCE4a7vyZDwDMVbrOpKTLJUkITDsHnAIbpXcSfotBshBtYUmK9PFzvJM7nk=@vger.kernel.org X-Gm-Message-State: AOJu0YwbDgi10BkcTTA5j+byWahTzGQH430b28z49jYgZxBXxywD912m 03JDXtBK7U6Bhcn7G3qhRkHpmCO2bnvh74X38BSFGyRdaSwi0LYT3q1V27nWJYkwMjhd18hdvha /ouNefbpMqQDx6r9IHp812rVb6Ot9JYtr3CUZPpE0wawTP1P0NTw0EEXQ9Dol3TxFyw== X-Gm-Gg: AeBDiesVg/4SLpLenL5u50783nC0l7FOFaPQRe5f9NpKw0LBxoWH0KCxGLV3ti4G0bA g/O3O6qZJ8A8YUG0FhyoLUAoKjFpbR79o0UFAya015nyTYqkoBss6dx5U1neCs8bKjdNs4gVqrM rgm79LK8ekzd3zSNxi8S8luilpE5m7Nx0NUCVeo8aNeBEUsOyQHJfa/bA75mAsAVI9m5Y+48YAk I8SAfeZRA+Re01Y9gEurszP3vksEsEF41kjFALQtF8CqLSXtEgauL3fcNLFp+wuD2LbNB3Octjy 3fE2PdGtcFp8m0M0l+clGe3p2z04GBmoka3iaMj3/pEZeBYNfotmQeh/WT7jSWtRebOiw9VSl5Y Eit5s+qOm+cMnjkEDxcGGguA+HDFg9UWWDQW1 X-Received: by 2002:a05:620a:25cc:b0:8cf:bcf7:fcf4 with SMTP id af79cd13be357-8f7d78341bamr13559985a.22.1777320635593; Mon, 27 Apr 2026 13:10:35 -0700 (PDT) X-Received: by 2002:a05:620a:25cc:b0:8cf:bcf7:fcf4 with SMTP id af79cd13be357-8f7d78341bamr13555285a.22.1777320634999; Mon, 27 Apr 2026 13:10:34 -0700 (PDT) Received: from [192.168.2.110] ([69.159.169.238]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8f7c51ae6easm28476085a.19.2026.04.27.13.10.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Apr 2026 13:10:34 -0700 (PDT) Message-ID: <0d52f348-5f4c-4480-b854-6b73ca5ae294@redhat.com> Date: Mon, 27 Apr 2026 16:10:23 -0400 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 31/53] selftests/mm: gup_longterm: add setup of HugeTLB pages To: Mike Rapoport , Andrew Morton , David Hildenbrand Cc: Baolin Wang , Barry Song , Dev Jain , Donet Tom , Jason Gunthorpe , John Hubbard , "Liam R. Howlett" , Lance Yang , Leon Romanovsky , Lorenzo Stoakes , Mark Brown , Michal Hocko , Nico Pache , Peter Xu , Ryan Roberts , Sarthak Sharma , Shuah Khan , Suren Baghdasaryan , Vlastimil Babka , Zi Yan , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org References: <20260418105539.1261536-1-rppt@kernel.org> <20260418105539.1261536-32-rppt@kernel.org> Content-Language: en-US, en-CA From: Luiz Capitulino In-Reply-To: <20260418105539.1261536-32-rppt@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2026-04-18 06:55, Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" > > gup_longterm tests skips HugeTLB tests if there are no free huge pages > prepared by a wrapper script. > > Add setup of HugeTLB pages to the test and make sure that the original > settings are restored on the test exit. > > Signed-off-by: Mike Rapoport (Microsoft) > --- > tools/testing/selftests/mm/gup_longterm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/mm/gup_longterm.c b/tools/testing/selftests/mm/gup_longterm.c > index ab4eaf4feb7c..6e1de12bf28c 100644 > --- a/tools/testing/selftests/mm/gup_longterm.c > +++ b/tools/testing/selftests/mm/gup_longterm.c > @@ -510,7 +510,7 @@ int main(int argc, char **argv) > int i; > > pagesize = getpagesize(); > - nr_hugetlbsizes = detect_hugetlb_page_sizes(hugetlbsizes, > + nr_hugetlbsizes = hugetlb_setup(2, hugetlbsizes, > ARRAY_SIZE(hugetlbsizes)); Are we missing a call to hugetlb_save_settings()? If yes, should we do it in hugetlb_setup()? > > ksft_print_header();