From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753695AbdCAXpz (ORCPT ); Wed, 1 Mar 2017 18:45:55 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:36119 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751955AbdCAXpt (ORCPT ); Wed, 1 Mar 2017 18:45:49 -0500 Subject: Re: e1000_netpoll() , BUG: sleeping function called from invalid context To: Thomas Gleixner References: <0f5cc059-3db3-f0ae-77a5-0a0c872e4874@gmail.com> <56df0620-6042-50bb-a929-2e8043369554@gmail.com> <396fbe61-daec-ff59-c9d3-f569ae55129f@gmail.com> Cc: Cong Wang , lkml , "David S. Miller" , "Peter Zijlstra (Intel)" From: Gabriel C Message-ID: <0d57aa09-4bf6-15d8-c398-1e5f160dbf83@gmail.com> Date: Wed, 1 Mar 2017 23:44:22 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01.03.2017 23:38, Thomas Gleixner wrote: > On Wed, 1 Mar 2017, Gabriel C wrote: >> On 01.03.2017 18:13, Thomas Gleixner wrote: >>> On Sat, 18 Feb 2017, Gabriel C wrote: >>>> That got changed in commit 3111912971251 which got into Linus tree during >>>> the 4.10 merge window. So it is in 4.10-rc8. >>>> >>>> Confused. >>> >>> I'm still confused. Gabriel, can you please try to reproduce with 4.10 >>> final? >>> >> >> Sure , do you want plain 4.10.0 or 4.10.1 ? >> >> Btw is possible to rename e1000_netpoll() from e1000e driver >> to e1000e_netpoll() so we know what driver is in use ? > > Grr. yes. That would be definitely helpful. I was staring into the wrong > one of course. > >> My card uses the e1000e driver.. > > Does the patch below fix it? I'll test you patch in a bit and let you know. > > Thanks, > > tglx > > 8<-------------- > > --- a/drivers/net/ethernet/intel/e1000e/netdev.c > +++ b/drivers/net/ethernet/intel/e1000e/netdev.c > @@ -6716,19 +6716,19 @@ static irqreturn_t e1000_intr_msix(int _ > > vector = 0; > msix_irq = adapter->msix_entries[vector].vector; > - disable_irq(msix_irq); > + disable_hardirq(msix_irq); > e1000_intr_msix_rx(msix_irq, netdev); > enable_irq(msix_irq); > > vector++; > msix_irq = adapter->msix_entries[vector].vector; > - disable_irq(msix_irq); > + disable_hardirq(msix_irq); > e1000_intr_msix_tx(msix_irq, netdev); > enable_irq(msix_irq); > > vector++; > msix_irq = adapter->msix_entries[vector].vector; > - disable_irq(msix_irq); > + disable_hardirq(msix_irq); > e1000_msix_other(msix_irq, netdev); > enable_irq(msix_irq); > } >