From: Florian Fainelli <f.fainelli@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>, Florian Fainelli <f.fainelli@gmail.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
open list <linux-kernel@vger.kernel.org>,
hkallweit1@gmail.com, bcm-kernel-feedback-list@broadcom.com,
manasa.mudireddy@broadcom.com, ray.jui@broadcom.com,
olteanv@gmail.com, rafal@milecki.pl
Subject: Re: [PATCH 0/2] net: phy: broadcom: RGMII delays fixes
Date: Thu, 3 Oct 2019 11:55:40 -0700 [thread overview]
Message-ID: <0d5e4195-c407-2915-de96-3c4b3713ada0@gmail.com> (raw)
In-Reply-To: <20191003185116.GA21875@lunn.ch>
Hi Andrew,
On 10/3/19 11:51 AM, Andrew Lunn wrote:
> On Thu, Oct 03, 2019 at 11:43:50AM -0700, Florian Fainelli wrote:
>> Hi all,
>>
>> This patch series fixes the BCM54210E RGMII delay configuration which
>> could only have worked in a PHY_INTERFACE_MODE_RGMII configuration.
>
> Hi Florian
>
> So any DT blob which incorrectly uses one of the other RGMII modes is
> now going to break, where as before it was ignored.
Potentially yes. There is a precedent with the at803x PHY driver, and
both changes here aim for correcting that mistake. The PHY driver not
looking at phy_interface_t is a bug though. I will have a separate
conversation about solving those problems in a more generic way with you
and Heiner.
Rafal, do you have the platform DTS for which you added BCM54210E
support available somewhere so we can see whether this is going to break?
>
> Maybe we should let this sit in net-next for a while, before back
> porting, so we get an idea of how many platforms we might be about to
> break?
Fine with me. It solves Ray's and Manasa's customer problem immediately
and they already back ported the first change in the their tree AFAICT.
--
Florian
next prev parent reply other threads:[~2019-10-03 18:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-03 18:43 Florian Fainelli
2019-10-03 18:43 ` [PATCH 1/2] net: phy: broadcom: Fix RGMII delays configuration for BCM54210E Florian Fainelli
2019-10-03 18:43 ` [PATCH 2/2] net: phy: broadcom: Use bcm54xx_config_clock_delay() for BCM54612E Florian Fainelli
2019-10-03 18:51 ` [PATCH 0/2] net: phy: broadcom: RGMII delays fixes Andrew Lunn
2019-10-03 18:55 ` Florian Fainelli [this message]
2019-10-03 19:06 ` Andrew Lunn
2019-10-03 19:54 ` Vladimir Oltean
2019-10-03 20:10 ` Andrew Lunn
2019-10-04 21:13 ` David Miller
2019-10-04 21:18 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d5e4195-c407-2915-de96-3c4b3713ada0@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manasa.mudireddy@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=rafal@milecki.pl \
--cc=ray.jui@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®