mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Lawrence <joe.lawrence@redhat.com>
To: Miroslav Benes <mbenes@suse.cz>,
	jikos@kernel.org, jpoimboe@redhat.com, pmladek@suse.com
Cc: kamalesh@linux.vnet.ibm.com, live-patching@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] livepatch: Remove stale kobj_added entries from kernel-doc descriptions
Date: Tue, 7 May 2019 09:12:26 -0400	[thread overview]
Message-ID: <0d62c598-1f59-c931-c2bd-2600683c57f6@redhat.com> (raw)
In-Reply-To: <20190507130815.17685-1-mbenes@suse.cz>

On 5/7/19 9:08 AM, Miroslav Benes wrote:
> Commit 4d141ab3416d ("livepatch: Remove custom kobject state handling")
> removed kobj_added members of klp_func, klp_object and klp_patch
> structures. kernel-doc descriptions were omitted by accident. Remove
> them.
> 
> Reported-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
> Signed-off-by: Miroslav Benes <mbenes@suse.cz>
> ---
>   include/linux/livepatch.h | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/include/linux/livepatch.h b/include/linux/livepatch.h
> index a14bab1a0a3e..955d46f37b72 100644
> --- a/include/linux/livepatch.h
> +++ b/include/linux/livepatch.h
> @@ -47,7 +47,6 @@
>    * @stack_node:	list node for klp_ops func_stack list
>    * @old_size:	size of the old function
>    * @new_size:	size of the new function
> - * @kobj_added: @kobj has been added and needs freeing
>    * @nop:        temporary patch to use the original code again; dyn. allocated
>    * @patched:	the func has been added to the klp_ops list
>    * @transition:	the func is currently being applied or reverted
> @@ -125,7 +124,6 @@ struct klp_callbacks {
>    * @node:	list node for klp_patch obj_list
>    * @mod:	kernel module associated with the patched object
>    *		(NULL for vmlinux)
> - * @kobj_added: @kobj has been added and needs freeing
>    * @dynamic:    temporary object for nop functions; dynamically allocated
>    * @patched:	the object's funcs have been added to the klp_ops list
>    */
> @@ -152,7 +150,6 @@ struct klp_object {
>    * @list:	list node for global list of actively used patches
>    * @kobj:	kobject for sysfs resources
>    * @obj_list:	dynamic list of the object entries
> - * @kobj_added: @kobj has been added and needs freeing
>    * @enabled:	the patch is enabled (but operation may be incomplete)
>    * @forced:	was involved in a forced transition
>    * @free_work:	patch cleanup from workqueue-context
> 

D'oh, missed that in the review.  Good eye, Kamalesh.

Acked-by: Joe Lawrence <joe.lawrence@redhat.com>

-- Joe

  reply	other threads:[~2019-05-07 13:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-07 13:08 Miroslav Benes
2019-05-07 13:12 ` Joe Lawrence [this message]
2019-05-07 14:29 ` Kamalesh Babulal
2019-05-09 15:22 ` Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0d62c598-1f59-c931-c2bd-2600683c57f6@redhat.com \
    --to=joe.lawrence@redhat.com \
    --cc=jikos@kernel.org \
    --cc=jpoimboe@redhat.com \
    --cc=kamalesh@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=live-patching@vger.kernel.org \
    --cc=mbenes@suse.cz \
    --cc=pmladek@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®