From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 360E6C43441 for ; Sun, 18 Nov 2018 19:42:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E398220817 for ; Sun, 18 Nov 2018 19:42:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E398220817 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726072AbeKSGDu (ORCPT ); Mon, 19 Nov 2018 01:03:50 -0500 Received: from smtprelay0166.hostedemail.com ([216.40.44.166]:48881 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725805AbeKSGDt (ORCPT ); Mon, 19 Nov 2018 01:03:49 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay05.hostedemail.com (Postfix) with ESMTP id 3ED8D180278B7; Sun, 18 Nov 2018 19:42:39 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: join11_16e4a221e5f2f X-Filterd-Recvd-Size: 2520 Received: from XPS-9350.home (unknown [47.151.153.53]) (Authenticated sender: joe@perches.com) by omf03.hostedemail.com (Postfix) with ESMTPA; Sun, 18 Nov 2018 19:42:37 +0000 (UTC) Message-ID: <0d630c2b5d234eb4131b8021b345edbf080b2c52.camel@perches.com> Subject: Re: [PATCH] staging: greybus: Parenthesis alignment From: Joe Perches To: Cristian Sicilia , Vaibhav Hiremath , Johan Hovold , Alex Elder , Greg Kroah-Hartman , Vaibhav Agarwal , Mark Greer , Rui Miguel Silva , David Lin Cc: Viresh Kumar , Bryan O'Donoghue , linux-kernel@vger.kernel.org Date: Sun, 18 Nov 2018 11:42:35 -0800 In-Reply-To: <1542569289-19899-1-git-send-email-sicilia.cristian@gmail.com> References: <1542569289-19899-1-git-send-email-sicilia.cristian@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.30.1-1build1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2018-11-18 at 20:28 +0100, Cristian Sicilia wrote: > Some parameters are aligned with parentheses. > Some parentheses are opened at end of line. Given the very long identifier lengths, I wouldn't consider many of these appropriate. 80 column line lengths and long identifiers don't play well together. > diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c [] > @@ -70,7 +70,7 @@ static int gbaudio_module_enable_tx(struct gbaudio_codec_info *codec, > i2s_port = 0; /* fixed for now */ > cportid = data->connection->hd_cport_id; > ret = gb_audio_apbridgea_register_cport(data->connection, > - i2s_port, cportid, > + i2s_port, cportid, > AUDIO_APBRIDGEA_DIRECTION_TX); But if you are going to do this for multiple line statements, please fix all the line continuations of the statement, not just the first. > if (ret) { > dev_err_ratelimited(module->dev, > @@ -160,7 +160,7 @@ static int gbaudio_module_disable_tx(struct gbaudio_module_info *module, int id) > i2s_port = 0; /* fixed for now */ > cportid = data->connection->hd_cport_id; > ret = gb_audio_apbridgea_unregister_cport(data->connection, > - i2s_port, cportid, > + i2s_port, cportid, > AUDIO_APBRIDGEA_DIRECTION_TX); etc...