From: Ciprian Marian Costea <ciprianmarian.costea@oss.nxp.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-can@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, NXP S32 Linux <s32@nxp.com>,
imx@lists.linux.dev, Christophe Lizzi <clizzi@redhat.com>,
Alberto Ruiz <aruizrui@redhat.com>,
Enric Balletbo <eballetb@redhat.com>
Subject: Re: [PATCH v4 3/3] can: flexcan: add NXP S32G2/S32G3 SoC support
Date: Mon, 3 Feb 2025 15:53:37 +0200 [thread overview]
Message-ID: <0d639e78-d5f5-4c58-bb11-fdd9d3ee1ff3@oss.nxp.com> (raw)
In-Reply-To: <20241204-fantastic-rare-civet-8d24ec-mkl@pengutronix.de>
On 12/4/2024 1:48 PM, Marc Kleine-Budde wrote:
> On 04.12.2024 13:38:51, Ciprian Marian Costea wrote:
>>> Unrelated to this patch, but I want to extend the "FLEXCAN hardware
>>> feature flags" table in "flexcan.h". Can you provide the needed
>>> information?
>>>
>>
>> I would say the following S32G related information could be added:
>>
>>>> /* FLEXCAN hardware feature flags
>>>> *
>>>> * Below is some version info we got:
>>>> * SOC Version IP-Version Glitch- [TR]WRN_INT IRQ Err Memory err RTR rece- FD Mode MB
>>>> * Filter? connected? Passive detection ption in MB Supported?
>>>> * MCF5441X FlexCAN2 ? no yes no no no no 16
>>>> * MX25 FlexCAN2 03.00.00.00 no no no no no no 64
>>>> * MX28 FlexCAN2 03.00.04.00 yes yes no no no no 64
>>>> * MX35 FlexCAN2 03.00.00.00 no no no no no no 64
>>>> * MX53 FlexCAN2 03.00.00.00 yes no no no no no 64
>>>> * MX6s FlexCAN3 10.00.12.00 yes yes no no yes no 64
>>>> * MX8QM FlexCAN3 03.00.23.00 yes yes no no yes yes 64
>>>> * MX8MP FlexCAN3 03.00.17.01 yes yes no yes yes yes 64
>>>> * VF610 FlexCAN3 ? no yes no yes yes? no 64
>>>> * LS1021A FlexCAN2 03.00.04.00 no yes no no yes no 64
>>>> * LX2160A FlexCAN3 03.00.23.00 no yes no yes yes yes 64
>> * S32G2/S32G3 FlexCAN3 03.00.39.00 no yes no yes yes yes 128
>>>> *
>>>> * Some SOCs do not have the RX_WARN & TX_WARN interrupt line connected.
>>>> */
>>
>> Would you like me to send another version of this patchset with above
>> information included ?
>
> No. Once we have Krzysztof's ACK for the DT binding changes, I'll take
> this series.
>
> I think we'll make that a separate patch and maybe add more information.
>
> regards,
> Marc
>
Hello Krzysztof,
I've addressed your feedback from the previous version of this patchset.
Is the current version ok from your point of view with respect to DT
bindings changes?
Regards,
Ciprian
prev parent reply other threads:[~2025-02-03 13:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-04 7:49 [PATCH v4 0/3] add FlexCAN support for S32G2/S32G3 SoCs Ciprian Costea
2024-12-04 7:49 ` [PATCH v4 1/3] dt-bindings: can: fsl,flexcan: add S32G2/S32G3 SoC support Ciprian Costea
2024-12-04 17:57 ` Conor Dooley
2025-02-06 12:47 ` Marc Kleine-Budde
2024-12-04 7:49 ` [PATCH v4 2/3] can: flexcan: Add quirk to handle separate interrupt lines for mailboxes Ciprian Costea
2024-12-04 7:49 ` [PATCH v4 3/3] can: flexcan: add NXP S32G2/S32G3 SoC support Ciprian Costea
2024-12-04 8:05 ` Marc Kleine-Budde
2024-12-04 11:38 ` Ciprian Marian Costea
2024-12-04 11:48 ` Marc Kleine-Budde
2025-02-03 13:53 ` Ciprian Marian Costea [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d639e78-d5f5-4c58-bb11-fdd9d3ee1ff3@oss.nxp.com \
--to=ciprianmarian.costea@oss.nxp.com \
--cc=aruizrui@redhat.com \
--cc=clizzi@redhat.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eballetb@redhat.com \
--cc=imx@lists.linux.dev \
--cc=krzk+dt@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=mkl@pengutronix.de \
--cc=robh@kernel.org \
--cc=s32@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®