From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1790630E837 for ; Mon, 1 Dec 2025 12:55:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764593745; cv=none; b=HEZNCN3llMjYqb6EwmhHTRJ5gAujoPA+G89iEWVcFiW7iKj4Yv12vAeTTaaEVn7tUoMzDEuM+6eUth3FVu5grAZ6JddILXMNq47PHkwsRRFqR8nvzUainUAi3TJgygtNkVNVOHRttXgIIqCplAyvU0sDfS+my2qq3hycD7r93tI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764593745; c=relaxed/simple; bh=qjX1boH73SydNBCKz6rHEzs7qKGoe+IFikmqMqToHyw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CwQ13i4jTUVfgVtrgJC7uuHdZMtQC2ADEgZjjUCM5AkNyV0wJurPdUiUwYyRLiVqspWOVDc+S++KFA8IEzjIbprt9yEEy3Pbjc4XAUT9h9aap+MSIcKQGiHyoLy7+PTVSSVzH6q6aCA3VhGQZ3nCdTuTEZhEI8UrsKNI8l/i6ng= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=S0BfY/UJ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Dk77N16E; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="S0BfY/UJ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Dk77N16E" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B18euWV2725198 for ; Mon, 1 Dec 2025 12:55:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= P0bpogltmQbh7eQJBYiW+bKvhzS+VMTMFejGkBnimcE=; b=S0BfY/UJX158Rdxn eaO7DsrRTqxR9Jeg3D3Dquagr/XXW/x8NUqoq2cnpVD91mHI6awFGb+0+Rh3jhTz +RFjp5IIpVPa+hLr6H1xMi1C9p+Sitjxv9/agGXN+9XWNPAxscy2ZbVwZyXpXIeF Vfizccnc0lNSpk2ejy8tgz4zUr1Mkb0KBIhYW4K1EI7cGhA9fiS7ve4QiRscIJpe 9OV0Py2i+Ygxd/PFdidpBGHb9QZbDEvKBr1YxrJt/kUTLkkbbYjKMQrj9rSN2CUK kg4dEySdiOqhvvm5Gf973QBVxGR27ox+rRYj5vUy5N1u2GKZug8jxuVqbs1+5HMd fKTMSg== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4arwnvt116-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 01 Dec 2025 12:55:42 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-4ed83a05863so16063731cf.2 for ; Mon, 01 Dec 2025 04:55:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764593741; x=1765198541; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=P0bpogltmQbh7eQJBYiW+bKvhzS+VMTMFejGkBnimcE=; b=Dk77N16EBC7xrAX9Z6slMdyv3QO3I9v84DS2czXq66Ai6XPq00KJXDrF7uo0fgVjem Cs0KVdfKXBenocsYljEFH+0Qbrp8026oQSdWaMTt6Na4Bq1ficWdxFYmtYOGub0bvEIn z25oEZJqEZfZ1YOpIcQ7E5Tu0oKZzMjl2df+Ltm9H0vfY1IaVqof3XWTMg353l0ZqLZj i3GgoILlQz40F+BSwnTt2FrOIN5UnAUbVxw+QIu9aAY6p8Sunz4IG6m9vkyb5Qh3IobP XdgUEiDlNJu8EeD9xGAJQOmpPhISsWANwhaaKWkV2equKDUqi9k/ud5zYyTsNX8Ib1Sh TmIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764593741; x=1765198541; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=P0bpogltmQbh7eQJBYiW+bKvhzS+VMTMFejGkBnimcE=; b=pffDGWp9TMRY7tuXDCtkrLqjPzdmJCpBM4BCW+G2U3fmfQIYjn3CAoutznariwgdKS WebnGb1+mQLoX4YkEvmXIH5JBlxxeOLdW9sTYQJp2yXTaxBPlPhyicWe1ozqHsHKKh3E aO5MLtw08rtjiaMKqDHQl0//3rmulCK83rqlkTryAKlIBJuaqPnX9X+VZ6h5tkgCjwW3 Vn7NpuOWdFSOtQj3mG77wNMrAqNx3v1mEpjSgkN119xSBysFgWVPEA2Q5mIgfLcrmF/m l9LUO8CsYjCyDYvlUsuKcOgFr6JEQZ2L1O8/4MXaqv+m2DUqCmMOSsAxF8zCuIb/yuQO D4+w== X-Forwarded-Encrypted: i=1; AJvYcCXb7mkgip0Kgw3mK17B4JuqkRTGP2zY73MYLnZ77JgbOqMp9+MOZovn+5cBm3LMg7xCBZ16N8wfkJWwrJ0=@vger.kernel.org X-Gm-Message-State: AOJu0YxvIEoRxxmLTr3fSHu6g6sCrybc0zsdzfd5o3IrGq04y2u7VMib KZR+irxnerOEQAX24SdrEyZp/prtHjGLHysiknAuNQsXUKoREHH2L9Z5F/7BGuQTIkV06A4oLN1 1modh28/lJ1sQ7XQkSzZtmm0Ynkn0kH0FmEKdJqFtuX5fyax3Ci4NEl0aVkijibos9RA= X-Gm-Gg: ASbGnctMnJCwlRxm+IEdmjj3pZB7dF1ulbS6nEnMJmYPpE16nw/fsuV1QHY39niYKEk CtszGA4/9nQGRIBrV6+M7V7rTZsj/XWnxJ8l2p2INSKIy6SvpcefgKGbsHOkYB8eW7DCFLeaZA0 fePM08duMyoo8W9lIFA4HHL3pUlBkrsXFETR1k2BNPraqrktwVCXd6QFzD251dNRB9U0Ip92kti EkCIynG5OJhr+nXBnJZY1UFPBg8SlFLfjeJNfYi4jEtNelIAwW26cx7cQCpuUJAjwSM5r+/3N2j WRe5u20tkx2CH5HmgVcPIPwsM/5JzZGqr6eTDchmmBAuMglH41MDwR0SG8n1Fu1jLNyL4BGcY0Q cGJV33EJrESjZyp0rw8dfWy+gMtAdAOzRceQc0D0mc6iuSjragp1oGTMPnIS9yk41IA0= X-Received: by 2002:a05:622a:1108:b0:4ed:a574:64cb with SMTP id d75a77b69052e-4ee58850982mr407107031cf.3.1764593740992; Mon, 01 Dec 2025 04:55:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IHmjj0MqTTdL7Sg51Iv8ThAIsd2fTvcywFmFZkGgrzSN/jzajCzDAtkVxmT1U936hxOLJRBSQ== X-Received: by 2002:a05:622a:1108:b0:4ed:a574:64cb with SMTP id d75a77b69052e-4ee58850982mr407106831cf.3.1764593740545; Mon, 01 Dec 2025 04:55:40 -0800 (PST) Received: from [192.168.119.202] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-64750a90c93sm12300309a12.9.2025.12.01.04.55.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Dec 2025 04:55:40 -0800 (PST) Message-ID: <0d63bddf-7a88-4c59-8ba3-6655e7a8854e@oss.qualcomm.com> Date: Mon, 1 Dec 2025 13:55:38 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: qcom: sdm845-oneplus: labibb is not used on OnePlus 6/6T To: Casey Connolly , david@ixit.cz, Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org References: <20251130-oneplus-labibb-v1-1-bb3653e43120@ixit.cz> <3fcfc5b8-7509-4e4c-a1cd-e973d7e1d091@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: Rb3T60Qkq_oqrjA8t1-n_RAx-iVndj80 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjAxMDEwNSBTYWx0ZWRfX7kH0Al/nvVC7 bVvUhj4WF2zAa+pArIii3Idy9ttFlMBo1/hY7214qd3IY0MlrMebDLkpS87GRUGQC4rcBfhPrMq jucficcMNKqr0vWcW2B3TckST/v4gqUZGmI1jq9DkZ1ANk0RIFcCJXiY+IXjsJLhLTr3nZ3+INs f9bpoHHpx6NALIU4Kdtt7j+uIRBeBuiN6B2kYSVCccl2M1EAD12wWvG/qunrlrEJGQBHH0hPaAr w2OxfU4/4xjUFILXn+D654W3gfVgAD4UwextKjWLYLnDRSdt/RdZRmUoSkZ1tgaJTydRQoV/MFT AVZRp9fPgBhM0G12LTe7b2tJzswdyaGAspD3hKy2uCDu85GpiBfSAMZFBY7iotiBzouSF2eB5PH glxrepaNIGT5W91UzQ+PzKcJW1yLbw== X-Authority-Analysis: v=2.4 cv=Urxu9uwB c=1 sm=1 tr=0 ts=692d904e cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=4_HY7mAHSgI59XXtPg4A:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-GUID: Rb3T60Qkq_oqrjA8t1-n_RAx-iVndj80 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-28_08,2025-11-27_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 phishscore=0 malwarescore=0 lowpriorityscore=0 priorityscore=1501 impostorscore=0 clxscore=1015 adultscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512010105 On 12/1/25 1:50 PM, Casey Connolly wrote: > > > On 01/12/2025 13:48, Konrad Dybcio wrote: >> On 11/30/25 1:08 AM, David Heidelberg via B4 Relay wrote: >>> From: David Heidelberg >>> >>> The lab and ibb regulators aren't used here. Disable them. >>> >>> Removes following warnings: >>> qcom-lab-ibb-regulator c440000.spmi:pmic@3:labibb: Failed to create device link (0x180) with supplier c440000.spmi for /soc@0/spmi@c440000/pmic@3/labibb/lab >>> qcom-lab-ibb-regulator c440000.spmi:pmic@3:labibb: Failed to create device link (0x180) with supplier c440000.spmi for /soc@0/spmi@c440000/pmic@3/labibb/ibb >> >> These are only vaguely related, as there's nothing to be wary about that's >> specific to these devices - it's just devlink being grumpy >> >>> Fixes: 288ef8a42612 ("arm64: dts: sdm845: add oneplus6/6t devices") >>> Signed-off-by: David Heidelberg >>> --- >>> I assume this is right approach, as OLEDs on both devices are driven by >>> different regulators. >>> >>> Question is, if should be labibb nodes enabled by default? >> >> They're onboard. I'd rather keep them predictably parked than left in >> whatever (potentially ON) state the bootloader may leave them at > > Shouldn't they be default disabled in the pmic dtsi and only enabled on > the devices that actually use them? Many SDM845 devices with OLED panels > don't use these regulators. As I said, I wouldn't be surprised if they were enabled by the bootloader as part of some reference/common routine and left hanging. Linux will switch them off if they're never used and I'm fairly sure the users won't mind the odd couple dozen bytes of runtime kernel memory usage (which if we go that route probably balance out with the added couple characters for status=disabled in the resulting DTB) Konrad