From: JC Kuo <jckuo@nvidia.com>
To: Jon Hunter <jonathanh@nvidia.com>, <gregkh@linuxfoundation.org>,
<thierry.reding@gmail.com>, <robh+dt@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
<devicetree@vger.kernel.org>
Subject: Re: [PATCH v1] arm64: tegra: jetson-tx1: Fix USB_VBUS_EN0 regulator
Date: Thu, 19 Nov 2020 10:59:28 +0800 [thread overview]
Message-ID: <0d66af1a-c136-7065-503d-ca13a7468943@nvidia.com> (raw)
In-Reply-To: <6e21646a-a687-65b7-cd69-2c15e29e8241@nvidia.com>
On 11/18/20 7:24 PM, Jon Hunter wrote:
>
> On 18/11/2020 03:46, JC Kuo wrote:
>> USB_VBUS_EN0 regulator (regulator@11) is being overwritten by vdd-cam-1v2
>> regulator. This commit rearrange USB_VBUS_EN0 to be regulator@14.
>>
>> Signed-off-by: JC Kuo <jckuo@nvidia.com>
>> ---
>> .../arm64/boot/dts/nvidia/tegra210-p2597.dtsi | 20 +++++++++----------
>> 1 file changed, 10 insertions(+), 10 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi b/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi
>> index e18e1a9a3011..a9caaf7c0d67 100644
>> --- a/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi
>> +++ b/arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi
>> @@ -1663,16 +1663,6 @@ vdd_usb_vbus: regulator@9 {
>> vin-supply = <&vdd_5v0_sys>;
>> };
>>
>> - vdd_usb_vbus_otg: regulator@11 {
>> - compatible = "regulator-fixed";
>> - regulator-name = "USB_VBUS_EN0";
>> - regulator-min-microvolt = <5000000>;
>> - regulator-max-microvolt = <5000000>;
>> - gpio = <&gpio TEGRA_GPIO(CC, 4) GPIO_ACTIVE_HIGH>;
>> - enable-active-high;
>> - vin-supply = <&vdd_5v0_sys>;
>> - };
>> -
>> vdd_hdmi: regulator@10 {
>> compatible = "regulator-fixed";
>> regulator-name = "VDD_HDMI_5V0";
>> @@ -1712,4 +1702,14 @@ vdd_cam_1v8: regulator@13 {
>> enable-active-high;
>> vin-supply = <&vdd_3v3_sys>;
>> };
>> +
>> + vdd_usb_vbus_otg: regulator@14 {
>> + compatible = "regulator-fixed";
>> + regulator-name = "USB_VBUS_EN0";
>> + regulator-min-microvolt = <5000000>;
>> + regulator-max-microvolt = <5000000>;
>> + gpio = <&gpio TEGRA_GPIO(CC, 4) GPIO_ACTIVE_HIGH>;
>> + enable-active-high;
>> + vin-supply = <&vdd_5v0_sys>;
>> + };
>> };
>>
>
> Thanks for catching this! We should add the 'Fixes:' tag.
Thanks for review. I will submit v2 and add 'Fixes:' tag.
>
> By the way, I assume that VBUS is currently broken for the OTG port.
> Without this change is that USB port completely broken? I am wondering
> if we need to CC stable@vger.kernel.org on this.
You are correct. Host mode at the OTG port is currently broken because VBUS is
not supplied to the OTG port. I will CC stable@vger.kernel.org when send v2.
>
> Reviewed-by: Jon Hunter <jonathanh@nvidia.com>
>
> Cheers
> Jon
>
prev parent reply other threads:[~2020-11-19 3:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-18 3:46 JC Kuo
2020-11-18 11:24 ` Jon Hunter
2020-11-19 2:59 ` JC Kuo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d66af1a-c136-7065-503d-ca13a7468943@nvidia.com \
--to=jckuo@nvidia.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®