From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751230AbdAMSQR (ORCPT ); Fri, 13 Jan 2017 13:16:17 -0500 Received: from vern.gendns.com ([206.190.152.46]:44426 "EHLO vern.gendns.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750713AbdAMSQO (ORCPT ); Fri, 13 Jan 2017 13:16:14 -0500 Subject: Re: [PATCH v3] ARM: dts: Add LEGO MINDSTORMS EV3 dts To: Sekhar Nori , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <1484253167-27568-1-git-send-email-david@lechnology.com> <3066d614-0676-319a-6149-6d723e1cf35f@ti.com> Cc: Kevin Hilman , Rob Herring , Mark Rutland , linux-kernel@vger.kernel.org From: David Lechner Message-ID: <0d69ff4b-c3a6-5126-2590-2268d3b25f92@lechnology.com> Date: Fri, 13 Jan 2017 12:16:11 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <3066d614-0676-319a-6149-6d723e1cf35f@ti.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vern.gendns.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lechnology.com X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/13/2017 06:04 AM, Sekhar Nori wrote: > On Friday 13 January 2017 02:02 AM, David Lechner wrote: >> This adds a device tree definition file for LEGO MINDSTORMS EV3. >> ... > > There are couple of checkpatch errors that show up. The compatible > "lego,ev3" needs to be documented in > Documentation/devicetree/bindings/arm/davinci.txt > > "at24,24c128" is undocumented. Is that an atmel chip on the EV3? If the > manufacturer name is not clear, > Documentation/devicetree/bindings/eeprom/eeprom.txt advises using just > "24c128" The mfg is microchip, so I guess I will just go with "24c128" > > Finally, lego needs to be added to > Documentation/devicetree/bindings/vendor-prefixes.txt > > Can you please submit the documentation portions as separate patches in > a series along with this patch. Yes. > > Thanks, > Sekhar >