From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755153AbcIJU2R (ORCPT ); Sat, 10 Sep 2016 16:28:17 -0400 Received: from mout.web.de ([212.227.17.12]:58872 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751971AbcIJU2Q (ORCPT ); Sat, 10 Sep 2016 16:28:16 -0400 Subject: [PATCH 06/13] DRBD-receiver: Improve a size determination in receive_sizes() To: drbd-dev@lists.linbit.com, Lars Ellenberg , Philipp Reisner References: <3566e764-27b8-82e5-1f8e-c613e5a3a5b1@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: <0d722998-966d-9133-48e5-69e32ae2d8b9@users.sourceforge.net> Date: Sat, 10 Sep 2016 22:28:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <3566e764-27b8-82e5-1f8e-c613e5a3a5b1@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:xxC0del7AKB1AxfYpyMeIEK9jR+28s4V2S4wbyzxTDl3Xd/uMPn W8fHaneOndwk1sqMIz6xLaQILmef23OXEmTjYG+Q05P/lTi2maOlLY9yLs15qG9Z3q2AeS0 HR5/DzMPMeQa4AfjdbYwgTN6fep+L4Fro7e4GVYJVCeWS4X/DExfn+PZVbHTGKy7ad3kvRT pFeGUuXa4snSsvy7w8K6Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:MFhxB16aQ5U=:OdaNxQ0ECY6w5xcZ2cu7fG IC3LgpVz2UGVMjXw4ADCquJ+Z72tt3QJBBq8p2zZVtlNuM3POTEIu2p6fvKQxOh25wrKfRkV9 WgsX0tlXauj7dz4JR/SYlHcwcNosheuxnuNyGznNfhyr8T2gSQCuQAT1Cv94VRdYx0Vbw0Bbu bC6PBeovZuBurFwSk57XAAkyGYl/7b27a0DLXs0ri6DVfEZw3SHuK/FAc3sAG22Bog/NiW+Ek Z9L3MOUpZMsq0S/KqpodLWoXSJsn3DxEx8sXr9oq2CteEZH6jjkVXEFzAbxKqFJt52OlGBtaQ Gp2rKnAZij3YSBJo+wx3SfIeUYKkv1xfYmoPbmQDQDhfoE/YYFMLThSpa8102VzNWYLR9PHsf twQbER8kbtidLrtL46McEhWOKwXTfHyzTSYbjPTKF1L2h5FM73lQxh1MWvx5bIn09tgTH2yT3 zGG/AnkK/4MEV3Z4agYvAzSDDGcec57MppDRkEoQros+4oLwjLYxpTIHFcjR1ieegl6hI1dgn azWsckbX5lQBiPNEqUSF+iNLHDPVMY+MOmBxsOyfJBpedfoI3mdQhE/uMjnO/DmGs/iomBLrf tu9nuYdXwNWxafGSeBK54aG3uvNNDOgP6DFWChwQf+LGRmFDQu51P67jV8f7dPUEeBBDSpQbf jsM2Pcmwdwm8RVsiL9tEkkeY1YS7F5mYVCyN9NuskSBwKBS/xEZAFuVo4ikrajiodL4Ijo+EM Anu9EzO1n3yo8OY8uE3M7tId03Qp11s332ald7xWc9E5r5uQmnkVSloyxLQE8ZQYj0DNnhgoh AcDOHWe Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 10 Sep 2016 21:45:13 +0200 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/block/drbd/drbd_receiver.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/block/drbd/drbd_receiver.c b/drivers/block/drbd/drbd_receiver.c index 7666212..64bc316 100644 --- a/drivers/block/drbd/drbd_receiver.c +++ b/drivers/block/drbd/drbd_receiver.c @@ -4085,7 +4085,8 @@ static int receive_sizes(struct drbd_connection *connection, struct packet_info if (my_usize != p_usize) { struct disk_conf *old_disk_conf, *new_disk_conf; - new_disk_conf = kzalloc(sizeof(struct disk_conf), GFP_KERNEL); + new_disk_conf = kzalloc(sizeof(*new_disk_conf), + GFP_KERNEL); if (!new_disk_conf) { drbd_err(device, "Allocation of new disk_conf failed\n"); put_ldev(device); -- 2.10.0