From: Joe Perches <joe@perches.com>
To: "Darrick J. Wong" <djwong@kernel.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH][next] xfs: Fix fall-through warnings for Clang
Date: Tue, 20 Apr 2021 20:11:02 -0700 [thread overview]
Message-ID: <0d799df884ec9088501d6699c6ed97728eebad53.camel@perches.com> (raw)
In-Reply-To: <20210420233850.GQ3122264@magnolia>
On Tue, 2021-04-20 at 16:38 -0700, Darrick J. Wong wrote:
> On Tue, Apr 20, 2021 at 06:06:52PM -0500, Gustavo A. R. Silva wrote:
> > In preparation to enable -Wimplicit-fallthrough for Clang, fix
> > the following warnings by replacing /* fall through */ comments,
> > and its variants, with the new pseudo-keyword macro fallthrough:
[]
> > Notice that Clang doesn't recognize /* fall through */ comments as
> > implicit fall-through markings, so in order to globally enable
> > -Wimplicit-fallthrough for Clang, these comments need to be
> > replaced with fallthrough; in the whole codebase.
> >
> > Link: https://github.com/KSPP/linux/issues/115
> > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
>
> I've already NAKd this twice, so I guess I'll NAK it a third time.
Sorry, I've must have missed it before. Why did you NAK this?
prev parent reply other threads:[~2021-04-21 3:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 23:06 Gustavo A. R. Silva
2021-04-20 23:38 ` Darrick J. Wong
2021-04-20 23:56 ` Gustavo A. R. Silva
2021-05-26 18:21 ` Gustavo A. R. Silva
2021-05-26 21:16 ` Darrick J. Wong
2021-05-27 21:31 ` Kees Cook
2021-05-28 0:34 ` Darrick J. Wong
2021-05-28 16:48 ` Kees Cook
2021-06-02 0:32 ` Dave Chinner
2021-04-21 3:11 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d799df884ec9088501d6699c6ed97728eebad53.camel@perches.com \
--to=joe@perches.com \
--cc=djwong@kernel.org \
--cc=gustavoars@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®