From: Paolo Abeni <pabeni@redhat.com>
To: "Maxime Chevallier" <maxime.chevallier@bootlin.com>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
davem@davemloft.net, "Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Russell King" <linux@armlinux.org.uk>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Alexis Lothoré" <alexis.lothore@bootlin.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Emil Renner Berthing" <kernel@esmil.dk>,
"Minda Chen" <minda.chen@starfivetech.com>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Kevin Hilman" <khilman@baylibre.com>,
"Jerome Brunet" <jbrunet@baylibre.com>,
"Martin Blumenstingl" <martin.blumenstingl@googlemail.com>,
"Jan Petrous" <jan.petrous@oss.nxp.com>,
"Ovidiu Panait" <ovidiu.panait.rb@renesas.com>,
Jose.Abreu@synopsys.com, "Nicolai Buchwitz" <nb@tipi-net.de>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
thomas.petazzoni@bootlin.com,
linux-arm-kernel@lists.infradead.org,
linux-stm32@st-md-mailman.stormreply.com, PKneuper@dspace.de,
David Laight <david.laight.linux@gmail.com>
Subject: Re: [PATCH net v3 0/6] net: stmmac: More selftest-related fixes
Date: Tue, 15 Sep 2026 10:50:19 +0200 [thread overview]
Message-ID: <0d85afb2-c738-42da-aa1a-aa16e5709948@redhat.com> (raw)
In-Reply-To: <20260911212028.1497613-1-maxime.chevallier@bootlin.com>
On 9/11/26 11:20 PM, Maxime Chevallier wrote:
> Hi everyone,
>
> This is V3 of stmmac selftest fixes, adding a cap on EEE test as the
> timeout can get pretty long, found by Nicolai.
>
> This is another round of stmmac selftest fixes, mostly about the selftests
> themselves but a few things were discovered w.r.t MTU and buffer size
> handling, see patch 5.
>
> I've continued expanding the test devices I'm running this on, more devices
> should come in the future. With this series, _almost_ everything is
> green, except for some flow control stuff that is either a false positive
> or a real thing that needs investigating.
>
> After this is merged, I consider the selftests to be now reliable enough
> to run them nightly on every stmmac series that's sent, and I'll be requiring
> clean selftests for new glue drivers.
>
> I've been running this on :
>
> - Altera CycloneV (dwmac-socfpga, dwmac1000 IP, v3.70a)
> - NXP imx8mp (dwmac-imx, dwmac4, v5.10a)
> - Allwinner H2S (dwmac-sun8i, dwmac1000)
> - Amlogic S905X3 (dwmac-meson8b, dwmac1000, v3.70a)
> - STM32mp157a (dwmac-stm32, dwmac4, v4.20a)
> - SiFive JH7110 (dwmac-starfive, dwmac4, v5.20)
> - Motorcomm YT8061 (PCIe, dwmac-motorcomm, dwmac4)
> - Qualcomm IPQ8064 (dwmac-ipq806x, dwmac1000)
>
> Tests are OK if return is 0 or -95 (-EOPNOTSUPP), tests are KO otherwise
>
> Before the series :
>
> Test imx socfpga sun8i meson8b stm32 starV mcom ipq806x
> MAC Loopback 0 0 0 0 0 0 0 -110
> MMC Counters 0 0 -95 0 0 0 0 -110
> EEE -95 -95 -95 -110 -110 -95 -95 -95
> Hash Filter MC 0 0 -95 0 0 0 0 -95
> Perfect Filter UC -95 0 0 -95 -95 -95 -95 -95
> MC Filter -95 0 -95 -95 -95 -95 -95 -95
> UC Filter -95 0 -95 -95 -95 -95 -95 -95
> Flow Control -95 0 -110 0 -110 -95 -110 -110
> RSS -95 -95 -95 -95 -95 -95 -95 -95
> VLAN Filtering -110 -95 -95 -95 -110 -110 -95 -95
> VLAN Filtering (perf) -110 -95 -95 -95 -110 -110 -95 -95
> Double VLAN Filter -110 -95 -95 -95 -110 -110 -95 -95
> Double VLAN Filter (perf) -110 -95 -95 -95 -110 -110 -95 -95
> Flexible RX Parser 0 -95 -95 -95 -95 -95 -95 -95
> SA Insertion (desc) 0 -95 -95 -95 0 0 0 -95
> SA Replacement (desc) 0 -95 -95 -95 0 0 0 -95
> SA Insertion (reg 0 -95 -95 -95 0 0 0 -95
> SA Replacement (reg) 0 -95 -95 -95 0 0 0 -95
> VLAN TX Insertion -110 -95 -95 -95 -110 -110 -110 -95
> SVLAN TX Insertion -110 -95 -95 -95 -110 -95 -110 -95
> L3 DA Filtering 0 -95 -95 -95 -95 -95 -95 -95
> L3 SA Filtering 0 -95 -95 -95 -95 -95 -95 -95
> L4 DA TCP Filtering 0 -95 -95 -95 -95 -95 -95 -95
> L4 SA TCP Filtering 0 -95 -95 -95 -95 -95 -95 -95
> L4 DA UDP Filtering 0 -95 -95 -95 -95 -95 -95 -95
> L4 SA UDP Filtering 0 -95 -95 -95 -95 -95 -95 -95
> ARP Offload -95 -95 -95 -95 -110 -110 -110 -95
> Jumbo Frame 0 -110 -110 0 0 0 0 -110
> Multichannel Jumbo 0 -95 -95 -95 -95 -95 -95 -95
> Split Header --95 -95 -95 -95 -95 -95 0 -95
> TBS (ETF Scheduler) --95 -95 -95 -95 -95 -95 -95 -95
>
> ARP offload's still there as this was a net-next patch and I've ran these
> checks on the net tree.
>
> Jumbo frame tests on dwmac1000 started failing after :
>
> commit 23680bf5f8c6 ("net: stmmac: restore NET_IP_ALIGN in the RX DMA offset")
>
> This commit is OK though, it just made the selftest reveal the cracks
> hiding beneath the surface of MTU/bufsz handling.
>
> After this series :
>
> Test imx socfpga sun8i meson8b stm32 starV mcom ipq806x
> MAC Loopback 0 0 0 0 0 0 0 0
> MMC Counters 0 0 -95 0 0 0 0 0
> EEE -95 -95 -95 0 0 -95 -95 -95
> Hash Filter MC 0 0 -95 0 0 0 0 -95
> Perfect Filter UC -95 0 0 -95 -95 -95 -95 -95
> MC Filter -95 0 -95 -95 -95 -95 -95 -95
> UC Filter -95 0 -95 -95 -95 -95 -95 -95
> Flow Control -95 0 -110 0 -110 -95 -110 -110
> RSS -95 -95 -95 -95 -95 -95 -95 -95
> VLAN Filtering 0 -95 -95 -95 0 0 -95 -95
> VLAN Filtering (perf) 0 -95 -95 -95 0 0 -95 -95
> Double VLAN Filter 0 -95 -95 -95 0 0 -95 -95
> Double VLAN Filter (perf) 0 -95 -95 -95 0 0 -95 -95
> Flexible RX Parser 0 -95 -95 -95 -95 -95 -95 -95
> SA Insertion (desc) 0 -95 -95 -95 0 0 0 -95
> SA Replacement (desc) 0 -95 -95 -95 0 0 0 -95
> SA Insertion (reg 0 -95 -95 -95 0 0 0 -95
> SA Replacement (reg) 0 -95 -95 -95 0 0 0 -95
> VLAN TX Insertion 0 -95 -95 -95 0 0 0 -95
> SVLAN TX Insertion -95 -95 -95 -95 -95 -95 -95 -95
> L3 DA Filtering 0 -95 -95 -95 -95 -95 -95 -95
> L3 SA Filtering 0 -95 -95 -95 -95 -95 -95 -95
> L4 DA TCP Filtering 0 -95 -95 -95 -95 -95 -95 -95
> L4 SA TCP Filtering 0 -95 -95 -95 -95 -95 -95 -95
> L4 DA UDP Filtering 0 -95 -95 -95 -95 -95 -95 -95
> L4 SA UDP Filtering 0 -95 -95 -95 -95 -95 -95 -95
> ARP Offload -95 -95 -95 -95 -110 -110 -110 -95
> Jumbo Frame 0 0 0 0 0 0 0 0
> Multichannel Jumbo 0 -95 -95 -95 -95 -95 -95 -95
> Split Header -95 -95 -95 -95 -95 -95 0 -95
> TBS (ETF Scheduler) -95 -95 -95 -95 -95 -95 -95 -95
>
> ARP can be ignored, and Flow control needs some more attention, but
> we're getting there :)
>
> Thanks,
>
> Maxime
>
> V3:
> - Bail out of the EEE test if LPI is over 5 seconds
>
> V2:
> https://lore.kernel.org/r/20260910151404.976753-1-maxime.chevallier@bootlin.com
> - Snapshot before sending the frame for EEE, in case we immediately
> enter LPI
> - Also return -ETIMEDOUT instead of EINVAL
>
> V1: https://lore.kernel.org/lkml/20260909074740.1247762-1-maxime.chevallier@bootlin.com/
>
> Maxime Chevallier (6):
> net: stmmac: selftests: Support running selftests on DSA conduits
> net: stmmac: selftests: Validate EEE based on the actual LPI timer
> value
> net: stmmac: selftests: Check the dev->features for S-TAG offload
> testing
> net: stmmac: selftests: Capture all packets for vlan checks
> net: stmmac: size the RX buffers from the frame length, not the MTU
> net: stmmac: selftests: Account for alignment shift on dwmac1000 for
> Jumbo test
>
> .../net/ethernet/stmicro/stmmac/stmmac_main.c | 20 +--
> .../stmicro/stmmac/stmmac_selftests.c | 121 +++++++++++++++---
> 2 files changed, 114 insertions(+), 27 deletions(-)
It looks like that the possible ETIMEDOUT reported on patch 4/6 is
contradicted by your testing, but the other not pre-existing 'high prio'
findings from clashiko look actionable to me.
/P
prev parent reply other threads:[~2026-09-15 8:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-11 21:20 Maxime Chevallier
2026-09-11 21:20 ` [PATCH net v3 1/6] net: stmmac: selftests: Support running selftests on DSA conduits Maxime Chevallier
2026-09-15 8:45 ` Paolo Abeni
2026-09-15 9:22 ` Maxime Chevallier
2026-09-11 21:20 ` [PATCH net v3 2/6] net: stmmac: selftests: Validate EEE based on the actual LPI timer value Maxime Chevallier
2026-09-11 21:20 ` [PATCH net v3 3/6] net: stmmac: selftests: Check the dev->features for S-TAG offload testing Maxime Chevallier
2026-09-11 21:20 ` [PATCH net v3 4/6] net: stmmac: selftests: Capture all packets for vlan checks Maxime Chevallier
2026-09-15 8:45 ` Paolo Abeni
2026-09-15 11:54 ` Maxime Chevallier
2026-09-11 21:20 ` [PATCH net v3 5/6] net: stmmac: size the RX buffers from the frame length, not the MTU Maxime Chevallier
2026-09-15 8:45 ` Paolo Abeni
2026-09-11 21:20 ` [PATCH net v3 6/6] net: stmmac: selftests: Account for alignment shift on dwmac1000 for Jumbo test Maxime Chevallier
2026-09-15 8:50 ` Paolo Abeni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d85afb2-c738-42da-aa1a-aa16e5709948@redhat.com \
--to=pabeni@redhat.com \
--cc=Jose.Abreu@synopsys.com \
--cc=PKneuper@dspace.de \
--cc=alexandre.torgue@foss.st.com \
--cc=alexis.lothore@bootlin.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=david.laight.linux@gmail.com \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=jan.petrous@oss.nxp.com \
--cc=jbrunet@baylibre.com \
--cc=kernel@esmil.dk \
--cc=khilman@baylibre.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux@armlinux.org.uk \
--cc=martin.blumenstingl@googlemail.com \
--cc=maxime.chevallier@bootlin.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=minda.chen@starfivetech.com \
--cc=nb@tipi-net.de \
--cc=neil.armstrong@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=ovidiu.panait.rb@renesas.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®