From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E5CFC433F5 for ; Tue, 26 Oct 2021 15:51:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 77034610A1 for ; Tue, 26 Oct 2021 15:51:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237115AbhJZPyQ (ORCPT ); Tue, 26 Oct 2021 11:54:16 -0400 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:44754 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S237148AbhJZPxY (ORCPT ); Tue, 26 Oct 2021 11:53:24 -0400 Received: from pps.filterd (m0046660.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 19QFCEqe015340; Tue, 26 Oct 2021 17:50:49 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=7SmDFUSVTJc6gIboFqRZL9sKdd+gL2b7ycoA8OY5yt0=; b=ta8zWYEwI1d9XDIyPUFgtxWZ6yCFHN7mfZVd4dq8x+PxBBU3HsEpbwZt5YogTFs17ezb II9PWCR+ZARca3pDBxmVypNeRPNJ1uNXoMmgs3K4MyDfRbqmSgOpQzbGQHn5QY+ujBSA K6Oi5jhn0dfu7db4alUdNmiPmDcXtNnIzptNj4slmjq6OhjzpGWgl8/mqOES8jpGPVfN krQqFur3CFcHmVOU+jpgkXTJ6CfN1HVrDJy4J2qLORha4Brh29XfcQZivkio8leDt48P kPEwEknR2vbCf+um1VSLe5dZmk0WLyFVokACsX6K416wyoI0+mI+UK7id2Tynv7+rmkt qQ== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 3bxm40r967-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 26 Oct 2021 17:50:49 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id E0A0F100034; Tue, 26 Oct 2021 17:50:48 +0200 (CEST) Received: from Webmail-eu.st.com (sfhdag2node2.st.com [10.75.127.5]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id D8EA8221DC0; Tue, 26 Oct 2021 17:50:48 +0200 (CEST) Received: from lmecxl0995.lme.st.com (10.75.127.48) by SFHDAG2NODE2.st.com (10.75.127.5) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Tue, 26 Oct 2021 17:50:48 +0200 Subject: Re: [PATCH] phy: stm32: adopt dev_err_probe for regulators To: Fabrice Gasnier , , CC: , , , , References: <1635172265-26219-1-git-send-email-fabrice.gasnier@foss.st.com> From: Amelie DELAUNAY Message-ID: <0d889ca2-2538-ea17-5bfd-a3d137115223@foss.st.com> Date: Tue, 26 Oct 2021 17:50:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <1635172265-26219-1-git-send-email-fabrice.gasnier@foss.st.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.75.127.48] X-ClientProxiedBy: SFHDAG2NODE1.st.com (10.75.127.4) To SFHDAG2NODE2.st.com (10.75.127.5) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475 definitions=2021-10-26_04,2021-10-26_01,2020-04-07_01 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Fabrice, Thanks for your patch. On 10/25/21 4:31 PM, Fabrice Gasnier wrote: > Change stm32-usbphyc driver to use dev_err_probe(), to benefit of > devices_deferred debugfs in case of probe deferral. > > Signed-off-by: Fabrice Gasnier Reviewed-by: Amelie Delaunay > --- > drivers/phy/st/phy-stm32-usbphyc.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/drivers/phy/st/phy-stm32-usbphyc.c b/drivers/phy/st/phy-stm32-usbphyc.c > index 7df6a63..115be0e 100644 > --- a/drivers/phy/st/phy-stm32-usbphyc.c > +++ b/drivers/phy/st/phy-stm32-usbphyc.c > @@ -672,17 +672,15 @@ static int stm32_usbphyc_probe(struct platform_device *pdev) > > usbphyc->vdda1v1 = devm_regulator_get(dev, "vdda1v1"); > if (IS_ERR(usbphyc->vdda1v1)) { > - ret = PTR_ERR(usbphyc->vdda1v1); > - if (ret != -EPROBE_DEFER) > - dev_err(dev, "failed to get vdda1v1 supply: %d\n", ret); > + ret = dev_err_probe(dev, PTR_ERR(usbphyc->vdda1v1), > + "failed to get vdda1v1 supply\n"); > goto clk_disable; > } > > usbphyc->vdda1v8 = devm_regulator_get(dev, "vdda1v8"); > if (IS_ERR(usbphyc->vdda1v8)) { > - ret = PTR_ERR(usbphyc->vdda1v8); > - if (ret != -EPROBE_DEFER) > - dev_err(dev, "failed to get vdda1v8 supply: %d\n", ret); > + ret = dev_err_probe(dev, PTR_ERR(usbphyc->vdda1v8), > + "failed to get vdda1v8 supply\n"); > goto clk_disable; > } > >