mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Konrad Dybcio <konrad.dybcio@linaro.org>,
	rfoss@kernel.org, todor.too@gmail.com, agross@kernel.org,
	andersson@kernel.org, mchehab@kernel.org,
	hverkuil-cisco@xs4all.nl, laurent.pinchart@ideasonboard.com,
	sakari.ailus@linux.intel.com, andrey.konovalov@linaro.org
Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 02/14] media: qcom: camss: Start to move to module compat matched resources
Date: Wed, 16 Aug 2023 20:02:52 +0100	[thread overview]
Message-ID: <0d8ccc53-1a4a-8a0a-6886-f7bf9c5ebd75@linaro.org> (raw)
In-Reply-To: <0d4d7d4b-9cbc-40df-98f5-3c9696bf6b13@linaro.org>

On 16/08/2023 18:10, Konrad Dybcio wrote:
> On 14.08.2023 18:28, Bryan O'Donoghue wrote:
>> There is a lot of unnecessary if/elsing in this code that arguably
>> should never have made it upstream when adding a second let alone
>> subsequent SoC.
>>
>> I'm guilty of not fixing the mess myself when adding in the sm8250.
>> Before adding in any new SoCs or resources lets take the time to cleanup
>> the resource passing.
>>
>> First step is to pass the generic struct camss_resources as a parameter
>> per the compatible list.
>>
>> Subsequent patches will address the other somewhat dispirate strutures
>> which we are also doing if/else on and assigning statically.
>>
>> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>> ---
> [...]
> 
> 
>> -
>>   	for (i = 0; i < camss->csiphy_num; i++) {
>>   		ret = msm_csiphy_subdev_init(camss, &camss->csiphy[i],
>> -					     &csiphy_res[i], i);
>> +					     &camss->res->csiphy_res[i], i);
> &camss->res is used quite extensively, so I think it may be a good
> idea to keep the variable there, just make it point to the correct
> new thing.
> 
> Konrad

Sure that makes sense

---
bod

  reply	other threads:[~2023-08-16 19:03 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-14 16:28 [PATCH v1 00/14] media: qcom: camss: Add parameter passing to remove several outstanding bugs Bryan O'Donoghue
2023-08-14 16:28 ` [PATCH v1 01/14] media: qcom: camss: Amalgamate struct resource with struct resource_ispif Bryan O'Donoghue
2023-08-14 16:28 ` [PATCH v1 02/14] media: qcom: camss: Start to move to module compat matched resources Bryan O'Donoghue
2023-08-16 17:10   ` Konrad Dybcio
2023-08-16 19:02     ` Bryan O'Donoghue [this message]
2023-08-14 16:28 ` [PATCH v1 03/14] media: qcom: camss: Drop useless NULL assignment for ispif resources Bryan O'Donoghue
2023-08-16 17:10   ` Konrad Dybcio
2023-08-16 19:06     ` Bryan O'Donoghue
2023-08-14 16:28 ` [PATCH v1 04/14] media: qcom: camss: Pass icc bandwidth table as a platform parameter Bryan O'Donoghue
2023-08-16 17:20   ` Konrad Dybcio
2023-08-16 19:09     ` Bryan O'Donoghue
2023-08-17 10:57       ` Bryan O'Donoghue
2023-08-14 16:28 ` [PATCH v1 05/14] media: qcom: camss: Pass remainder of variables as resources Bryan O'Donoghue
2023-08-14 16:28 ` [PATCH v1 06/14] media: qcom: camss: Pass line_num from compat resources Bryan O'Donoghue
2023-08-14 16:29 ` [PATCH v1 07/14] media: qcom: camss: Assign the correct number of RDIs per VFE Bryan O'Donoghue
2023-08-14 16:29 ` [PATCH v1 08/14] media: qcom: camss: Use >= CAMSS_SDM845 for vfe_get/vfe_put Bryan O'Donoghue
2023-08-14 16:29 ` [PATCH v1 09/14] media: qcom: camss: Untangle if/else spaghetti in camss Bryan O'Donoghue
2023-08-14 16:29 ` [PATCH v1 10/14] media: qcom: camss: Improve error printout on icc_get fail Bryan O'Donoghue
2023-08-14 16:29 ` [PATCH v1 11/14] media: qcom: camss: Allow clocks vfeN vfe_liteN or vfe_lite Bryan O'Donoghue
2023-08-14 16:29 ` [PATCH v1 12/14] media: qcom: camss: Functionally decompose CSIPHY clock lookups Bryan O'Donoghue
2023-08-14 16:29 ` [PATCH v1 13/14] media: qcom: camss: Add support for setting CSIPHY clock name csiphyX Bryan O'Donoghue
2023-08-14 16:29 ` [PATCH v1 14/14] media: qcom: camss: Support RDI3 for VFE 17x Bryan O'Donoghue

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0d8ccc53-1a4a-8a0a-6886-f7bf9c5ebd75@linaro.org \
    --to=bryan.odonoghue@linaro.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=andrey.konovalov@linaro.org \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=konrad.dybcio@linaro.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=rfoss@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=todor.too@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®