From: Jens Axboe <axboe@kernel.dk>
To: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Mikulas Patocka <mpatocka@redhat.com>,
Mike Snitzer <snitzer@redhat.com>, Ming Lei <ming.lei@redhat.com>
Subject: Re: [PATCH v4 0/3] block/diskstats: more accurate io_ticks and optimization
Date: Wed, 25 Mar 2020 08:49:38 -0600 [thread overview]
Message-ID: <0d8e3459-6d67-72ae-c1df-5335d2a49bf7@kernel.dk> (raw)
In-Reply-To: <158514148436.7009.1234367408038809210.stgit@buzz>
On 3/25/20 7:07 AM, Konstantin Khlebnikov wrote:
> Simplified estimation for io_ticks introduced in patch
> https://lore.kernel.org/linux-block/20181206164122.2166-5-snitzer@redhat.com/
> could be very inaccurate for request longer than jiffy (i.e. any HDD)
>
> There is at least one another report about this:
> https://lore.kernel.org/linux-block/20200324031942.GA3060@ming.t460p/
> See detail in comment for first patch.
>
> v1: https://lore.kernel.org/lkml/155413438394.3201.15211440151043943989.stgit@buzz/
> v2: https://lore.kernel.org/lkml/158314549775.1788.6529015932237292177.stgit@buzz/
> v3: https://lore.kernel.org/lkml/158503038812.1955.7827988255138056389.stgit@buzz/
> * update documentation
> * rebase to current linux-next
> * fix compilation for CONFIG_SMP=n
> v4:
> * rebase to for-5.7/block
> * make part_stat_read_all static in block/genhd.c
Applied for 5.7, thanks.
--
Jens Axboe
prev parent reply other threads:[~2020-03-25 14:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 13:07 Konstantin Khlebnikov
2020-03-25 13:07 ` [PATCH v4 1/3] block/diskstats: more accurate approximation of io_ticks for slow disks Konstantin Khlebnikov
2020-03-25 13:07 ` [PATCH v4 2/3] block/diskstats: accumulate all per-cpu counters in one pass Konstantin Khlebnikov
2020-03-25 13:07 ` [PATCH v4 3/3] block/diskstats: replace time_in_queue with sum of request times Konstantin Khlebnikov
2020-03-25 14:49 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d8e3459-6d67-72ae-c1df-5335d2a49bf7@kernel.dk \
--to=axboe@kernel.dk \
--cc=khlebnikov@yandex-team.ru \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=mpatocka@redhat.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®