From: Florian Fainelli <florian.fainelli@broadcom.com>
To: Jim Quinlan <james.quinlan@broadcom.com>,
linux-pci@vger.kernel.org,
Nicolas Saenz Julienne <nsaenz@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
bcm-kernel-feedback-list@broadcom.com, jim2101024@gmail.com
Cc: "Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE"
<linux-rpi-kernel@lists.infradead.org>,
"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] PCI: brcmstb: Enable Broadcom Cable Modem SoCs
Date: Thu, 12 Jun 2025 13:37:47 -0700 [thread overview]
Message-ID: <0d957a78-0eb4-4474-a251-50994e1a88cb@broadcom.com> (raw)
In-Reply-To: <20250609221710.10315-4-james.quinlan@broadcom.com>
On 6/9/25 15:17, Jim Quinlan wrote:
> Broadcom's Cable Modem (CM) group also uses this PCIe driver
> as it shares the PCIe HW core with the STB group.
>
> Make the modifications to enable the CM SoCs.
>
> Signed-off-by: Jim Quinlan <james.quinlan@broadcom.com>
> ---
[snip]
> @@ -1354,7 +1417,10 @@ static int brcm_pcie_start_link(struct brcm_pcie *pcie)
>
> brcm_config_clkreq(pcie);
>
> - if (pcie->ssc) {
> + if (IS_CM_SOC(pcie->cfg->soc_base)) {
> + /* This driver does configure SSC for CM chips */
Nit: does not configure SSC for CM chips. With that fixed:
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
--
Florian
next prev parent reply other threads:[~2025-06-12 20:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-09 22:17 [PATCH 0/3] PCI: brcmstb: Include cable-modem SoCs Jim Quinlan
2025-06-09 22:17 ` [PATCH 1/3] dt bindings: " Jim Quinlan
2025-06-10 15:23 ` Conor Dooley
2025-06-12 20:33 ` Florian Fainelli
2025-06-09 22:17 ` [PATCH 2/3] PCI: brcmstb: Refactor indication of SSC status Jim Quinlan
2025-06-12 20:33 ` Florian Fainelli
2025-06-09 22:17 ` [PATCH 3/3] PCI: brcmstb: Enable Broadcom Cable Modem SoCs Jim Quinlan
2025-06-12 20:37 ` Florian Fainelli [this message]
2025-07-08 7:38 ` Manivannan Sadhasivam
2025-07-10 17:23 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d957a78-0eb4-4474-a251-50994e1a88cb@broadcom.com \
--to=florian.fainelli@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bhelgaas@google.com \
--cc=james.quinlan@broadcom.com \
--cc=jim2101024@gmail.com \
--cc=kwilczynski@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=nsaenz@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®