From: "Arnd Bergmann" <arnd@arndb.de>
To: "Hamza Mahfooz" <hamza.mahfooz@amd.com>,
"Arnd Bergmann" <arnd@kernel.org>,
"Harry Wentland" <harry.wentland@amd.com>,
"Leo Li" <sunpeng.li@amd.com>,
"Rodrigo Siqueira" <Rodrigo.Siqueira@amd.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"Pan, Xinhui" <Xinhui.Pan@amd.com>,
"Dave Airlie" <airlied@gmail.com>,
"Daniel Vetter" <daniel@ffwll.ch>
Cc: "Nicholas Kazlauskas" <nicholas.kazlauskas@amd.com>,
"Taimur Hassan" <Syed.Hassan@amd.com>,
"Jasdeep Dhillon" <jdhillon@amd.com>,
"Alex Hung" <alex.hung@amd.com>,
"Michael Strauss" <michael.strauss@amd.com>,
"Aurabindo Pillai" <aurabindo.pillai@amd.com>,
"Qingqing Zhuo" <qingqing.zhuo@amd.com>,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] drm/amd/display: mark dccg314_init() static
Date: Mon, 17 Apr 2023 23:14:28 +0200 [thread overview]
Message-ID: <0d966637-6074-4d54-a299-41d063e05310@app.fastmail.com> (raw)
In-Reply-To: <de29b7ac-910c-8d4b-50ff-47ba4134d16a@amd.com>
On Mon, Apr 17, 2023, at 23:12, Hamza Mahfooz wrote:
> On 4/17/23 17:05, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> The newly introduced global function is not declared in a header or
>> called from another file, causing a harmless warning with sparse
>> or W=1 builds:
>>
>> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn314/dcn314_dccg.c:277:6: error: no previous prototype for 'dccg314_init' [-Werror=missing-prototypes]
>>
>> Mark it static instead.
>>
>> Fixes: 6f6869dcf415 ("drm/amd/display: prep work for root clock optimization enablement for DCN314")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> This has already been fixed as of commit 669f4ac40947 ("drm/amd/display:
> set variable dccg314_init storage-class-specifier to static") in
> amd-staging-drm-next.
Ok, thanks. I waited for a rebase on today's linux-next before posting
mine to make sure it's not already fixed, it must have just missed the
cut-off.
Arnd
prev parent reply other threads:[~2023-04-17 21:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-17 21:05 Arnd Bergmann
2023-04-17 21:05 ` [PATCH 2/2] drm/amd/display: fix missing=prototypes warnings Arnd Bergmann
2023-04-17 21:17 ` Hamza Mahfooz
2023-04-17 22:10 ` Arnd Bergmann
2023-04-17 21:12 ` [PATCH 1/2] drm/amd/display: mark dccg314_init() static Hamza Mahfooz
2023-04-17 21:14 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d966637-6074-4d54-a299-41d063e05310@app.fastmail.com \
--to=arnd@arndb.de \
--cc=Rodrigo.Siqueira@amd.com \
--cc=Syed.Hassan@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@gmail.com \
--cc=alex.hung@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=arnd@kernel.org \
--cc=aurabindo.pillai@amd.com \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hamza.mahfooz@amd.com \
--cc=harry.wentland@amd.com \
--cc=jdhillon@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.strauss@amd.com \
--cc=nicholas.kazlauskas@amd.com \
--cc=qingqing.zhuo@amd.com \
--cc=sunpeng.li@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®