From: Krzysztof Kozlowski <krzk@kernel.org>
To: Guangshuo Li <lgs201920130244@gmail.com>,
Gregory CLEMENT <gregory.clement@bootlin.com>,
Andi Shyti <andi.shyti@kernel.org>,
Samuel Holland <samuel@sholland.org>,
Wolfram Sang <wsa@kernel.org>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org
Subject: Re: [PATCH] i2c: mv64xxx: fix autosuspend cleanup
Date: Thu, 20 Aug 2026 16:48:30 +0200 [thread overview]
Message-ID: <0d9ba848-bef1-4171-ba1d-edc73e65ac51@kernel.org> (raw)
In-Reply-To: <20260812085808.3313948-1-lgs201920130244@gmail.com>
On 12/08/2026 10:58, Guangshuo Li wrote:
> mv64xxx_i2c_probe() calls pm_runtime_use_autosuspend(), but the probe
> failure and remove paths do not call the matching
> pm_runtime_dont_use_autosuspend() before disabling runtime PM.
>
> If the autosuspend delay is set to a negative value while autosuspend
> is enabled, the runtime PM core increments usage_count to prevent
> runtime suspend. Without undoing the autosuspend setting during
> teardown, this reference is not dropped and usage_count remains
> unbalanced.
>
> Call pm_runtime_dont_use_autosuspend() in both the probe failure and
> remove paths before disabling runtime PM to properly undo the
> autosuspend setting.
>
> This issue was found by manual code inspection.
>
> Fixes: e5c02cf54154 ("i2c: mv64xxx: Add runtime PM support")
> Cc: stable@vger.kernel.org
> Signed-off-by: Guangshuo Li <lgs201920130244@gmail.com>
> ---
> drivers/i2c/busses/i2c-mv64xxx.c | 2 ++
> 1 file changed, 2 insertions(+)
Srsly, one more separate I2C posting, just like you did for dma, crypto,
drm and everywhere else. You seriously waste our time.
You sent vast amount of patches, all separate, making it very difficult
to track and respond in efficient way. Do not do that.
Group your work per subsystem.
You were asked to clarify and respond to incorrect fixes statement. I do
not see how you clarified and responded at all.
Best regards,
Krzysztof
prev parent reply other threads:[~2026-08-20 14:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-12 8:58 Guangshuo Li
2026-08-20 14:48 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d9ba848-bef1-4171-ba1d-edc73e65ac51@kernel.org \
--to=krzk@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=lgs201920130244@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=samuel@sholland.org \
--cc=stable@vger.kernel.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®