From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Yan Yankovskyi <yyankovskyi@gmail.com>, Jan Beulich <jbeulich@suse.com>
Cc: Juergen Gross <jgross@suse.com>,
Stefano Stabellini <sstabellini@kernel.org>,
xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Subject: Re: [Xen-devel] [PATCH v3 1/2] xen: Use evtchn_type_t as a type for event channels
Date: Mon, 23 Mar 2020 09:39:27 -0400 [thread overview]
Message-ID: <0d9d07e1-a828-28f2-b6ec-9d4d5bdc14be@oracle.com> (raw)
In-Reply-To: <20200323053325.GA15004@kbp1-lhp-F74019>
On 3/23/20 1:33 AM, Yan Yankovskyi wrote:
> Make event channel functions pass event channel port using
> evtchn_port_t type. It eliminates signed <-> unsigned conversion.
>
> Signed-off-by: Yan Yankovskyi <yyankovskyi@gmail.com>
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
>
> @@ -1275,7 +1276,7 @@ void rebind_evtchn_irq(int evtchn, int irq)
>
> mutex_unlock(&irq_mapping_update_lock);
>
> - bind_evtchn_to_cpu(evtchn, info->cpu);
> + bind_evtchn_to_cpu(evtchn, info->cpu);
I'd leave this as is.
prev parent reply other threads:[~2020-03-23 13:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-23 5:33 Yan Yankovskyi
2020-03-23 13:39 ` Boris Ostrovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d9d07e1-a828-28f2-b6ec-9d4d5bdc14be@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=jbeulich@suse.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
--cc=yyankovskyi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®