From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753513AbdKXOqW (ORCPT <rfc822;w@1wt.eu>);
        Fri, 24 Nov 2017 09:46:22 -0500
Received: from mail-wm0-f42.google.com ([74.125.82.42]:36955 "EHLO
        mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752693AbdKXOqV (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 24 Nov 2017 09:46:21 -0500
X-Google-Smtp-Source: AGs4zMaO5LW/oL9GqOuqRp4s1Sp3oDK1H6n6eb084CuC5lkLX+eFwGcSDClfrObkmEseb9rSvnIS3g==
Subject: Re: [PATCH v2 4/6] ARM: dts: imx6qdl: Add Variscite DART-MX6 SoM
 support
To: Fabio Estevam <festevam@gmail.com>
Cc: Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <kernel@pengutronix.de>,
        Fabio Estevam <fabio.estevam@nxp.com>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>
References: <1511348560-28505-1-git-send-email-narmstrong@baylibre.com>
 <1511348560-28505-5-git-send-email-narmstrong@baylibre.com>
 <CAOMZO5CuxBsMv1zabi3JtYyX0wNpv1rZZmZG28BBfo9a155siQ@mail.gmail.com>
 <bbbd71e2-eb31-4d43-7dfc-0ef817c5e13e@baylibre.com>
 <CAOMZO5Brey5G=SM0A143=srmWnLstHaSMrPx-PO5PQc4KtBtBA@mail.gmail.com>
From: Neil Armstrong <narmstrong@baylibre.com>
Organization: Baylibre
Message-ID: <0d9fe511-392d-74a5-3e65-ef7edd7b8d9b@baylibre.com>
Date: Fri, 24 Nov 2017 15:46:18 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <CAOMZO5Brey5G=SM0A143=srmWnLstHaSMrPx-PO5PQc4KtBtBA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 24/11/2017 15:44, Fabio Estevam wrote:
> Hi Neil,
> 
> On Fri, Nov 24, 2017 at 12:41 PM, Neil Armstrong
> <narmstrong@baylibre.com> wrote:
> 
>>>> +&hdmi {
>>>
>>> No ddc-i2c-bus property?
>>
>> It's in the board dts.
> 
> Yes, I saw it while reviewing the other patch.
> 
> Do different boards use different I2C ports for the HDMI EDID?
> 
> If not, then you could probably put it here instead.

Not at my knowledge, but it's typically something routed on the carrier board.

Anyway I can set it here.

> 
>>>> +&pcie {
>>>> +       fsl,tx-swing-full = <103>;
>>>> +       fsl,tx-swing-low = <103>;
>>>> +       status = "disabled";
>>>
>>> No 'reset-gpio' property?
>>>
>>
>> It will be in the board dts.
> 
> Same here.
> 

Ok.

Neil