From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE076231C91 for ; Mon, 9 Feb 2026 10:02:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770631327; cv=none; b=eBHJzAGh6X4STHpB/m+bYDB82NHcDviUwut5+KgenT2TT6TLGrWUCebZqhdsyjxShZXXW08Q1Nv0TdmFYWL3z7pOJEynDrBvnYtjOKisEYUIRIVb/mqBThojXxk79ie+6AKtPNIXtAt9RzRcPsgEjY83LX8ausgK2KFxMexnhWI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770631327; c=relaxed/simple; bh=4I8Rj4xdRSi6MgOmKDp0OJvfaSV82CLZozlzfRNZGMk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CcI2RzhdvIUZeGEBXHPXTCL+i5iNQSvWTGeXZKCl4TonbrOhO+Z5rgYHPZxMtGQy4h46xklEvKHnm0WusLaFBwQi1VZyc2s92xdvtx3D6LMHm3fdeyrgcR2fNmyqSW1TJbt+8QG5ixohmoWKigEQlhjbsjuP/wZeQGVEmhpb8ds= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=U3JLx8im; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=kgPlTu0k; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="U3JLx8im"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="kgPlTu0k" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6195S0TI3252267 for ; Mon, 9 Feb 2026 10:02:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Yb2anyFFGxIZHNV3t37BBz09EsQwC/cS6s/T5HaX8CU=; b=U3JLx8im9dp4Riuo lT9No2Emd19Dg4kO3o8wDO8Zkrsp5VehRcKcufbh/jwcEHySTnV3wsT6vZihtUtP 4KJ7Lz2IvfKEpb2RNOx8Dt9AIap9yyGjfPjdIqe5uh8ujgzJlM0FKAifK5HMM8L+ hSr2a1+B54Qhhbx5hTU1xumnyKDnlMWpm1lew4CQdZ5dYN1tJUpvsWIrOUFK0YOx 9gV2qoJ/WAElAv66TYzEroHWSvL+ocWZ62tprs25MruyPij2bIWTNg4+b2QntPd/ jtU7TPMLm4MaWgw1INQ1RPBIiQvWJ2O+HKpcCmcNGL9H2jsZMvnEUpYvZpP/tZZZ d+iRLw== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c79f68xrg-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 09 Feb 2026 10:02:06 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8c6a182d4e1so62124185a.0 for ; Mon, 09 Feb 2026 02:02:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770631326; x=1771236126; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Yb2anyFFGxIZHNV3t37BBz09EsQwC/cS6s/T5HaX8CU=; b=kgPlTu0kl+t/+2S/KtrKfQQJcLXm2504C36zfRuda21JLZTTwmwAaqwJkQES18AT/T 2tRidOyALMK6SZn11mzSh8azT21glXHLbIh4dBshKOOWys29FXuqtAk992D45ec3VIzU a0kj5bKQ0VJVIDhjYr0EFJI0BQw1V8oom4dLWrF42oEex8nJ155RX8IzG2999SE57sHZ gYVtND21ewqpPka6oHr3IG8q6w1IUzes8An4Z3Tu9woQ/hVuUVq7SbWJmS4cwHP7+CcY ZaUqtFeW5VckGYsjaEi/pmtmaFQWWWiZPTcbM5hC8aXU5jtQl4/oAt13C6jXFQdHFXCx iu6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770631326; x=1771236126; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Yb2anyFFGxIZHNV3t37BBz09EsQwC/cS6s/T5HaX8CU=; b=N0zrmtTz83WDnljWOteIit83xlNJRzGxGc5uIiHV1ARrkh1wqD+aUnhgYjfxN+wud1 XXAvAZXfj1r8P3g0nbVW1nqxpiRxmzs1RQ1LQ1Ltfae3L2uxIoE6oZVuKmWJGP4PPdAC cyZQ79xSReF+CcQJhjewN9/8BVFeMcICTHIvtqs7H8bPncRfkhoRq3CD4KmtdLU2Ngtx ZYRYfq/JyxQyXqOGEn060GZCRJXVk65HYYs8gCqUu7+Kdgi/OIIG52B2wIWn2oG+jRuT Syb36wIQppVa+js69OCC3rKW6Nlb9x0V96AjD1dVBCRp7HJwkS63qhiriWvf8fjmPRs9 kJDw== X-Forwarded-Encrypted: i=1; AJvYcCWi6UOaYw7PFAc6vokxOhP7oIQtM0rqjAHPhw8uS9ujvnPFmW6d2E3yMywilI3FlcnOZ4OBCtRFna865WI=@vger.kernel.org X-Gm-Message-State: AOJu0YxTHZsfvEG+DGyi30rfqCTwfmarou2hfmxqFpB+T0gOEYNyft7P PkazE1Gn6SVmipSRbnDPOT7BdN070ADSw4xpS7fGotY6FuFdz8g/jKXuEm3qmlKCiVlfvFUggvo Krtg9HiYXyw7Te0x5WmiaDx9n7ZEvHKKZi3+z3tSRV6NDZoynbZKhN4U/Bbd2E40QZwM= X-Gm-Gg: AZuq6aLdqfrZlDOKPhHfgiEHUlhvDXAQK1AwUxQSVj/DzqAm/STb6tzXjKuikF3SYWg pw/EQJhUescPbxExzxsvuaDog13eficdhSV/6bPoNb5wAJSqU6qt1lBSAp7wPlYpWNbSbjG/Cux UBoIx33P0WIyrnMTZOtlXn3m1bBy4uC8cCDM5SALDEQP7ewHHPPF220Lua5LRiZ+oju8XteuOVe a7D7s/aWLzZM6DvMYZC8ZUPbhyRY/q9D0Suh24u3W2+EbIDCBAHfugXPO/3uTYRmZt1YfxlF51l SC3p/4Dskl+m2FqBSXuSjAphRLV7VCQUJIwmQ/SKnVPcC8lAj/pmyU8eYUoG6mF0jR1yQXd8TY+ hjRv2wVzsEzfYcHKYNnKGpDkz+wPHPL7wYrZp4S5MenH6QQ0zB7rw72Jt9+CUL/cWyIQ= X-Received: by 2002:a05:620a:4110:b0:8c5:305e:ea16 with SMTP id af79cd13be357-8caf0d3d550mr1074441885a.8.1770631325935; Mon, 09 Feb 2026 02:02:05 -0800 (PST) X-Received: by 2002:a05:620a:4110:b0:8c5:305e:ea16 with SMTP id af79cd13be357-8caf0d3d550mr1074440185a.8.1770631325520; Mon, 09 Feb 2026 02:02:05 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8edacb1d3fsm358203266b.34.2026.02.09.02.02.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Feb 2026 02:02:04 -0800 (PST) Message-ID: <0da582a6-5bba-4450-99ec-cf57b67915e6@oss.qualcomm.com> Date: Mon, 9 Feb 2026 11:02:01 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] media: iris: Enable Gen2 HFI on SC7280 To: Dikshita Agarwal , Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260209-iris_sc7280_gen2_support-v1-0-390000a4fa39@oss.qualcomm.com> <20260209-iris_sc7280_gen2_support-v1-2-390000a4fa39@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260209-iris_sc7280_gen2_support-v1-2-390000a4fa39@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: df3bmkQgdb3r4Yl1jlGmT85Dcf59ID7o X-Proofpoint-ORIG-GUID: df3bmkQgdb3r4Yl1jlGmT85Dcf59ID7o X-Authority-Analysis: v=2.4 cv=W581lBWk c=1 sm=1 tr=0 ts=6989b09f cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=EUspDBNiAAAA:8 a=5I6DSIVO9Q-7lEmBOwwA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjA5MDA4MyBTYWx0ZWRfX+iO/GjYzwn9s L27uHkhet14XGHolFStw6n+CQc5oxymP/B+qIR4n2E9IWHVFGs5zrc2fFU3IqSmDwmxQhfaNGRV Vg11vJOVTVyiqlXn6kKi2Pkusf7RtMOa6CPKt0wOryIGjA1NRhcb4Lh9JKjrliVhZIWQrhQeemU ejmay8hNjmLSklc02TVqB0iuWHYWwmRPe8XsSR+CRf/UAzOWIgAVrZqmG30xin14x6xeiESQcIK mCliG+hh+svjUkUbrE3M5dH8T9k5Wdp8rhXBbV8x9fEbTHOa+LDnCD9mw0glih/eXxiNWrpGHCi Y/8UImUNf1G9brZM649dW9RTS+EZseJxhHmgGNCe2zU8z/BkhtD6JmIhicyIAQLfy+lxwyuvCJT cPqENUbzDCIkcbKYM78WgEhCc7OF4PuJm6ghXBvVfqgSMkZdV/jTUdEkvy7h/3teiIfz0HMVB81 z8qqzdrNsjFJiK7kypg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-08_05,2026-02-09_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 bulkscore=0 lowpriorityscore=0 phishscore=0 impostorscore=0 adultscore=0 malwarescore=0 clxscore=1015 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602090083 On 2/9/26 10:45 AM, Dikshita Agarwal wrote: > SC7280 supports both Gen1 and Gen2 HFI firmware. The driver continues to > use Gen1 by default, but boards that intend to use Gen2 firmware can > opt‑in by specifying a Gen2 image through the Device Tree > 'firmware-name' property. > > Based on this property and the availability of the referenced > firmware binary, the driver selects the appropriate HFI generation and > updates its platform data accordingly. Boards that do not > specify a Gen2 firmware, or where the firmware is not present, > automatically fall back to Gen1. > > Signed-off-by: Dikshita Agarwal > --- [...] > +int iris_update_platform_data(struct iris_core *core) > +{ > + const char *fwname = NULL; > + const struct firmware *fw; > + int ret; > + > + if (of_device_is_compatible(core->dev->of_node, "qcom,sc7280-venus")) { > + ret = of_property_read_string_index(core->dev->of_node, "firmware-name", 0, > + &fwname); > + if (ret) > + return 0; > + > + if (strstr(fwname, "gen2")) { > + ret = request_firmware(&fw, fwname, core->dev); > + if (ret) { > + dev_err(core->dev, "Specified firmware is not present\n"); > + return ret; This is fragile - if someone names names their gen1 firmware something like "myproduct_gen2_vidfw.mbn", it's going to match.. Could we instead do something like the explicit format checks in venus/hfi_msgs.c : sys_get_prop_image_version(), based on the **contents** of the binary? Konrad