From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.ilvokhin.com (mail.ilvokhin.com [178.62.254.231]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9890C3D0915 for ; Wed, 8 Apr 2026 13:33:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.62.254.231 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775655231; cv=none; b=PQWJ60x2VFvWVenorQ40lab+DOOKJ8sCrImQFqMWiYuxsl0xX8eqZzZQG+s6R6Vm6UPWt34cdIwyRLVl9Y8S9ZOCGjolF6/oYsAGxFj3rUoh9YlR5T1a4RC9babSQ0lB2tg8oFT32kXzc3BNfwuKRrnNkmzNzsyXU+hhN7zs0bE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775655231; c=relaxed/simple; bh=+1p1TxuwHOE3Ysv1F5HtSBzdCmr5mDn0Y72mGPWBS/o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fRkLui5E7K6x6nHCxJlCdo18p8wMSPXeKj2Pwmxp3S5eox/Sln4J4xQICqi3mFPkwkf8GiADr+W9uvebW/Ug1iNbvQZGbLyiCU6DIUX/mWQDsK4R8HwjSzcaxlwTLFRliyBccPYGgXI7EUV9BpvXMIvofO2cCXPYOWL+MwTBWjg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=ilvokhin.com; spf=pass smtp.mailfrom=ilvokhin.com; dkim=pass (1024-bit key) header.d=ilvokhin.com header.i=@ilvokhin.com header.b=bhtlSTwf; arc=none smtp.client-ip=178.62.254.231 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=ilvokhin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ilvokhin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ilvokhin.com header.i=@ilvokhin.com header.b="bhtlSTwf" Received: from localhost.localdomain (shell.ilvokhin.com [138.68.190.75]) (Authenticated sender: d@ilvokhin.com) by mail.ilvokhin.com (Postfix) with ESMTPSA id 9AC46BE727; Wed, 08 Apr 2026 13:33:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ilvokhin.com; s=mail; t=1775655220; bh=nf+JuPEE/jp8A+2PdYP2O6YgayTSpGEteEGx3VKZEwM=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=bhtlSTwflFyzIun/pkj53UHMDknnPfyBwaNmJiJdop/TjpXEBE47MclZwzdhTxbrn kX3SRbMi/dWR6jXgz8zlaWNT8y2hN8fANknXtgLvypFaiWel8Of/YBaT/aioCaU57f ly8rOQKQsKo5nA2Te4SI6Q/ESxwJBcUEBU8iwpVc= From: Dmitry Ilvokhin To: Andrew Morton , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , Zi Yan Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@meta.com, Dmitry Ilvokhin , Steven Rostedt Subject: [RESEND PATCH v2 8/8] mm: use zone lock guard in __offline_isolated_pages() Date: Wed, 8 Apr 2026 13:33:23 +0000 Message-ID: <0da769d4078fccbde4182a5ee655ea673ccbd5a9.1775654118.git.d@ilvokhin.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Use spinlock_irqsave zone lock guard in __offline_isolated_pages() to replace the explicit lock/unlock pattern with automatic scope-based cleanup. Suggested-by: Steven Rostedt Signed-off-by: Dmitry Ilvokhin --- mm/page_alloc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 6a7c548a7406..bda0282bcb03 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -7396,7 +7396,7 @@ void zone_pcp_reset(struct zone *zone) unsigned long __offline_isolated_pages(unsigned long start_pfn, unsigned long end_pfn) { - unsigned long already_offline = 0, flags; + unsigned long already_offline = 0; unsigned long pfn = start_pfn; struct page *page; struct zone *zone; @@ -7404,7 +7404,7 @@ unsigned long __offline_isolated_pages(unsigned long start_pfn, offline_mem_sections(pfn, end_pfn); zone = page_zone(pfn_to_page(pfn)); - spin_lock_irqsave(&zone->lock, flags); + guard(spinlock_irqsave)(&zone->lock); while (pfn < end_pfn) { page = pfn_to_page(pfn); /* @@ -7434,7 +7434,6 @@ unsigned long __offline_isolated_pages(unsigned long start_pfn, del_page_from_free_list(page, zone, order, MIGRATE_ISOLATE); pfn += (1 << order); } - spin_unlock_irqrestore(&zone->lock, flags); return end_pfn - start_pfn - already_offline; } -- 2.52.0