From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93C42EB64D7 for ; Wed, 21 Jun 2023 09:15:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230487AbjFUJPg convert rfc822-to-8bit (ORCPT ); Wed, 21 Jun 2023 05:15:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50362 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230511AbjFUJPU (ORCPT ); Wed, 21 Jun 2023 05:15:20 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 094551B4 for ; Wed, 21 Jun 2023 02:15:15 -0700 (PDT) Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[IPv6:::1]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qBtvb-00039C-3d; Wed, 21 Jun 2023 11:15:03 +0200 Message-ID: <0daa7182d6600a24988d1c81cf8fe3c0c9487f52.camel@pengutronix.de> Subject: Re: [PATCH v10 03/11] drm/etnaviv: Add dedicated functions to create and destroy platform device From: Lucas Stach To: Sui Jingfeng <18949883232@163.com>, Russell King , Christian Gmeiner , David Airlie , Daniel Vetter Cc: Sui Jingfeng , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, etnaviv@lists.freedesktop.org, Philipp Zabel , Bjorn Helgaas Date: Wed, 21 Jun 2023 11:15:00 +0200 In-Reply-To: <20230620094716.2231414-4-18949883232@163.com> References: <20230620094716.2231414-1-18949883232@163.com> <20230620094716.2231414-4-18949883232@163.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:900:1d::77 X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Dienstag, dem 20.06.2023 um 17:47 +0800 schrieb Sui Jingfeng: > From: Sui Jingfeng > > Also rename the virtual master platform device as etnaviv_platform_device, > for better reflection that it is a platform device, not a DRM device. > > Another benefit is that we no longer need to call of_node_put() for three > different cases, Instead, we only need to call it once. > > Cc: Lucas Stach > Cc: Christian Gmeiner > Cc: Philipp Zabel > Cc: Bjorn Helgaas > Cc: Daniel Vetter > Signed-off-by: Sui Jingfeng > --- > drivers/gpu/drm/etnaviv/etnaviv_drv.c | 56 +++++++++++++++++++-------- > 1 file changed, 39 insertions(+), 17 deletions(-) > > diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.c b/drivers/gpu/drm/etnaviv/etnaviv_drv.c > index 31a7f59ccb49..cec005035d0e 100644 > --- a/drivers/gpu/drm/etnaviv/etnaviv_drv.c > +++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.c > @@ -656,12 +656,44 @@ static struct platform_driver etnaviv_platform_driver = { > }, > }; > > -static struct platform_device *etnaviv_drm; > +static struct platform_device *etnaviv_platform_device; > > -static int __init etnaviv_init(void) > +static int etnaviv_create_platform_device(const char *name, > + struct platform_device **ppdev) As the platform device is a global static variable, there is no need to push it through the parameters of this function. Just use the global variable directly in this function. > { > struct platform_device *pdev; > int ret; > + > + pdev = platform_device_alloc(name, PLATFORM_DEVID_NONE); > + if (!pdev) > + return -ENOMEM; > + > + ret = platform_device_add(pdev); > + if (ret) { > + platform_device_put(pdev); > + return ret; > + } > + > + *ppdev = pdev; > + > + return 0; > +} > + > +static void etnaviv_destroy_platform_device(struct platform_device **ppdev) > +{ > + struct platform_device *pdev = *ppdev; Same here, just use the global variable directly. Regards, Lucas > + > + if (!pdev) > + return; > + > + platform_device_unregister(pdev); > + > + *ppdev = NULL; > +} > + > +static int __init etnaviv_init(void) > +{ > + int ret; > struct device_node *np; > > etnaviv_validate_init(); > @@ -681,23 +713,13 @@ static int __init etnaviv_init(void) > for_each_compatible_node(np, NULL, "vivante,gc") { > if (!of_device_is_available(np)) > continue; > + of_node_put(np); > > - pdev = platform_device_alloc("etnaviv", PLATFORM_DEVID_NONE); > - if (!pdev) { > - ret = -ENOMEM; > - of_node_put(np); > - goto unregister_platform_driver; > - } > - > - ret = platform_device_add(pdev); > - if (ret) { > - platform_device_put(pdev); > - of_node_put(np); > + ret = etnaviv_create_platform_device("etnaviv", > + &etnaviv_platform_device); > + if (ret) > goto unregister_platform_driver; > - } > > - etnaviv_drm = pdev; > - of_node_put(np); > break; > } > > @@ -713,7 +735,7 @@ module_init(etnaviv_init); > > static void __exit etnaviv_exit(void) > { > - platform_device_unregister(etnaviv_drm); > + etnaviv_destroy_platform_device(&etnaviv_platform_device); > platform_driver_unregister(&etnaviv_platform_driver); > platform_driver_unregister(&etnaviv_gpu_driver); > }