From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751857AbdHAQcr (ORCPT ); Tue, 1 Aug 2017 12:32:47 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:35506 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751599AbdHAQcp (ORCPT ); Tue, 1 Aug 2017 12:32:45 -0400 Subject: Re: [PATCH net-next] net: bcmgenet: drop COMPILE_TEST dependency To: Arnd Bergmann , "David S. Miller" Cc: Michael Chan , Sathya Perla , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20170801115121.1246540-1-arnd@arndb.de> From: Florian Fainelli Message-ID: <0db350e1-1df5-5a3a-095e-183db15d09a0@gmail.com> Date: Tue, 1 Aug 2017 09:32:38 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170801115121.1246540-1-arnd@arndb.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/01/2017 04:50 AM, Arnd Bergmann wrote: > The last patch added the dependency on 'OF && HAS_IOMEM' but left > COMPILE_TEST as an alternative, which kind of defeats the purpose > of adding the dependency, we still get randconfig build warnings: > > warning: (NET_DSA_BCM_SF2 && BCMGENET) selects MDIO_BCM_UNIMAC which has unmet direct dependencies (NETDEVICES && MDIO_BUS && HAS_IOMEM && OF_MDIO) > > For compile-testing purposes, we don't really need this anyway, > as CONFIG_OF can be enabled on all architectures, and HAS_IOMEM > is present on all architectures we do meaningful compile-testing on > (the exception being arch/um). > > This makes both OF and HAS_IOMEM hard dependencies. > > Fixes: 5af74bb4fcf8 ("net: bcmgenet: Add dependency on HAS_IOMEM && OF") > Signed-off-by: Arnd Bergmann Reviewed-by: Florian Fainelli Thanks! -- Florian