mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yang Jihong <yangjihong1@huawei.com>
To: Ian Rogers <irogers@google.com>
Cc: <peterz@infradead.org>, <mingo@redhat.com>, <acme@kernel.org>,
	<mark.rutland@arm.com>, <alexander.shishkin@linux.intel.com>,
	<jolsa@kernel.org>, <namhyung@kernel.org>,
	<adrian.hunter@intel.com>, <kan.liang@linux.intel.com>,
	<james.clark@arm.com>, <tmricht@linux.ibm.com>,
	<ak@linux.intel.com>, <anshuman.khandual@arm.com>,
	<linux-kernel@vger.kernel.org>,
	<linux-perf-users@vger.kernel.org>
Subject: Re: [PATCH v6 5/7] perf test: Update base-record & system-wide-dummy attr expected values for test-record-C0
Date: Fri, 25 Aug 2023 14:09:14 +0800	[thread overview]
Message-ID: <0dbca9a3-f377-cd46-b1c4-e0742a94fbb5@huawei.com> (raw)
In-Reply-To: <CAP-5=fWK=vd4H6_SHpDw4rMN4eODSM5hmBY=rJ5F9fQMq-HcUg@mail.gmail.com>

Hello,

On 2023/8/25 13:22, Ian Rogers wrote:
> On Sun, Aug 20, 2023 at 6:30 PM Yang Jihong <yangjihong1@huawei.com> wrote:
>>
>> 1. Because a dummy sideband event is added to the sampling of specified
>>     CPUs. When evlist contains evsel of different sample_type,
>>     evlist__config() will change the default PERF_SAMPLE_ID bit to
>>     PERF_SAMPLE_IDENTIFICATION bit.
>>     The attr sample_type expected value of base-record and system-wide-dummy
>>     in test-record-C0 needs to be updated.
>>
>> 2. The perf record uses evlist__add_aux_dummy() instead of
>>     evlist__add_dummy() to add a dummy event.
>>     The expected value of system-wide-dummy attr needs to be updated.
>>
>> The perf test result is as follows:
>>
>>    # ./perf test list  2>&1 | grep 'Setup struct perf_event_attr'
>>     17: Setup struct perf_event_attr
>>    # ./perf test 17
>>     17: Setup struct perf_event_attr                                    : Ok
> 
> Will the kernel test robot complain about the previous patches
> breaking this test? It may be best to update the test while changing
> the behavior in those patches.
> 
Okay, it'll be modified in the next version.

Thanks,
Yang

  reply	other threads:[~2023-08-25  6:10 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-21  1:27 [PATCH v6 0/7] perf record: Track sideband events for all CPUs when tracing selected CPUs Yang Jihong
2023-08-21  1:27 ` [PATCH v6 1/7] perf evlist: Add perf_evlist__go_system_wide() helper Yang Jihong
2023-08-25  4:51   ` Ian Rogers
2023-08-25  5:41     ` Yang Jihong
     [not found]       ` <CAP-5=fUtCHXDC5zOML4po8k1rQVPo9ybsTA8_AihepP6w8B5Kw@mail.gmail.com>
2023-08-25  6:15         ` Yang Jihong
2023-08-25  6:28         ` Yang Jihong
2023-08-21  1:27 ` [PATCH v6 2/7] perf evlist: Add evlist__findnew_tracking_event() helper Yang Jihong
2023-08-25  4:55   ` Ian Rogers
2023-08-25  5:58     ` Yang Jihong
2023-08-21  1:27 ` [PATCH v6 3/7] perf record: Move setting dummy tracking before record__init_thread_masks() Yang Jihong
2023-08-25  5:10   ` Ian Rogers
2023-08-25  6:05     ` Yang Jihong
2023-08-21  1:27 ` [PATCH v6 4/7] perf record: Track sideband events for all CPUs when tracing selected CPUs Yang Jihong
2023-08-25  5:17   ` Ian Rogers
2023-08-25  6:07     ` Yang Jihong
2023-08-25  6:13     ` Adrian Hunter
2023-08-21  1:27 ` [PATCH v6 5/7] perf test: Update base-record & system-wide-dummy attr expected values for test-record-C0 Yang Jihong
2023-08-25  5:22   ` Ian Rogers
2023-08-25  6:09     ` Yang Jihong [this message]
2023-08-21  1:27 ` [PATCH v6 6/7] perf test: Add test case for record sideband events Yang Jihong
2023-08-25  5:28   ` Ian Rogers
2023-08-25  6:12     ` Yang Jihong
2023-08-21  1:27 ` [PATCH v6 7/7] perf test: Add perf_event_attr test for record selected CPUs exclude_user Yang Jihong
2023-08-25  5:25   ` Ian Rogers
2023-08-23  1:17 ` [PATCH v6 0/7] perf record: Track sideband events for all CPUs when tracing selected CPUs Yang Jihong
2023-08-23 11:35   ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0dbca9a3-f377-cd46-b1c4-e0742a94fbb5@huawei.com \
    --to=yangjihong1@huawei.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=anshuman.khandual@arm.com \
    --cc=irogers@google.com \
    --cc=james.clark@arm.com \
    --cc=jolsa@kernel.org \
    --cc=kan.liang@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tmricht@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®