From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1163178AbdAFWsA (ORCPT ); Fri, 6 Jan 2017 17:48:00 -0500 Received: from mail-pg0-f68.google.com ([74.125.83.68]:32938 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S939962AbdAFWrl (ORCPT ); Fri, 6 Jan 2017 17:47:41 -0500 Subject: Re: [PATCH net-next 1/2] net: dsa: make "label" property optional for dsa2 To: Andrew Lunn , Vivien Didelot References: <20170106220043.21280-1-vivien.didelot@savoirfairelinux.com> <20170106220043.21280-2-vivien.didelot@savoirfairelinux.com> <20170106222008.GC10626@lunn.ch> Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= From: Florian Fainelli Message-ID: <0dbf9730-2409-30f9-e9e4-946fe7fec413@gmail.com> Date: Fri, 6 Jan 2017 14:47:38 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170106222008.GC10626@lunn.ch> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/06/2017 02:20 PM, Andrew Lunn wrote: >> If one wants to rename an interface, udev rules can be used as usual. > > Hi Vivien > > Do you have some examples? > > A quick look at udevadm info suggests we can use > > ATTR{phys_port_id} and ATTR{phys_switch_id} > > Humm, it would be nice to know why the second switch has a > phys_switch_id of 01000000. Well, that's a combination of being on a little endian system and using %*phN as a printk formatter, and the type being 32-bit long (int). I agree this does not feel natural, but since this is sysfs (so ABI in a way), it's going to be though to change now. -- Florian