From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from canpmsgout05.his.huawei.com (canpmsgout05.his.huawei.com [113.46.200.220]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1008A3BA239 for ; Tue, 10 Mar 2026 03:36:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=113.46.200.220 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773113796; cv=none; b=VCNKj2uwD+gzFadBbCTZGqQAWzYZvQVZ+ciDYTC/XyufSqxitbw34SDxzJarHTRNh7B1aZOsbO8/Xfyzb8s0G09F5ORO1dDP94V9ELpkoDZHRQMqET0wuYohMHJcFjMSoOa4BAqg5etMUqx06F9xSQNqiBKIOJx8XqNgrbkD9VQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773113796; c=relaxed/simple; bh=tNwGk5tT1DXQ4Nvtat+Jpg6C9F5oDUbanWX5u/thi5o=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=UbnMeBuc95iNG0XhYblvs+a+eAzZXpZIyLxniEVmBZlH+McDCmxCHPBHWrTqWPyVRk7IuWu81NQBe/ReRwuL533cGulAU2y0xEfoulj1MMOT8weH1LrYXxJfl+tfAnwz9hElXv0ijd4J/x1kSxhiby6TKXdwfiLWHAYWj3c+YqE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b=u/Y5l5+N; arc=none smtp.client-ip=113.46.200.220 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=huawei.com header.i=@huawei.com header.b="u/Y5l5+N" dkim-signature: v=1; a=rsa-sha256; d=huawei.com; s=dkim; c=relaxed/relaxed; q=dns/txt; h=From; bh=ot5C4phsn/D5HCjzZ0Ig3HqX6b1yZe2wL22xhQfLHmg=; b=u/Y5l5+N4i469pymJs6TizNMRhaXRY3XQYDkxsFl8M0qt2iPo/czlg6L4roHgwf6Ip1oXoqm1 ascKg5gs8YVj2fROA1QIFoKpqalvRjzL7LS7HXslvZjro8o1K1ud6Vkerhap9qLy7VjeW+0w97x UGB+091hZnHHBRVLz06b+qk= Received: from mail.maildlp.com (unknown [172.19.162.144]) by canpmsgout05.his.huawei.com (SkyGuard) with ESMTPS id 4fVKCg5mZDz12LCw; Tue, 10 Mar 2026 11:30:55 +0800 (CST) Received: from kwepemr500001.china.huawei.com (unknown [7.202.194.229]) by mail.maildlp.com (Postfix) with ESMTPS id F058D40538; Tue, 10 Mar 2026 11:36:31 +0800 (CST) Received: from [10.174.179.248] (10.174.179.248) by kwepemr500001.china.huawei.com (7.202.194.229) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Tue, 10 Mar 2026 11:36:29 +0800 Message-ID: <0dc36f64-3e6c-4e4b-bdd1-6e364babb0bc@huawei.com> Date: Tue, 10 Mar 2026 11:36:29 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC v3 2/4] mm/pgtable: Make pfn_pte() filter out huge page attributes To: Matthew Wilcox CC: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Kefeng Wang , References: <20260228070906.1418911-1-yintirui@huawei.com> <20260228070906.1418911-3-yintirui@huawei.com> <5eaf3846-01db-471e-9903-b0b239d7838d@suse.com> From: Yin Tirui In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: kwepems100001.china.huawei.com (7.221.188.238) To kwepemr500001.china.huawei.com (7.202.194.229) On 3/6/2026 12:25 PM, Matthew Wilcox wrote: > > I don't think we should have pgprot_large_2_4k(). Or rather, I think it > should be embedded in pmd_pgprot() / pud_pgprot(). That is, we should > have an 'ideal' pgprot which, on x86, perhaps matches that used by the > 4k level. pfn_pmd() should be converting from the ideal pgprot to > that actually used by PMDs (and setting _PAGE_PSE?) > Hi Willy, I will take this route and implement the embedded approach for the v4 respin. -- Yin Tirui