From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B2456331EA8 for ; Thu, 13 Aug 2026 07:06:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786604780; cv=none; b=DCCfo3r/8z61hQ/QpwESgXOyFyCwoX2pPWdMcESuaWEfVzN85mLlav0+vEL+zond94MuHzkJKYVSdhEPZBC3N2OlnB752ZwYmkrsknFELFRgCCd4Vf2BZgbGpksuMQT6q2/aufvSSYXrbqkZh6CLfySOkegjWAVU49jflmR9E/I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786604780; c=relaxed/simple; bh=BXbmiXIi3Po+SDS21XU5N2QqMfNRv65Dzxm2LFPR81Q=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=q+vQsYkOMWGCE9Dt6unCIMS0AqArtwMw3PBPQV+QXOAC6n/YWf7FOGwVsuWse1XtB9sLydvE+x9AdH7Wf3kgYY0ZYJNiVg8wmcOUn1B/Vh1vpFnAWkmLXLAwAq+ZLbe2dQSjHtbhfRkx6ZCZfWkQsBz+3n+CZ6O+n5buM6DxNN8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=endUKs5k; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="endUKs5k" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 159E41F000E9; Thu, 13 Aug 2026 07:06:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786604777; bh=67bSBr6S3Rgqwv7q/F8MVWiesuWl93Cam+1apB+ncFA=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=endUKs5kXevNRELkHoZkzmtlfWQQNl3PqQkvzJrznXiyhJSn4RbBqYEKJUoJBFr96 NtgtWPkL993Kd6o3A+m1qpZcY9HA/BWTdAJaxyQjfnNRrnnSZj6fODT2Q+RKHNaaHy 73JLhHhs2TTqp5M2+suj9b1Q7B2VeEjzHy/TKMBrfXoIhY//VG4sL0UO2aEs4mqq7k Ix/zb2BvQ41FclTsBLCBcB5UPS11m8Y+O1T7D+LQg6bZAJF7VvEJL8Ao0z8DSqAaDr 4IE6GcrTekiVt1gwuwciH4+XI0DG2cZBVoJ1ysOr/QxCdXwwgycVyDURxdtWp139ac /svtBBFKC98eQ== Message-ID: <0dc4a8da-b2e1-4eaf-bea7-070b38d6952c@kernel.org> Date: Thu, 13 Aug 2026 09:06:07 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/Kconfig: allow user to select MIGRATION if MEMORY_FAILURE is enabled To: Xie Yuanbin , rppt@kernel.org, ljs@kernel.org Cc: akpm@linux-foundation.org, apopple@nvidia.com, bp@alien8.de, byungchul@sk.com, gourry@gourry.net, joshua.hahnjy@gmail.com, liam@infradead.org, liaohua4@huawei.com, lilinjie8@huawei.com, linmiaohe@huawei.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, matthew.brost@intel.com, mhocko@suse.com, nao.horiguchi@gmail.com, rakie.kim@sk.com, surenb@google.com, tony.luck@intel.com, vbabka@kernel.org, ying.huang@linux.alibaba.com, ziy@nvidia.com References: <20260813022616.9050-1-xieyuanbin1@huawei.com> From: "David Hildenbrand (Arm)" Content-Language: en-US Autocrypt: addr=david@kernel.org; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzS5EYXZpZCBIaWxk ZW5icmFuZCAoQ3VycmVudCkgPGRhdmlkQGtlcm5lbC5vcmc+wsGQBBMBCAA6AhsDBQkmWAik AgsJBBUKCQgCFgICHgUCF4AWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaYJt/AIZAQAKCRBN 3hD3AP+DWriiD/9BLGEKG+N8L2AXhikJg6YmXom9ytRwPqDgpHpVg2xdhopoWdMRXjzOrIKD g4LSnFaKneQD0hZhoArEeamG5tyo32xoRsPwkbpIzL0OKSZ8G6mVbFGpjmyDLQCAxteXCLXz ZI0VbsuJKelYnKcXWOIndOrNRvE5eoOfTt2XfBnAapxMYY2IsV+qaUXlO63GgfIOg8RBaj7x 3NxkI3rV0SHhI4GU9K6jCvGghxeS1QX6L/XI9mfAYaIwGy5B68kF26piAVYv/QZDEVIpo3t7 /fjSpxKT8plJH6rhhR0epy8dWRHk3qT5tk2P85twasdloWtkMZ7FsCJRKWscm1BLpsDn6EQ4 jeMHECiY9kGKKi8dQpv3FRyo2QApZ49NNDbwcR0ZndK0XFo15iH708H5Qja/8TuXCwnPWAcJ DQoNIDFyaxe26Rx3ZwUkRALa3iPcVjE0//TrQ4KnFf+lMBSrS33xDDBfevW9+Dk6IISmDH1R HFq2jpkN+FX/PE8eVhV68B2DsAPZ5rUwyCKUXPTJ/irrCCmAAb5Jpv11S7hUSpqtM/6oVESC 3z/7CzrVtRODzLtNgV4r5EI+wAv/3PgJLlMwgJM90Fb3CB2IgbxhjvmB1WNdvXACVydx55V7 LPPKodSTF29rlnQAf9HLgCphuuSrrPn5VQDaYZl4N/7zc2wcWM7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <20260813022616.9050-1-xieyuanbin1@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 8/13/26 04:26, Xie Yuanbin wrote: > On Wed, 12 Aug 2026 13:45:30 +0300, Mike Rapoport wrote: >> Do we want to make users decide if they need MIGRATION when MEMORY_FAILURE >> is enabled? >> >> Just make MEMORY_FAILURE select MIGRATION. > > I agree with this solution, but I discovered another way: just like > commit 6ebf98d71f9b509e833e ("mm: introduce CONFIG_NUMA_MIGRATION and > simplify CONFIG_MIGRATION") done, add CONFIG_MEMORY_FAILURE_MIGRATION > to select MIGRATION. The Modification is also very simple: > ```patch > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > index a8b03e2920ba..500e54ace6c9 100644 > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -1340,9 +1340,11 @@ static inline bool HWPoisonHandlable(struct page *page, unsigned long flags) > if (PageSlab(page)) > return false; > > +#ifdef CONFIG_MEMORY_FAILURE_MIGRATION > /* Soft offline could migrate movable_ops pages */ > if ((flags & MF_SOFT_OFFLINE) && page_has_movable_ops(page)) > return true; > +#endif > > return PageLRU(page) || is_free_buddy_page(page); > } > @@ -2028,7 +2030,8 @@ static int get_huge_page_for_hwpoison(unsigned long pfn, int flags, > count_increased = true; > } else if (folio_test_hugetlb_freed(folio)) { > ret = MF_HUGETLB_FREED; > - } else if (folio_test_hugetlb_migratable(folio)) { > + } else if (IS_ENABLED(CONFIG_MEMORY_FAILURE_MIGRATION) && > + folio_test_hugetlb_migratable(folio)) { > if (folio_try_get(folio)) { > ret = MF_HUGETLB_IN_USED; > count_increased = true; > @@ -2051,10 +2054,12 @@ static int get_huge_page_for_hwpoison(unsigned long pfn, int flags, > * Clearing hugetlb_migratable for hwpoisoned hugepages to prevent them > * from being migrated by memory hotremove. > */ > +#ifdef CONFIG_MEMORY_FAILURE_MIGRATION > if (count_increased && folio_test_hugetlb_migratable(folio)) { > folio_clear_hugetlb_migratable(folio); > *migratable_cleared = true; > } > +#endif > > spin_unlock_irq(&hugetlb_lock); > return ret; > @@ -2903,7 +2908,7 @@ static int soft_offline_in_use_page(struct page *page) > return 0; > } > > - isolated = isolate_folio_to_list(folio, &pagelist); > + isolated = IS_ENABLED(CONFIG_MEMORY_FAILURE_MIGRATION) && isolate_folio_to_list(folio, &pagelist); > > /* > * If we succeed to isolate the folio, we grabbed another refcount on > ``` > > Would this be a better way? Why add a new config option? -- Cheers, David