From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752027AbcG2Col (ORCPT ); Thu, 28 Jul 2016 22:44:41 -0400 Received: from lucky1.263xmail.com ([211.157.147.133]:48714 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751416AbcG2Coi (ORCPT ); Thu, 28 Jul 2016 22:44:38 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: shawn.lin@rock-chips.com X-FST-TO: devicetree@vger.kernel.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: shawn.lin@rock-chips.com X-UNIQUE-TAG: <0957e187e6e4636a0b136d8f44953ed0> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH 2/2] mmc: dw_mmc: remove the deprecated "supports-highspeed" property To: Jaehoon Chung , linux-mmc@vger.kernel.org References: <1469699727-23339-1-git-send-email-jh80.chung@samsung.com> <1469699727-23339-2-git-send-email-jh80.chung@samsung.com> Cc: shawn.lin@rock-chips.com, ulf.hansson@linaro.org, linux-kernel@vger.kernel.org, Rob Herrin , mark.rutland@arm.com, devicetree@vger.kernel.org From: Shawn Lin Message-ID: <0dc812a2-8b80-03cf-b253-58f7f45ab72b@rock-chips.com> Date: Fri, 29 Jul 2016 10:44:27 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1469699727-23339-2-git-send-email-jh80.chung@samsung.com> Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ÔÚ 2016/7/28 17:55, Jaehoon Chung дµÀ: > Remvoe the deprecated "supports-highspeed" property. > DWMMC controller will not use this property anymore. > We had set up a flag day to remove these deprecated property long time agao. It doesn't *break* old dtb which may(not ?) still boot up new kernel code as we just make it suffer from lower speed, then I think it's time for them to migrate to the new property anyway. So, Reviewed-by: Shawn Lin > Signed-off-by: Jaehoon Chung > --- > drivers/mmc/host/dw_mmc.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c > index 1b719a6..e9faedd 100644 > --- a/drivers/mmc/host/dw_mmc.c > +++ b/drivers/mmc/host/dw_mmc.c > @@ -2890,11 +2890,6 @@ static struct dw_mci_board *dw_mci_parse_dt(struct dw_mci *host) > return ERR_PTR(ret); > } > > - if (of_find_property(np, "supports-highspeed", NULL)) { > - dev_info(dev, "supports-highspeed property is deprecated.\n"); > - pdata->caps |= MMC_CAP_SD_HIGHSPEED | MMC_CAP_MMC_HIGHSPEED; > - } > - > return pdata; > } > > -- Best Regards Shawn Lin