From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Matthias Schiffer <mschiffer@universe-factory.net>,
davem@davemloft.net, jbenc@redhat.com,
hannes@stressinduktion.org, pshelar@ovn.org, aduyck@mirantis.com,
roopa@cumulusnetworks.com
Cc: netdev@vger.kernel.org, dev@openvswitch.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 4/6] vxlan: check valid combinations of address scopes
Date: Fri, 14 Apr 2017 20:27:43 +0300 [thread overview]
Message-ID: <0dd0812f-41d7-f4d8-2b40-0ff5b4553cf5@cogentembedded.com> (raw)
In-Reply-To: <49cd788f13c2cd3f6a42f34c219c9511cc1f9cec.1492187126.git.mschiffer@universe-factory.net>
On 04/14/2017 07:44 PM, Matthias Schiffer wrote:
> * Multicast addresses are never valid as local address
> * Link-local IPv6 unicast addresses may only be used as remote when the
> local address is link-local as well
> * Don't allow link-local IPv6 local/remote addresses without interface
>
> We also store in the flags field if link-local addresses are used for the
> follow-up patches that actually make VXLAN over link-local IPv6 work.
>
> Signed-off-by: Matthias Schiffer <mschiffer@universe-factory.net>
> ---
>
> v2: was "vxlan: don't allow link-local IPv6 local/remote addresses without
> interface" before. v2 does a lot more checks and adds the
> VXLAN_F_IPV6_LINKLOCAL flag.
>
> drivers/net/vxlan.c | 35 +++++++++++++++++++++++++++++++++++
> include/net/vxlan.h | 2 ++
> 2 files changed, 37 insertions(+)
>
> diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
> index 07f89b037681..95a71546e8f2 100644
> --- a/drivers/net/vxlan.c
> +++ b/drivers/net/vxlan.c
> @@ -2881,11 +2881,39 @@ static int vxlan_config_validate(struct net *src_net, struct vxlan_config *conf,
> if (conf->saddr.sa.sa_family != conf->remote_ip.sa.sa_family)
> return -EINVAL;
>
> + if (vxlan_addr_multicast(&conf->saddr))
> + return -EINVAL;
> +
> if (conf->saddr.sa.sa_family == AF_INET6) {
> if (!IS_ENABLED(CONFIG_IPV6))
> return -EPFNOSUPPORT;
> use_ipv6 = true;
> conf->flags |= VXLAN_F_IPV6;
> +
> + if (!(conf->flags & VXLAN_F_COLLECT_METADATA)) {
> + int local_type =
> + ipv6_addr_type(&conf->saddr.sin6.sin6_addr);
> + int remote_type =
> + ipv6_addr_type(&conf->remote_ip.sin6.sin6_addr);
> +
> + if (local_type & IPV6_ADDR_LINKLOCAL) {
> + if (!(remote_type & IPV6_ADDR_LINKLOCAL) &&
> + (remote_type != IPV6_ADDR_ANY)) {
> + pr_info("invalid combination of address scopes\n");
Maybe pr_err()?
> + return -EINVAL;
> + }
> +
> + conf->flags |= VXLAN_F_IPV6_LINKLOCAL;
> + } else {
> + if (remote_type ==
> + (IPV6_ADDR_UNICAST | IPV6_ADDR_LINKLOCAL)) {
> + pr_info("invalid combination of address scopes\n");
Here as well...
> + return -EINVAL;
> + }
> +
> + conf->flags &= ~VXLAN_F_IPV6_LINKLOCAL;
> + }
> + }
> }
>
> if (conf->label && !use_ipv6) {
[...]
MBR, Sergei
next prev parent reply other threads:[~2017-04-14 17:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-14 16:44 [PATCH net-next v2 0/6] vxlan: cleanup and IPv6 link-local support Matthias Schiffer
2017-04-14 16:44 ` [PATCH net-next v2 1/6] vxlan: refactor verification and application of configuration Matthias Schiffer
2017-04-14 16:44 ` [PATCH net-next v2 2/6] vxlan: get rid of redundant vxlan_dev.flags Matthias Schiffer
2017-04-14 16:44 ` [PATCH net-next v2 3/6] vxlan: improve validation of address family configuration Matthias Schiffer
2017-04-14 16:44 ` [PATCH net-next v2 4/6] vxlan: check valid combinations of address scopes Matthias Schiffer
2017-04-14 17:27 ` Sergei Shtylyov [this message]
2017-04-16 14:57 ` Matthias Schiffer
2017-04-14 17:36 ` Stephen Hemminger
2017-04-16 15:03 ` Matthias Schiffer
2017-04-16 17:15 ` Roopa Prabhu
2017-04-14 16:44 ` [PATCH net-next v2 5/6] vxlan: fix snooping for link-local IPv6 addresses Matthias Schiffer
2017-04-14 16:44 ` [PATCH net-next v2 6/6] vxlan: allow multiple VXLANs with same VNI for IPv6 link-local addresses Matthias Schiffer
2017-04-14 17:38 ` Stephen Hemminger
2017-04-16 15:15 ` Matthias Schiffer
2017-06-08 18:05 ` Matthias Schiffer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0dd0812f-41d7-f4d8-2b40-0ff5b4553cf5@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=aduyck@mirantis.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=hannes@stressinduktion.org \
--cc=jbenc@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mschiffer@universe-factory.net \
--cc=netdev@vger.kernel.org \
--cc=pshelar@ovn.org \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®