From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A4D61F1301 for ; Fri, 27 Dec 2024 10:34:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735295678; cv=none; b=NTiy55fRCxZcFPI4VouIbG6FqKOLNSVzvC2x1dmd14+uHuK2nA48CJSezqi4kEcN0iU2SGNpIuSR03FEFf9wEXxtPKfo4lOZpqvUR69WcJN4SaVaBKITQyJ8xBD5AqjF2WqwVu/6mJXuwpA6G3w74GYg1XwqBT93uvVIqgU2Wks= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735295678; c=relaxed/simple; bh=EjfyHJ66EKfF0d3KJtmT2YtWz9j4wnDHtF/m7tTKp98=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fAUL85x6kzvyDUUZPu7VYY9QtpYfphm78moQP4EFKHxqLtHRq/478S4D4ETeRFEtFTTFFfsY/itCxVOpdeHGjapyWMsZo+OiZrs237M2P+rPgSZkkrtqFL+iCcJQBX6lP6AZWVDW6MwrFZ965iFBtszdgbZWFNka3espLV1vGDI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=HGDWiVz5; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="HGDWiVz5" Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4BR85eVV003598; Fri, 27 Dec 2024 10:34:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=/DQvCi NPnnZO+rTl/hONFzvLITaJ9hLi2huHesCNJec=; b=HGDWiVz5ckd7RRPMrKP5+z Ua5fzfALPYEJ3OFf33nOqbrD2PzXLREbClFUHyNyNtoIKnUeXa+cR15xhLhERGgE YNbmKuorUeqj6K2ubl0jFzAwNzlrWYKk2+I1oIRn6q643//iuyc4B+ALGSuQzk9x Ag7PTo0civqtrg2MkoISoNHU1dykgnKpO8XUQw0FdF8u37VTmIbhK3bXck2xRfHN 9/CS5tgHK20aeQiwN1PoME3LdqHmiRlXoeOhzwQUlJeXT/4EiBJn6UlfprGRUOG7 o6oCbjLplEGd193dMLNoIntQYgfrzRVLG97dum+Ru0n++SHTLcM0JRmIe62xoM1A == Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 43sre2gej3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 27 Dec 2024 10:34:14 +0000 (GMT) Received: from m0360072.ppops.net (m0360072.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 4BRAVldr030015; Fri, 27 Dec 2024 10:34:13 GMT Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 43sre2gej1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 27 Dec 2024 10:34:13 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 4BRA6CxM002062; Fri, 27 Dec 2024 10:34:13 GMT Received: from smtprelay07.wdc07v.mail.ibm.com ([172.16.1.74]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 43pa7k58y4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 27 Dec 2024 10:34:13 +0000 Received: from smtpav04.wdc07v.mail.ibm.com (smtpav04.wdc07v.mail.ibm.com [10.39.53.231]) by smtprelay07.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 4BRAYCCd39977242 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 27 Dec 2024 10:34:12 GMT Received: from smtpav04.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5405F58069; Fri, 27 Dec 2024 10:34:12 +0000 (GMT) Received: from smtpav04.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B232858064; Fri, 27 Dec 2024 10:34:07 +0000 (GMT) Received: from [9.179.17.222] (unknown [9.179.17.222]) by smtpav04.wdc07v.mail.ibm.com (Postfix) with ESMTP; Fri, 27 Dec 2024 10:34:07 +0000 (GMT) Message-ID: <0dd42f11-2c2d-4fab-a115-2b0c8c69952d@linux.ibm.com> Date: Fri, 27 Dec 2024 16:04:05 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC v2 PATCH 2/5] memory: move conditionally defined enums use inside ifdef tags To: Gregory Price , linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, nehagholkar@meta.com, abhishekd@meta.com, kernel-team@meta.com, david@redhat.com, nphamcs@gmail.com, akpm@linux-foundation.org, hannes@cmpxchg.org, kbusch@meta.com, ying.huang@linux.alibaba.com References: <20241210213744.2968-1-gourry@gourry.net> <20241210213744.2968-3-gourry@gourry.net> Content-Language: en-US From: Donet Tom In-Reply-To: <20241210213744.2968-3-gourry@gourry.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: SVWmR1vxoczy2I-GNj3wzeTYk-y4RJ7K X-Proofpoint-GUID: gL1BRGuBlCSE3Vg_5mIKJhoOV9rxR2o0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-15_01,2024-10-11_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 lowpriorityscore=0 malwarescore=0 mlxlogscore=999 adultscore=0 spamscore=0 impostorscore=0 bulkscore=0 phishscore=0 clxscore=1011 priorityscore=1501 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2412270087 On 12/11/24 03:07, Gregory Price wrote: > NUMA_HINT_FAULTS and NUMA_HINT_FAULTS_LOCAL are only defined if > CONFIG_NUMA_BALANCING is defined, but are used outside the tags in > numa_migrate_check(). Fix this. > > TNF_SHARED is only used if CONFIG_NUMA_BALANCING is enabled, so > moving this line inside the ifdef is also safe - despite use of TNF_* > elsewhere in the function. TNF_* are not conditionally defined. > > Signed-off-by: Gregory Price > --- > mm/memory.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/memory.c b/mm/memory.c > index 83fd35c034d7..6ad7616918c4 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -5573,14 +5573,14 @@ int numa_migrate_check(struct folio *folio, struct vm_fault *vmf, > /* Record the current PID acceesing VMA */ > vma_set_access_pid_bit(vma); > > - count_vm_numa_event(NUMA_HINT_FAULTS); > #ifdef CONFIG_NUMA_BALANCING IIUC,|do_huge_pmd_numa_page|() and|do_numa_page()| are executed only if |CONFIG_NUMA_BALANCING| is enabled (|pte_protnone()| and|pmd_protnone()| return 0 if|CONFIG_NUMA_BALANCING| is disabled). Given this, do we still need the|#ifdef|? > + count_vm_numa_event(NUMA_HINT_FAULTS); > count_memcg_folio_events(folio, NUMA_HINT_FAULTS, 1); > -#endif > if (folio_nid(folio) == numa_node_id()) { > count_vm_numa_event(NUMA_HINT_FAULTS_LOCAL); > *flags |= TNF_FAULT_LOCAL; > } > +#endif > > return mpol_misplaced(folio, vmf, addr); > }