mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: imran.f.khan@oracle.com
To: Thomas Gleixner <tglx@linutronix.de>
Cc: x86@kernel.org, hpa@zytor.com, linux-kernel@vger.kernel.org,
	mingo@redhat.com, bp@alien8.de
Subject: Re: [RFC PATCH] x86/apic: Fix BUG due to multiple allocation of legacy vectors.
Date: Thu, 27 May 2021 15:13:26 +1000	[thread overview]
Message-ID: <0dd4a1a6-7550-7059-150e-9d143a5b20db@oracle.com> (raw)
In-Reply-To: <871r9uamu5.ffs@nanos.tec.linutronix.de>

Hi Thomas,

On 26/5/21 12:51 am, Thomas Gleixner wrote:
> Imran,
> 
> On Mon, May 24 2021 at 13:29, imran f. khan wrote:
[...]
> 
>> Even my current setup that was crashing with in-house 5.4 and 5.8
>> kernels, boots fine if I boot it with noapic option removed from kernel
>> boot parameters.
> 
> May I ask the obvious question why the changelog of your patch did not
> mention that this happens only with 'noapic' on the kernel command line?
> 
I was not aware of it earlier. After your first feedback I debugged the 
code further with ML tag and found out about the noapic dependency.
[...]
> 
> Correct. So you almost decoded the underlying problem.
> 
[...]
> So the right thing to do is to ensure that the legacy interrupts are
> marked as system vectors in case that the IO/APIC is disabled via
> config, kernel command line or lack of enumeration. See below.
> 
Thanks for clarifying it. I have tested your change in my local setup as 
well and it works well.

Thanks,
Imran

  reply	other threads:[~2021-05-27  5:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-19 23:39 Imran Khan
2021-05-20  5:56 ` Greg KH
2021-05-20  6:22   ` imran.f.khan
2021-05-20  8:17 ` Thomas Gleixner
2021-05-24  3:29   ` imran.f.khan
2021-05-25 14:51     ` Thomas Gleixner
2021-05-27  5:13       ` imran.f.khan [this message]
2021-05-29 11:27 ` [tip: x86/urgent] x86/apic: Mark _all_ legacy interrupts when IO/APIC is missing tip-bot2 for Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0dd4a1a6-7550-7059-150e-9d143a5b20db@oracle.com \
    --to=imran.f.khan@oracle.com \
    --cc=bp@alien8.de \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®