From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 719FF1DEFE8 for ; Mon, 1 Jun 2026 06:17:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780294666; cv=none; b=XIPNVAPRxxANq6cYyCj+825pH8T0HFYcMfVzJD8XL/ePeGjkP2LeTqzn30Mtqh0/tDpUHG0k/Yqd7yBeRNT/S/98STpDR9YXsvv0EsgkAcTP9KWEQbZv5VWyis4VnI5PJT/qp3qHf3sp2DdVSkTq6MyE3fBmByYNJ+pTZve9UQQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780294666; c=relaxed/simple; bh=DOaCBJszeEJinofNr2lzj3UzRWu6io6VMPCUTe2YiMs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Fh6YrMar+GjVMF5W01wFVL5EhlhV7UJ00UMbvF4g9FpB8myDpKEv2jHWFlcmVW8zbiSKFVK24z/1zd0Bgx4h24yfyA7dXbKmQSZXO/a07T6TIveN7w9qRy8kBsNbzX8g5km4shLZH0Io0j2hnumbFzBUDfYFh3wvJhixoiPT2IA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ZqucSbV8; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZqucSbV8" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C32B71F00893; Mon, 1 Jun 2026 06:17:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780294665; bh=DOaCBJszeEJinofNr2lzj3UzRWu6io6VMPCUTe2YiMs=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=ZqucSbV8hFlVZ1MlIw7dKHjWn+WTilN3Xvl4/QRQAicoAXfqKiwJEaB0smexjQ5Na 3HCDHSfMgenQ2mhbn7F6O4N7ua35jZPeeISQtY2htw8RpVwzVtCnIqIHMoUVN4liUa RkDR5eoW40yD1upA4fr3/UVYWAV7SkKbCYGiS9MYnI/QxVIUcRSfOIjWEHPZQFXdEA XEjabGKAKWK+gRWlqxuMRwO/yVoWxD8qyHBhpn5MliqsJxuREAD8/Ntde/H9CKT4Pq MrjUTxhmbCdTKMkr2447yZF22Yo9TF4Hy81fHgOnphG21+3oMIG0QyZ0tSPFwfZaty +pyJJn3exK/HQ== Message-ID: <0dd720f2-7732-4801-85d5-4593e90e8cde@kernel.org> Date: Mon, 1 Jun 2026 15:17:33 +0900 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] mm/slub: introduce helpers for node partial slab state To: Hao Li Cc: vbabka@kernel.org, akpm@linux-foundation.org, cl@gentwo.org, rientjes@google.com, roman.gushchin@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20260529035120.81304-1-hao.li@linux.dev> <20260529035120.81304-2-hao.li@linux.dev> <5ed81b4a-1d18-4535-a18c-1bb31969ae78@kernel.org> Content-Language: en-US From: Harry Yoo In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------54aSwY6HzRt0JvxlxSoZOFQO" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------54aSwY6HzRt0JvxlxSoZOFQO Content-Type: multipart/mixed; boundary="------------10OOyuURfKZOfOnV30ucBNtn"; protected-headers="v1" From: Harry Yoo To: Hao Li Cc: vbabka@kernel.org, akpm@linux-foundation.org, cl@gentwo.org, rientjes@google.com, roman.gushchin@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Message-ID: <0dd720f2-7732-4801-85d5-4593e90e8cde@kernel.org> Subject: Re: [PATCH v3 1/2] mm/slub: introduce helpers for node partial slab state References: <20260529035120.81304-1-hao.li@linux.dev> <20260529035120.81304-2-hao.li@linux.dev> <5ed81b4a-1d18-4535-a18c-1bb31969ae78@kernel.org> In-Reply-To: --------------10OOyuURfKZOfOnV30ucBNtn Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 6/1/26 2:26 PM, Hao Li wrote: > On Mon, Jun 01, 2026 at 12:38:48PM +0900, Harry Yoo wrote: >> >> >> On 5/29/26 12:50 PM, Hao Li wrote: >>> Wrap partial slab count inc/dec and flag set/clear into >>> helper functions to reduce code duplication. >>> >>> Note that __add_partial() is called locklessly in >>> early_kmem_cache_node_alloc(), but since there is no such use case fo= r >>> removal, __remove_partial() does not exist. >> >> nit: __remove_partial() -> clear_partial_node_state() >=20 > Ah, in this sentence, I just wanted to clarify that __remove_partial do= esn't > exist. it's not a typo :) >=20 >> oh wait, it does exist. Let's drop this paragraph? >=20 > This paragraph is just a quick side note to explain why __remove_partia= l() > doesn't exist. I noticed that __add_partial lacks a symmetric counterpa= rt, > which felt a bit abrupt/inconsistent, so I wanted to share some context= on why > that is. Ah, I see. I was confused because it didn't touch those functions :) Thanks! --=20 Cheers, Harry / Hyeonggon --------------10OOyuURfKZOfOnV30ucBNtn-- --------------54aSwY6HzRt0JvxlxSoZOFQO Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQQQ1ub6gR5ogjaKRmOGXBN6rc5S1gUCah0j/gAKCRCGXBN6rc5S 1uFvAP0XfcrNFQCIz3fQt6P5mIFUpar5IMWnPdjiBh+wg9GzwQD/dJws5J1S+Hg3 wDmGHJplNfTtjLoHpnYcWG4YYBPJzAs= =X0Y1 -----END PGP SIGNATURE----- --------------54aSwY6HzRt0JvxlxSoZOFQO--