From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 185221A5BAE for ; Mon, 1 Jun 2026 16:20:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780330816; cv=none; b=GFzbpQfhxRnx5KsReDEfjmv7vvBjnu8uwYkQmzfMOyBobYWp33wyWnQsYMu6+ZHOX/LsDo/oTa9khszxArXFyeVL13njmv7aoCTjnXoV7zymCcvdZPI62posAG64Xd1ovruAJVp9qkkxXxeZ2dgxSOaal8jg50qTkaHeXBzch20= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780330816; c=relaxed/simple; bh=cnI3Idi07zjOKrWdVm3sqNzx6usUbRGSzKgVE09Cmog=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Mk2euzsky0vVVNmb+o9sPiHDmI5vDApYmKVD9PIRH44EgSvza/4dqy9oajUQGsJHJO1w+12rM9f97M2jvlVvAks3d9XwNkBfmI41pp6vcZOMICv/I2d8PbujU+SKUuwXItEAXbqVethC1ZxAhECkin0x9QgzKxgYBi8SISBQRY4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=DJtEHlEX; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="DJtEHlEX" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1780330813; bh=cnI3Idi07zjOKrWdVm3sqNzx6usUbRGSzKgVE09Cmog=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=DJtEHlEXjtDBkWu5AU/W5PbdG8L9UmI1P8JRmmp/+gnFyZLDcT2OWO1I9YJuZc4aD lDRl8xvudOmfDg7eugtxkwdcdmNW6wifYDxWOnymjVjdVM7kRl5FLSIR6oc1N2Jlyc nJWVVMQPck5SlwXveroCOM8L1CRJA6IkgJCLCAp8Mo6srjcRTD+Q2cBhYmDjLeox4v cyY7PI8FAH8cOdoLEWy3HbXX5bSqt1o+Zt+KDbu7oA5JuNnx3ClOhCfgevlT7TTDr5 q4lpz+cHiFxYo0sa0oH3Alj6ENqBdwlMYlWJI7cOFlm2AjjROjawY5wMq12IKj3BQh bt0u1qoQ1m33A== Received: from [100.64.0.241] (unknown [100.64.0.241]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by bali.collaboradmins.com (Postfix) with ESMTPSA id A195817E03DA; Mon, 1 Jun 2026 18:20:12 +0200 (CEST) Message-ID: <0dd8e7dd-d772-4fa7-b92e-124517009b34@collabora.com> Date: Mon, 1 Jun 2026 19:20:12 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/2] drm/rockchip: dw_dp: Release core resources To: Andy Yan , Sandy Huang , =?UTF-8?Q?Heiko_St=C3=BCbner?= , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Dmitry Baryshkov , Dmitry Baryshkov , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec Cc: kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260327-drm-rk-fixes-v3-0-fd2e6900c08c@collabora.com> <20260327-drm-rk-fixes-v3-2-fd2e6900c08c@collabora.com> Content-Language: en-US From: Cristian Ciocaltea In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Andy, On 5/31/26 1:29 PM, Andy Yan wrote: > Hello, > > On 3/27/26 08:55, Cristian Ciocaltea wrote: >> Core resources such as the DisplayPort AUX channel get initialized and >> registered during dw_dp_bind(), but are never unregistered, which may >> lead to memory leaks and/or use-after-free: >> >> [ 224.661371] BUG: KASAN: slab-use-after-free in device_is_dependent+0xe0/0x2b0 >> [ 224.662015] Read of size 8 at addr ffff00011aee8550 by task modprobe/658 >> [ 224.662612] >> [ 224.662752] CPU: 7 UID: 0 PID: 658 Comm: modprobe Not tainted 7.0.0-rc2-next-20260305 #14 PREEMPT >> [ 224.662759] Hardware name: Radxa ROCK 5B (DT) >> [ 224.662762] Call trace: >> [ 224.662764] show_stack+0x20/0x38 (C) >> [ 224.662772] dump_stack_lvl+0x6c/0x98 >> [ 224.662777] print_report+0x160/0x4b8 >> [ 224.662783] kasan_report+0xb4/0xe0 >> [ 224.662790] __asan_report_load8_noabort+0x20/0x30 >> [ 224.662796] device_is_dependent+0xe0/0x2b0 >> [ 224.662802] device_is_dependent+0x108/0x2b0 >> [ 224.662808] device_link_add+0x1f8/0x10b0 >> [ 224.662813] devm_of_phy_get_by_index+0x120/0x200 >> [ 224.662819] dw_dp_bind+0x34c/0xb10 [dw_dp] >> [ 224.662830] dw_dp_rockchip_bind+0x194/0x250 [rockchipdrm] >> [ 224.662864] component_bind_all+0x3a8/0x720 >> [ 224.662869] rockchip_drm_bind+0x120/0x390 [rockchipdrm] >> [ 224.662899] try_to_bring_up_aggregate_device+0x76c/0x838 >> [ 224.662904] component_master_add_with_match+0x1f4/0x230 >> [ 224.662909] rockchip_drm_platform_probe+0x420/0x538 [rockchipdrm] >> [ 224.662939] platform_probe+0xe8/0x168 >> [ 224.662945] really_probe+0x340/0x828 >> [ 224.662950] __driver_probe_device+0x2e0/0x350 >> [ 224.662954] driver_probe_device+0x80/0x140 >> [ 224.662959] __driver_attach+0x398/0x460 >> [ 224.662964] bus_for_each_dev+0xe0/0x198 >> [ 224.662968] driver_attach+0x50/0x68 >> [ 224.662972] bus_add_driver+0x2a0/0x4c0 >> [ 224.662977] driver_register+0x294/0x360 >> [ 224.662982] __platform_driver_register+0x7c/0x98 >> [ 224.662987] rockchip_drm_init+0xc4/0xff8 [rockchipdrm] >> >> Since a previous commit exported dw_dp_unbind() function in DW DP core >> library to take care of the necessary cleanup, use this in the >> component's unbind() callback, as well as in its bind() error path. >> >> Fixes: d68ba7bac955 ("drm/rockchip: Add RK3588 DPTX output support") >> Signed-off-by: Cristian Ciocaltea >> --- >> drivers/gpu/drm/rockchip/dw_dp-rockchip.c | 20 +++++++++++++++++--- >> 1 file changed, 17 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/gpu/drm/rockchip/dw_dp-rockchip.c b/drivers/gpu/drm/rockchip/dw_dp-rockchip.c >> index 22c0911f1896..8cba90d2dd56 100644 >> --- a/drivers/gpu/drm/rockchip/dw_dp-rockchip.c >> +++ b/drivers/gpu/drm/rockchip/dw_dp-rockchip.c >> @@ -108,14 +108,28 @@ static int dw_dp_rockchip_bind(struct device *dev, struct device *master, void * >> connector = drm_bridge_connector_init(drm_dev, encoder); >> if (IS_ERR(connector)) >> - return dev_err_probe(dev, PTR_ERR(connector), >> - "Failed to init bridge connector"); >> + ret = dev_err_probe(dev, PTR_ERR(connector), >> + "Failed to init bridge connector"); >> + else >> + ret = drm_connector_attach_encoder(connector, encoder); >> - return drm_connector_attach_encoder(connector, encoder); > > This line has already been removed in the latest code. Indeed, handled now in v4 [1] by rebasing onto latest drm-misc. Also added a new patch to fix a missing "\n". Thanks for reviewing! Regards, Cristian [1] https://lore.kernel.org/all/20260601-drm-rk-fixes-v4-0-c3f3f123e1da@collabora.com/