From: Hriday Hegde <hridayhegde1999@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Arve Hjønnevåg" <arve@android.com>,
"Todd Kjos" <tkjos@android.com>,
"Martijn Coenen" <maco@android.com>,
"Joel Fernandes" <joel@joelfernandes.org>,
"Christian Brauner" <christian@brauner.io>,
"Hridya Valsaraju" <hridya@google.com>,
"Suren Baghdasaryan" <surenb@google.com>,
linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: android: ashmem: Declared file operation with 'const' keyword
Date: Wed, 19 May 2021 15:00:08 +0530 [thread overview]
Message-ID: <0ddb894f-f66f-f31b-ef8a-0646e0a99b9f@gmail.com> (raw)
In-Reply-To: <YKTM8KmXI8bXUSqp@kroah.com>
I am not really sure how to do that and how to reflect it in the patch i followed what was taught in the Beginners course and it does not mention building. I know i need to test it out but is running 'patch -p1 < x.patch what i need to do?
On 19-05-2021 14:01, Greg Kroah-Hartman wrote:
> On Wed, May 19, 2021 at 01:19:58AM -0700, Hriday Hegde wrote:
>> Fixing following warnings found by checkpatch.pl
>> WARNING: struct file_operations should normally be const
>> 380: FILE: drivers/staging/android/ashmem.c:380:
>> + static struct file_operations vmfile_fops;
>>
>> Signed-off-by: Hriday Hegde <hridayhegde1999@gmail.com>
>> ---
>> drivers/staging/android/ashmem.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c
>> index 8ee4320a5dc6..8ff2794b08e3 100644
>> --- a/drivers/staging/android/ashmem.c
>> +++ b/drivers/staging/android/ashmem.c
>> @@ -377,7 +377,7 @@ ashmem_vmfile_get_unmapped_area(struct file *file, unsigned long addr,
>>
>> static int ashmem_mmap(struct file *file, struct vm_area_struct *vma)
>> {
>> - static struct file_operations vmfile_fops;
>> + static const struct file_operations vmfile_fops;
>> struct ashmem_area *asma = file->private_data;
>> int ret = 0;
>>
>> --
>> 2.25.1
>>
>>
> Any reason why you didn't build your change before submitting this
> patch?
>
> thanks,
>
> greg k-h
next prev parent reply other threads:[~2021-05-19 9:30 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-19 8:19 Hriday Hegde
2021-05-19 8:31 ` Greg Kroah-Hartman
2021-05-19 9:30 ` Hriday Hegde [this message]
2021-05-19 9:50 ` Greg Kroah-Hartman
2021-05-19 14:36 ` Hriday Hegde
2021-05-19 14:51 ` Fabio Aiuto
2021-05-19 15:54 ` Hriday Hegde
2021-05-19 14:55 ` Greg Kroah-Hartman
2021-05-19 15:56 ` Hriday Hegde
-- strict thread matches above, loose matches on Subject: below --
2022-01-24 7:09 [PATCH] staging: android: ashmem: Declared file operation with const keyword ratnesh-r1
2022-01-24 7:39 ` Greg Kroah-Hartman
2022-01-24 11:20 ` kernel test robot
2022-01-24 12:27 ` kernel test robot
2021-02-14 2:31 Thais Camacho
2021-02-14 4:49 ` kernel test robot
2021-02-14 8:21 ` Greg Kroah-Hartman
2020-12-28 5:13 jovin555
2020-12-28 6:35 ` Greg Kroah-Hartman
2021-01-05 11:52 ` Dan Carpenter
2020-03-28 15:15 SandeshKenjanaAshok
2020-03-29 6:58 ` Greg Kroah-Hartman
2020-03-29 12:54 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ddb894f-f66f-f31b-ef8a-0646e0a99b9f@gmail.com \
--to=hridayhegde1999@gmail.com \
--cc=arve@android.com \
--cc=christian@brauner.io \
--cc=gregkh@linuxfoundation.org \
--cc=hridya@google.com \
--cc=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=maco@android.com \
--cc=surenb@google.com \
--cc=tkjos@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®